* [PATCH] s5p-jpeg: Add initial device tree support for S5PV210/Exynos4210 SoCs
@ 2013-08-18 20:14 Sylwester Nawrocki
2013-08-23 16:01 ` Sylwester Nawrocki
0 siblings, 1 reply; 4+ messages in thread
From: Sylwester Nawrocki @ 2013-08-18 20:14 UTC (permalink / raw)
To: linux-media
Cc: devicetree, linux-samsung-soc, Sylwester Nawrocki,
Andrzej Pietrasiewicz
This patch enables the JPEG codec on S5PV210 and Exynos4210 SoCs. There are
some differences in newer versions of the JPEG codec IP on SoCs like Exynos4x12
and Exynos5 series and support for them will be added in subsequent patches.
Cc: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
.../bindings/media/exynos-jpeg-codec.txt | 11 +++++++++++
drivers/media/platform/s5p-jpeg/jpeg-core.c | 12 +++++++++++-
2 files changed, 22 insertions(+), 1 deletions(-)
create mode 100644 Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt
diff --git a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt
new file mode 100644
index 0000000..937b755
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt
@@ -0,0 +1,11 @@
+Samsung S5P/EXYNOS SoC series JPEG codec
+
+Required properties:
+
+- compatible : should be one of:
+ "samsung,s5pv210-jpeg", "samsung,exynos4210-jpeg";
+- reg : address and length of the JPEG codec IP register set;
+- interrupts : specifies the JPEG codec IP interrupt;
+- clocks : should contain the JPEG codec IP gate clock specifier, from the
+ common clock bindings;
+- clock-names : should contain "jpeg" entry.
diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c
index 15d2396..88c5beb 100644
--- a/drivers/media/platform/s5p-jpeg/jpeg-core.c
+++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c
@@ -17,6 +17,7 @@
#include <linux/io.h>
#include <linux/kernel.h>
#include <linux/module.h>
+#include <linux/of.h>
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
#include <linux/slab.h>
@@ -1513,10 +1514,20 @@ static const struct dev_pm_ops s5p_jpeg_pm_ops = {
.runtime_resume = s5p_jpeg_runtime_resume,
};
+#ifdef CONFIG_OF
+static const struct of_device_id s5p_jpeg_of_match[] = {
+ { .compatible = "samsung,s5pv210-jpeg" },
+ { .compatible = "samsung,exynos4210-jpeg" },
+ { /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(of, s5p_jpeg_of_match);
+#endif
+
static struct platform_driver s5p_jpeg_driver = {
.probe = s5p_jpeg_probe,
.remove = s5p_jpeg_remove,
.driver = {
+ .of_match_table = of_match_ptr(s5p_jpeg_of_match),
.owner = THIS_MODULE,
.name = S5P_JPEG_M2M_NAME,
.pm = &s5p_jpeg_pm_ops,
@@ -1528,4 +1539,3 @@ module_platform_driver(s5p_jpeg_driver);
MODULE_AUTHOR("Andrzej Pietrasiewicz <andrzej.p@samsung.com>");
MODULE_DESCRIPTION("Samsung JPEG codec driver");
MODULE_LICENSE("GPL");
-
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] s5p-jpeg: Add initial device tree support for S5PV210/Exynos4210 SoCs
2013-08-18 20:14 [PATCH] s5p-jpeg: Add initial device tree support for S5PV210/Exynos4210 SoCs Sylwester Nawrocki
@ 2013-08-23 16:01 ` Sylwester Nawrocki
2013-08-23 22:45 ` Stephen Warren
0 siblings, 1 reply; 4+ messages in thread
From: Sylwester Nawrocki @ 2013-08-23 16:01 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: linux-media, devicetree, linux-samsung-soc, Andrzej Pietrasiewicz,
Stephen Warren, Pawel Moll, Mark Rutland, Kumar Gala, Rob Herring
On 08/18/2013 10:14 PM, Sylwester Nawrocki wrote:
> This patch enables the JPEG codec on S5PV210 and Exynos4210 SoCs. There are
> some differences in newer versions of the JPEG codec IP on SoCs like Exynos4x12
> and Exynos5 series and support for them will be added in subsequent patches.
>
> Cc: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Could a DT maintainer review/Ack the binding in this patch ?
> ---
> .../bindings/media/exynos-jpeg-codec.txt | 11 +++++++++++
> drivers/media/platform/s5p-jpeg/jpeg-core.c | 12 +++++++++++-
> 2 files changed, 22 insertions(+), 1 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt
>
> diff --git a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt
> new file mode 100644
> index 0000000..937b755
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt
> @@ -0,0 +1,11 @@
> +Samsung S5P/EXYNOS SoC series JPEG codec
> +
> +Required properties:
> +
> +- compatible : should be one of:
> + "samsung,s5pv210-jpeg", "samsung,exynos4210-jpeg";
> +- reg : address and length of the JPEG codec IP register set;
> +- interrupts : specifies the JPEG codec IP interrupt;
> +- clocks : should contain the JPEG codec IP gate clock specifier, from the
> + common clock bindings;
> +- clock-names : should contain "jpeg" entry.
> diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c
> index 15d2396..88c5beb 100644
> --- a/drivers/media/platform/s5p-jpeg/jpeg-core.c
> +++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c
> @@ -17,6 +17,7 @@
> #include <linux/io.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/slab.h>
> @@ -1513,10 +1514,20 @@ static const struct dev_pm_ops s5p_jpeg_pm_ops = {
> .runtime_resume = s5p_jpeg_runtime_resume,
> };
>
> +#ifdef CONFIG_OF
> +static const struct of_device_id s5p_jpeg_of_match[] = {
> + { .compatible = "samsung,s5pv210-jpeg" },
> + { .compatible = "samsung,exynos4210-jpeg" },
> + { /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(of, s5p_jpeg_of_match);
> +#endif
> +
> static struct platform_driver s5p_jpeg_driver = {
> .probe = s5p_jpeg_probe,
> .remove = s5p_jpeg_remove,
> .driver = {
> + .of_match_table = of_match_ptr(s5p_jpeg_of_match),
> .owner = THIS_MODULE,
> .name = S5P_JPEG_M2M_NAME,
> .pm = &s5p_jpeg_pm_ops,
> @@ -1528,4 +1539,3 @@ module_platform_driver(s5p_jpeg_driver);
> MODULE_AUTHOR("Andrzej Pietrasiewicz <andrzej.p@samsung.com>");
> MODULE_DESCRIPTION("Samsung JPEG codec driver");
> MODULE_LICENSE("GPL");
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] s5p-jpeg: Add initial device tree support for S5PV210/Exynos4210 SoCs
2013-08-23 16:01 ` Sylwester Nawrocki
@ 2013-08-23 22:45 ` Stephen Warren
2013-08-27 14:39 ` Sylwester Nawrocki
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Warren @ 2013-08-23 22:45 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: Sylwester Nawrocki, linux-media, devicetree, linux-samsung-soc,
Andrzej Pietrasiewicz, Pawel Moll, Mark Rutland, Kumar Gala,
Rob Herring
On 08/23/2013 10:01 AM, Sylwester Nawrocki wrote:
> On 08/18/2013 10:14 PM, Sylwester Nawrocki wrote:
>> This patch enables the JPEG codec on S5PV210 and Exynos4210 SoCs. There are
>> some differences in newer versions of the JPEG codec IP on SoCs like Exynos4x12
>> and Exynos5 series and support for them will be added in subsequent patches.
>>
>> Cc: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>
> Could a DT maintainer review/Ack the binding in this patch ?
The binding looks reasonable to me, so,
Acked-by: Stephen Warren <swarren@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] s5p-jpeg: Add initial device tree support for S5PV210/Exynos4210 SoCs
2013-08-23 22:45 ` Stephen Warren
@ 2013-08-27 14:39 ` Sylwester Nawrocki
0 siblings, 0 replies; 4+ messages in thread
From: Sylwester Nawrocki @ 2013-08-27 14:39 UTC (permalink / raw)
To: Stephen Warren
Cc: Sylwester Nawrocki, linux-media, devicetree, linux-samsung-soc,
Andrzej Pietrasiewicz, Pawel Moll, Mark Rutland, Kumar Gala,
Rob Herring
On 08/24/2013 12:45 AM, Stephen Warren wrote:
> On 08/23/2013 10:01 AM, Sylwester Nawrocki wrote:
>> > On 08/18/2013 10:14 PM, Sylwester Nawrocki wrote:
>>> >> This patch enables the JPEG codec on S5PV210 and Exynos4210 SoCs. There are
>>> >> some differences in newer versions of the JPEG codec IP on SoCs like Exynos4x12
>>> >> and Exynos5 series and support for them will be added in subsequent patches.
>>> >>
>>> >> Cc: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
>>> >> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> >
>> > Could a DT maintainer review/Ack the binding in this patch ?
>
> The binding looks reasonable to me, so,
> Acked-by: Stephen Warren <swarren@nvidia.com>
Thanks Stephen, I've queued this for v3.13.
--
Regards,
Sylwester
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-27 14:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-18 20:14 [PATCH] s5p-jpeg: Add initial device tree support for S5PV210/Exynos4210 SoCs Sylwester Nawrocki
2013-08-23 16:01 ` Sylwester Nawrocki
2013-08-23 22:45 ` Stephen Warren
2013-08-27 14:39 ` Sylwester Nawrocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).