From: Arnd Bergmann <arnd@arndb.de>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Loc Ho <lho@apm.com>,
chris@printf.net, ulf.hansson@linaro.org,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jcm@redhat.com,
patches@apm.com
Subject: Re: [PATCH v2 2/3] mmc: Add APM X-Gene SoC SDHC controller support to Arasan SDHCI driver
Date: Sat, 14 Jun 2014 23:36:29 +0200 [thread overview]
Message-ID: <5219148.cLBgakF4fc@wuerfel> (raw)
In-Reply-To: <9432f705-fd6a-44a6-8e04-c0455f0a551c@BN1AFFO11FD054.protection.gbl>
On Wednesday 04 June 2014 08:09:12 Michal Simek wrote:
> > +
> > +static void sdhci_arasn_xgene_xlat_addr(struct sdhci_arasan_data *data,
> > + u64 dma_addr)
> > +{
> > + #define AIM_AXI_HI_OFFSET 0x0000000c
> > + #define AIM_AXI_ADDRESS_HI_N_WR(src) \
> > + (((u32) (src) << 20) & 0xfff00000)
>
> ditto with indentation.
> 20 should be shift
> 0xfff00000 is mask.
>
> Also you should take this opportunity and add function description
> in kernel doc to be exactly clear what this function is doing.
Actually this should just be configured in the dma-ranges property
I think. It's not the driver's business to do the dma translation.
Arnd
next prev parent reply other threads:[~2014-06-14 21:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 21:13 [PATCH v2 0/3] mmc: Add APM X-Gene SoC SDHC controller support to Arasan SDHCI driver Loc Ho
2014-06-03 21:13 ` [PATCH v2 1/3] Documentation: Update Arasan SDHC documentation for the APM X-Gene SoC SDHC DTS binding Loc Ho
2014-06-03 21:13 ` [PATCH v2 2/3] mmc: Add APM X-Gene SoC SDHC controller support to Arasan SDHCI driver Loc Ho
2014-06-03 21:13 ` [PATCH v2 3/3] arm64: Add APM X-Gene SoC SDHC controller DTS entry Loc Ho
2014-06-04 6:09 ` [PATCH v2 2/3] mmc: Add APM X-Gene SoC SDHC controller support to Arasan SDHCI driver Michal Simek
2014-06-04 23:15 ` Loc Ho
2014-06-05 7:33 ` Michal Simek
2014-06-14 21:36 ` Arnd Bergmann [this message]
2014-06-04 5:17 ` [PATCH v2 0/3] " Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5219148.cLBgakF4fc@wuerfel \
--to=arnd@arndb.de \
--cc=chris@printf.net \
--cc=devicetree@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=lho@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=patches@apm.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox