From: Guenter Roeck <linux@roeck-us.net>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: George Cherian <george.cherian@ti.com>,
balbi@ti.com, myungjoo.ham@samsung.com, cw00.choi@samsung.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, grant.likely@linaro.org,
rob@landley.net, ian.campbell@citrix.com, mark.rutland@arm.com,
pawel.moll@arm.co
Subject: Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection
Date: Sat, 24 Aug 2013 22:30:11 -0700 [thread overview]
Message-ID: <52199663.8070201@roeck-us.net> (raw)
In-Reply-To: <52139F0F.6090507@wwwdotorg.org>
On 08/20/2013 09:53 AM, Stephen Warren wrote:
> On 08/20/2013 12:55 AM, George Cherian wrote:
>> Hi Stephen,
>>
>> Thanks for your review.
>>
>> On 8/20/2013 1:01 AM, Stephen Warren wrote:
>>
>>> On 08/16/2013 04:13 AM, George Cherian wrote:
>>>> Adding extcon driver for USB ID detection to dynamically
>>>> configure USB Host/Peripheral mode.
>>>> diff --git
>>>> a/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt
>>>> b/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt
>>>> +EXTCON FOR DRA7xx
>>>> +
>>>> +Required Properties:
>>> Please at lest explain what a DRA7xxx is, and the purpose of the HW
>>> module this binding describes.
>>
>> DRA7xx is the SoC name and the USB VID detection is implemented via gpio's
>> Basically it does only ID detection via GPIO and there is no VBUS
>> detection in h/w.
>
> If there's no SoC-specific HW, then the binding has nothing to do with
> the SoC; it's entirely generic.
>
I am currently working on adding device tree support to the extcon-gpio driver.
Wonder if it would make sense to just use that driver. As far as I can see
the only missing part is support for multiple cables and cable naming through
device tree properties.
Any thoughts ? The patches are not yet clean enough to submit upstream,
but I could send them as RFC if there is interest.
Guenter
next prev parent reply other threads:[~2013-08-25 5:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1376648029-30659-1-git-send-email-george.cherian@ti.com>
[not found] ` <1376648029-30659-2-git-send-email-george.cherian@ti.com>
2013-08-19 19:31 ` [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection Stephen Warren
2013-08-20 6:55 ` George Cherian
2013-08-20 16:53 ` Stephen Warren
2013-08-21 13:06 ` George Cherian
2013-08-21 17:35 ` Stephen Warren
2013-08-22 5:14 ` George Cherian
2013-08-25 5:30 ` Guenter Roeck [this message]
2013-08-30 0:20 ` Chanwoo Choi
2013-08-30 4:33 ` Guenter Roeck
2013-08-20 0:24 ` Chanwoo Choi
2013-08-20 9:36 ` George Cherian
2013-08-20 10:29 ` Chanwoo Choi
2013-08-20 13:24 ` George Cherian
2013-08-20 23:07 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52199663.8070201@roeck-us.net \
--to=linux@roeck-us.net \
--cc=balbi@ti.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=george.cherian@ti.com \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=pawel.moll@arm.co \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).