* Re: [PATCH v6 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module [not found] ` <1377286330-29663-3-git-send-email-zonque@gmail.com> @ 2013-08-26 9:04 ` Tony Lindgren 2013-08-26 18:49 ` Mugunthan V N 0 siblings, 1 reply; 2+ messages in thread From: Tony Lindgren @ 2013-08-26 9:04 UTC (permalink / raw) To: Daniel Mack Cc: netdev, bcousson, nsekhar, sergei.shtylyov, davem, ujhelyi.m, mugunthanvnm, vaibhav.bedia, d-gerlach, linux-arm-kernel, linux-omap, devicetree * Daniel Mack <zonque@gmail.com> [130823 12:39]: > At least the AM33xx SoC has a control module register to configure > details such as the hardware ethernet interface mode. > > I'm not sure whether all SoCs which feature the cpsw block have such a > register, so that third memory region is considered optional for now. Assuming you're talking about omap SCM registers here.. This should be in a separate driver module so the control module parts can eventually be children of the SCM driver as they are really separate devices on the bus. See how the USB PHY parts were done for example. What do these control module registers do? If it's just multiplexing and pinconf, then you can use pinctrl-single,bits most likely for it and access it using the named modes. However, if the register also contains comparators and control for regulators, you should only use pinctrl-single for the multiplexing and pinconf parts. Regards, Tony ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v6 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module 2013-08-26 9:04 ` [PATCH v6 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module Tony Lindgren @ 2013-08-26 18:49 ` Mugunthan V N 0 siblings, 0 replies; 2+ messages in thread From: Mugunthan V N @ 2013-08-26 18:49 UTC (permalink / raw) To: Tony Lindgren Cc: Daniel Mack, netdev, bcousson, nsekhar, sergei.shtylyov, davem, ujhelyi.m, vaibhav.bedia, d-gerlach, linux-arm-kernel, linux-omap, devicetree On Monday 26 August 2013 02:34 PM, Tony Lindgren wrote: > * Daniel Mack <zonque@gmail.com> [130823 12:39]: >> At least the AM33xx SoC has a control module register to configure >> details such as the hardware ethernet interface mode. >> >> I'm not sure whether all SoCs which feature the cpsw block have such a >> register, so that third memory region is considered optional for now. > Assuming you're talking about omap SCM registers here.. > > This should be in a separate driver module so the control module > parts can eventually be children of the SCM driver as they are > really separate devices on the bus. See how the USB PHY parts were done > for example. > > What do these control module registers do? If it's just multiplexing > and pinconf, then you can use pinctrl-single,bits most likely for it and > access it using the named modes. > > However, if the register also contains comparators and control for > regulators, you should only use pinctrl-single for the multiplexing > and pinconf parts. > I will take a look into usb control module driver and will try to adopt the driver here also. Regards Mugunthan V N ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-26 18:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1377286330-29663-1-git-send-email-zonque@gmail.com>
[not found] ` <1377286330-29663-3-git-send-email-zonque@gmail.com>
2013-08-26 9:04 ` [PATCH v6 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module Tony Lindgren
2013-08-26 18:49 ` Mugunthan V N
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).