From: Andreas Larsson <andreas@gaisler.com>
To: Lars Poeschel <poeschel@lemonage.de>
Cc: Lars Poeschel <larsi@wh2.tu-dresden.de>,
grant.likely@linaro.org, linus.walleij@linaro.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, mark.rutland@arm.com,
ian.campbell@citrix.com, galak@codeaurora.org,
pawel.moll@arm.com, tomasz.figa@gmail.com, swarren@wwwdotorg.org,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Enric Balletbo i Serra <eballetbo@gmail.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Kevin Hilman <khilman@linaro.org>, Balaji T K <balajitk@ti.com>,
Tony Lindgren <tony@atomide.com>,
Jon Hunter <jgchunter@gmail.com>
Subject: Re: [PATCH v2] gpio: interrupt consistency check for OF GPIO IRQs
Date: Tue, 27 Aug 2013 08:06:47 +0200 [thread overview]
Message-ID: <521C41F7.8060305@gaisler.com> (raw)
In-Reply-To: <201308261604.55827.poeschel@lemonage.de>
On 2013-08-26 16:04, Lars Poeschel wrote:
> On Monday 26 August 2013 at 13:29:07, Andreas Larsson wrote:
>> On 2013-08-26 12:56, Lars Poeschel wrote:
>>>> This call to of_irq_find_parent breaks gpiolib-of for SPARC due to
>>>> the fact that the function is undefined when !defined(CONFIG_OF_IRQ)
>>>> && defined(CONFIG_OF).
>>>>
>>>> Defining the empty of_irq_find_parent in include/linux/of_irq.h when
>>>> !defined(CONFIG_OF_IRQ) instead of the current case when
>>>> !defined(CONFIG_OF) would solve the immediate compilation problem.
>>>
>>> Is this a bug and should be fixed ?
>>
>> Well, at least as soon as anyone tries to use in a context that does not
>> exclude SPARC it creates a bug, so I would say so. There is no reason
>> for SPARC to fall between the chairs. This is the first case I am aware
>> of that triggers this.
>
> I also think this should be fixed.
> Are you able to do a patch that fixes this and submit to the relevant
> people?
Sure!
Cheers,
Andreas
prev parent reply other threads:[~2013-08-27 6:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 13:38 [PATCH v2] gpio: interrupt consistency check for OF GPIO IRQs Lars Poeschel
2013-08-21 21:49 ` Tomasz Figa
2013-08-21 23:10 ` Stephen Warren
2013-08-21 23:27 ` Linus Walleij
2013-08-22 20:53 ` Stephen Warren
2013-08-23 9:51 ` Lars Poeschel
2013-08-23 18:38 ` Linus Walleij
2013-08-23 19:49 ` Stephen Warren
2013-08-29 18:51 ` Linus Walleij
2013-08-21 23:36 ` Linus Walleij
2013-08-22 21:10 ` Stephen Warren
2013-08-23 9:40 ` Lars Poeschel
2013-08-23 19:48 ` Stephen Warren
2013-08-26 10:30 ` Lars Poeschel
2013-08-23 18:45 ` Linus Walleij
2013-08-23 19:52 ` Stephen Warren
2013-08-23 19:55 ` Tomasz Figa
2013-08-23 20:55 ` Stephen Warren
2013-08-26 10:45 ` Lars Poeschel
2013-08-27 20:05 ` Stephen Warren
2013-08-29 19:00 ` Linus Walleij
2013-08-30 20:08 ` Stephen Warren
2013-09-02 9:43 ` Lars Poeschel
2013-09-03 12:28 ` Linus Walleij
2013-08-22 9:01 ` Lars Poeschel
2013-08-22 21:08 ` Stephen Warren
2013-08-22 22:30 ` Tomasz Figa
2013-08-22 13:16 ` Andreas Larsson
2013-08-26 10:56 ` Lars Poeschel
2013-08-26 11:29 ` Andreas Larsson
2013-08-26 14:04 ` Lars Poeschel
2013-08-27 6:06 ` Andreas Larsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521C41F7.8060305@gaisler.com \
--to=andreas@gaisler.com \
--cc=balajitk@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=eballetbo@gmail.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=javier.martinez@collabora.co.uk \
--cc=jgchunter@gmail.com \
--cc=khilman@linaro.org \
--cc=larsi@wh2.tu-dresden.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=poeschel@lemonage.de \
--cc=santosh.shilimkar@ti.com \
--cc=swarren@wwwdotorg.org \
--cc=tomasz.figa@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).