From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH v2] gpio: Enable pcf857x GPIO expander for Device Tree Date: Tue, 27 Aug 2013 12:30:18 +0530 Message-ID: <521C4E82.9040309@ti.com> References: <1370527523-1030-1-git-send-email-archit@ti.com> <1377498081-16358-1-git-send-email-archit@ti.com> <7142087.DRSP8TfuKN@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <7142087.DRSP8TfuKN@avalon> Sender: linux-doc-owner@vger.kernel.org To: Laurent Pinchart Cc: Linus Walleij , "linux-doc@vger.kernel.org" , Linux-OMAP , Grant Likely , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org On Tuesday 27 August 2013 12:17 PM, Laurent Pinchart wrote: > On Tuesday 27 August 2013 05:20:45 Linus Walleij wrote: >> On Mon, Aug 26, 2013 at 8:21 AM, Archit Taneja wrote: >>> Add code to parse the GPIO expander Device Tree node and extract platform >>> data out of it, and populate the struct 'pcf857x_platform_data' >>> maintained by the driver. This enables devices to reference the gpio >>> expander from Device Tree. >>> >>> Add DT binding info in Documentation. >>> >>> Signed-off-by: Archit Taneja >>> --- >>> - v2 posted after quite a while, sorry for the delay! >>> >>> Changes in v2: >>> - second gpeio-cell description corrected in Documentation >>> - interrupt controller description removed for now, will be added in a >>> follow up patch >>> - n_latch description updated > > And it seems that the patch conflicts with > > https://lkml.org/lkml/2013/8/26/248 > > :-/ :/ > > If we end up merging this one, I'd like to at least rename the DT n-latch > property to pin-initial-states as in my patch and update the documentation, as > I find it more explicit. I think your patch is cleaner and more descriptive. The only thing which I am not clear about in your patch is the extra work done in getting ngpio, that should be available in i2c_device_id pointer argument in probe(id points to the array pcf857x_id already available in the driver with the number of gpios for each chip variant). Archit