* [PATCH] of: Fix missing memory initialization on FDT unflattening
@ 2013-08-29 11:41 Grant Likely
2013-08-29 16:47 ` Wladislav Wiebe
0 siblings, 1 reply; 2+ messages in thread
From: Grant Likely @ 2013-08-29 11:41 UTC (permalink / raw)
To: devicetree, linux-kernel; +Cc: Grant Likely, stable, Wladislav Wiebe
Any calls to dt_alloc() need to be zeroed. This is a temporary fix, but
the allocation function itself needs to zero memory before returning
it. This is a follow up to patch 9e4012752, "of: fdt: fix memory
initialization for expanded DT" which fixed one call site but missed
another.
Signed-off-by: Grant Likely <grant.likely@linaro.org>
Cc: stable@vger.kernel.org
Cc: Wladislav Wiebe <wladislav.kw@gmail.com>
---
drivers/of/base.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 5c54279..bf8432f 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1629,6 +1629,7 @@ void of_alias_scan(void * (*dt_alloc)(u64 size, u64 align))
ap = dt_alloc(sizeof(*ap) + len + 1, 4);
if (!ap)
continue;
+ memset(ap, 0, sizeof(*ap) + len + 1);
ap->alias = start;
of_alias_add(ap, np, id, start, len);
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] of: Fix missing memory initialization on FDT unflattening
2013-08-29 11:41 [PATCH] of: Fix missing memory initialization on FDT unflattening Grant Likely
@ 2013-08-29 16:47 ` Wladislav Wiebe
0 siblings, 0 replies; 2+ messages in thread
From: Wladislav Wiebe @ 2013-08-29 16:47 UTC (permalink / raw)
To: Grant Likely; +Cc: devicetree, linux-kernel, stable
On 29/08/13 13:41, Grant Likely wrote:
> Any calls to dt_alloc() need to be zeroed. This is a temporary fix, but
> the allocation function itself needs to zero memory before returning
> it. This is a follow up to patch 9e4012752, "of: fdt: fix memory
> initialization for expanded DT" which fixed one call site but missed
> another.
Acked-by: Wladislav Wiebe <wladislav.kw@gmail.com>
>
> Signed-off-by: Grant Likely <grant.likely@linaro.org>
> Cc: stable@vger.kernel.org
> Cc: Wladislav Wiebe <wladislav.kw@gmail.com>
> ---
> drivers/of/base.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index 5c54279..bf8432f 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -1629,6 +1629,7 @@ void of_alias_scan(void * (*dt_alloc)(u64 size, u64 align))
> ap = dt_alloc(sizeof(*ap) + len + 1, 4);
> if (!ap)
> continue;
> + memset(ap, 0, sizeof(*ap) + len + 1);
> ap->alias = start;
> of_alias_add(ap, np, id, start, len);
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-29 16:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-29 11:41 [PATCH] of: Fix missing memory initialization on FDT unflattening Grant Likely
2013-08-29 16:47 ` Wladislav Wiebe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).