From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wladislav Wiebe Subject: Re: [PATCH] of: Fix missing memory initialization on FDT unflattening Date: Thu, 29 Aug 2013 18:47:38 +0200 Message-ID: <521F7B2A.5030106@gmail.com> References: <1377776494-27040-1-git-send-email-grant.likely@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1377776494-27040-1-git-send-email-grant.likely@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Grant Likely Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org List-Id: devicetree@vger.kernel.org On 29/08/13 13:41, Grant Likely wrote: > Any calls to dt_alloc() need to be zeroed. This is a temporary fix, but > the allocation function itself needs to zero memory before returning > it. This is a follow up to patch 9e4012752, "of: fdt: fix memory > initialization for expanded DT" which fixed one call site but missed > another. Acked-by: Wladislav Wiebe > > Signed-off-by: Grant Likely > Cc: stable@vger.kernel.org > Cc: Wladislav Wiebe > --- > drivers/of/base.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index 5c54279..bf8432f 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -1629,6 +1629,7 @@ void of_alias_scan(void * (*dt_alloc)(u64 size, u64 align)) > ap = dt_alloc(sizeof(*ap) + len + 1, 4); > if (!ap) > continue; > + memset(ap, 0, sizeof(*ap) + len + 1); > ap->alias = start; > of_alias_add(ap, np, id, start, len); > } >