devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: George Cherian <george.cherian@ti.com>
Cc: balbi@ti.com, myungjoo.ham@samsung.com, cw00.choi@samsung.com,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, grant.likely@linaro.org,
	rob@landley.net, ian.campbell@citrix.com, mark.rutland@arm.com,
	pawel.moll@arm.com, rob.herring@calxeda.com,
	linux-omap@vger.kernel.org, linux-usb@vger.kernel.org,
	bcousson@baylibre.com, davidb@codeaurora.org, arnd@arndb.de,
	swarren@nvidia.com, popcornmix@gmail.com
Subject: Re: [PATCH v3 3/3] ARM: dts: dra7-evm: Add extcon nodes for USB ID pin detection
Date: Thu, 29 Aug 2013 13:21:19 -0600	[thread overview]
Message-ID: <521F9F2F.1060307@wwwdotorg.org> (raw)
In-Reply-To: <1377711185-31238-4-git-send-email-george.cherian@ti.com>

On 08/28/2013 11:33 AM, George Cherian wrote:
> Add
> 	-extcon nodes for USB ID pin detection.
> 	-i2c nodes.
> 	-pcf nodes to which USB ID pin is connected.

> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts

>  &dwc3_1 {
> -	dr_mode = "otg";
> +	dr_mode = "host";
>  };

I wonder why one cares about ID/VBUS detection if the port doesn't
operate in OTG mode?

>  &dwc3_2 {
>  	dr_mode = "host";
>  };
> +
> +&usb1 {
> +	extcon = <&extcon1>;
> +};
> +
> +&usb2 {
> +	extcon = <&extcon2>;
> +};

I assume the "extcon" property is already fully documented in the
binding for the USB controller? For some reason, "extcon" looks like an
odd property name; I would have expected something more HW-oriented that
Linux-subsystem-oriented, such as "connector", or "usb-connector".


      parent reply	other threads:[~2013-08-29 19:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-28 17:33 [PATCH v3 0/3] Add Generic USB VBUS/ID detection via GPIO using extcon George Cherian
2013-08-28 17:33 ` [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO George Cherian
2013-08-29  1:35   ` Chanwoo Choi
2013-08-29  2:21     ` George Cherian
2013-08-29  6:23       ` Chanwoo Choi
2013-08-29  7:30         ` George Cherian
2013-08-29 10:37           ` Chanwoo Choi
2013-08-29 11:48             ` George Cherian
2013-08-29 12:12               ` Chanwoo Choi
2013-08-29 13:45                 ` George Cherian
2013-08-30  0:11                   ` Chanwoo Choi
2013-08-30  6:15                     ` George Cherian
2013-08-30  6:53                       ` Chanwoo Choi
2013-09-02  1:58                         ` George Cherian
2013-08-30  7:14                       ` Chanwoo Choi
2013-09-02  2:01                         ` George Cherian
2013-08-29 19:11               ` Stephen Warren
2013-08-29 19:19   ` Stephen Warren
     [not found] ` <1377711185-31238-1-git-send-email-george.cherian-l0cyMroinI0@public.gmane.org>
2013-08-28 17:33   ` [PATCH v3 2/3] drivers: Makefile: Extcon is a framework so bump it up George Cherian
2013-08-28 17:33 ` [PATCH v3 3/3] ARM: dts: dra7-evm: Add extcon nodes for USB ID pin detection George Cherian
2013-08-28 17:54   ` Sergei Shtylyov
2013-08-29  2:53     ` George Cherian
2013-08-29 19:21   ` Stephen Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521F9F2F.1060307@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=arnd@arndb.de \
    --cc=balbi@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=cw00.choi@samsung.com \
    --cc=davidb@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=george.cherian@ti.com \
    --cc=grant.likely@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=pawel.moll@arm.com \
    --cc=popcornmix@gmail.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).