From: Lars-Peter Clausen <lars@metafoo.de>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Liam Girdwood <lgirdwood@gmail.com>,
Grant Likely <grant.likely@secretlab.ca>,
Mark Brown <broonie@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Shawn Guo <shawn.guo@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] ASoC: generic simple sound card DT bindings
Date: Sat, 31 Aug 2013 17:10:30 +0200 [thread overview]
Message-ID: <52220766.1040504@metafoo.de> (raw)
In-Reply-To: <1377945878-13322-3-git-send-email-mpa@pengutronix.de>
On 08/31/2013 12:44 PM, Markus Pargmann wrote:
> Simple sound card initialized using DT. When used with AC97, ac97-codec
> is used to automatically discover the used codec.
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
> .../bindings/sound/generic,simple-dt-card.txt | 28 +++
> sound/soc/generic/Kconfig | 1 +
> sound/soc/generic/simple-card.c | 195 +++++++++++++++++++--
> 3 files changed, 206 insertions(+), 18 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sound/generic,simple-dt-card.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/generic,simple-dt-card.txt b/Documentation/devicetree/bindings/sound/generic,simple-dt-card.txt
> new file mode 100644
> index 0000000..6b41dbe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/generic,simple-dt-card.txt
> @@ -0,0 +1,28 @@
> +ASoC Simple Sound Card
> +
> +A simple generic driver that connects a CPU DAI with a CODEC.
> +
> +Required properties:
> + - compatible: "asoc-simple-card" used for standard ssi, codec
> + combinations, or "asoc-simple-ac97-card" to use ac97 to discover the
> + codec.
> + - cpu-dai: CPU DAI connected to the codec.
> +
> +Required properties for "asoc-simple-card":
> + - audio-codec: Codec phandle.
> + - codec-dai-name: DAI name within the codec.
In my opinion this binding exposes way to much of the ASoC internal data
structures. E.g. CODECs are referenced by phandle, but the DAI of the CODEC
is reference by a string. This string is completely ASoC internal. The
binding also assumes that a CPU controller may have one DAI at most. In my
opinion this binding ought to use the upcoming of_xlate stuff for ASoC
components.
- Lars
next prev parent reply other threads:[~2013-08-31 15:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-31 10:44 [PATCH 0/3] ASoC: generic simple sound card DT bindings Markus Pargmann
2013-08-31 10:44 ` [PATCH 1/3] ASoC: generic: simple card, use private data Markus Pargmann
2013-08-31 10:44 ` [PATCH 2/3] ASoC: generic simple sound card DT bindings Markus Pargmann
2013-08-31 15:10 ` Lars-Peter Clausen [this message]
2013-09-02 8:13 ` Markus Pargmann
2013-09-03 19:25 ` Stephen Warren
2013-09-03 23:19 ` Mark Brown
2013-09-04 18:21 ` Stephen Warren
2013-08-31 10:44 ` [PATCH 3/3] ASoC: fsl: Kconfig, visible config items for simple card Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52220766.1040504@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mpa@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).