[PATCH 1/1] arm: dts: am33xx: correcting dt node unit address for usb

devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 1/1] arm: dts: am33xx: correcting dt node unit address for usb
@ 2013-08-30 17:52 Mugunthan V N
  2013-08-30 19:10 ` Kumar Gala
  2013-08-31 17:42 ` Sergei Shtylyov
  0 siblings, 2 replies; 5+ messages in thread
From: Mugunthan V N @ 2013-08-30 17:52 UTC (permalink / raw)
  To: balbi; +Cc: bigeasy, bcousson, linux-omap, devicetree, linux-usb,
	Mugunthan V N

DT node's unit address should be its own register offset address to make it a
unique across the system. This patch corrects the incorrect USB entries with
correct register offset for unit address.

Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Felipe Balbi <balbi@ti.com>
Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
---
 arch/arm/boot/dts/am33xx.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index f9c5da9..e9b6775 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -346,7 +346,7 @@
 			ti,hwmods = "usb_otg_hs";
 			status = "disabled";
 
-			ctrl_mod: control@44e10000 {
+			ctrl_mod: control@44e10620 {
 				compatible = "ti,am335x-usb-ctrl-module";
 				reg = <0x44e10620 0x10
 					0x44e10648 0x4>;
@@ -449,7 +449,7 @@
 					"tx14", "tx15";
 			};
 
-			cppi41dma: dma-controller@07402000 {
+			cppi41dma: dma-controller@47402000 {
 				compatible = "ti,am3359-cppi41";
 				reg =  <0x47400000 0x1000
 					0x47402000 0x1000
-- 
1.8.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] arm: dts: am33xx: correcting dt node unit address for usb
  2013-08-30 17:52 [PATCH 1/1] arm: dts: am33xx: correcting dt node unit address for usb Mugunthan V N
@ 2013-08-30 19:10 ` Kumar Gala
       [not found]   ` <50F5779C-87B6-43C2-81A8-C72A0614464F-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
  2013-08-31 17:42 ` Sergei Shtylyov
  1 sibling, 1 reply; 5+ messages in thread
From: Kumar Gala @ 2013-08-30 19:10 UTC (permalink / raw)
  To: Mugunthan V N; +Cc: balbi, bigeasy, bcousson, linux-omap, devicetree, linux-usb


On Aug 30, 2013, at 12:52 PM, Mugunthan V N wrote:

> DT node's unit address should be its own register offset address to make it a
> unique across the system. This patch corrects the incorrect USB entries with
> correct register offset for unit address.
> 
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Cc: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> ---
> arch/arm/boot/dts/am33xx.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index f9c5da9..e9b6775 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -346,7 +346,7 @@
> 			ti,hwmods = "usb_otg_hs";
> 			status = "disabled";
> 
> -			ctrl_mod: control@44e10000 {
> +			ctrl_mod: control@44e10620 {
> 				compatible = "ti,am335x-usb-ctrl-module";
> 				reg = <0x44e10620 0x10
> 					0x44e10648 0x4>;
> @@ -449,7 +449,7 @@
> 					"tx14", "tx15";
> 			};
> 
> -			cppi41dma: dma-controller@07402000 {
> +			cppi41dma: dma-controller@47402000 {

Why isn't the unit address 47400000 ?

> 				compatible = "ti,am3359-cppi41";
> 				reg =  <0x47400000 0x1000
> 					0x47402000 0x1000
> -- 
> 1.8.4

- k

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation


^ permalink raw reply	[flat|nested] 5+ messages in thread

[parent not found: <50F5779C-87B6-43C2-81A8-C72A0614464F-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>]

* Re: [PATCH 1/1] arm: dts: am33xx: correcting dt node unit address for usb
       [not found]   ` <50F5779C-87B6-43C2-81A8-C72A0614464F-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
@ 2013-08-31  7:39     ` Mugunthan V N
  0 siblings, 0 replies; 5+ messages in thread
From: Mugunthan V N @ 2013-08-31  7:39 UTC (permalink / raw)
  To: Kumar Gala
  Cc: balbi-l0cyMroinI0, bigeasy-hfZtesqFncYOwBW4kG4KsQ,
	bcousson-rdvid1DuHRBWk0Htik3J/w,
	linux-omap-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA

On Saturday 31 August 2013 12:40 AM, Kumar Gala wrote:
> On Aug 30, 2013, at 12:52 PM, Mugunthan V N wrote:
>
>> > DT node's unit address should be its own register offset address to make it a
>> > unique across the system. This patch corrects the incorrect USB entries with
>> > correct register offset for unit address.
>> > 
>> > Cc: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
>> > Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
>> > Signed-off-by: Mugunthan V N <mugunthanvnm-l0cyMroinI0@public.gmane.org>
>> > ---
>> > arch/arm/boot/dts/am33xx.dtsi | 4 ++--
>> > 1 file changed, 2 insertions(+), 2 deletions(-)
>> > 
>> > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>> > index f9c5da9..e9b6775 100644
>> > --- a/arch/arm/boot/dts/am33xx.dtsi
>> > +++ b/arch/arm/boot/dts/am33xx.dtsi
>> > @@ -346,7 +346,7 @@
>> > 			ti,hwmods = "usb_otg_hs";
>> > 			status = "disabled";
>> > 
>> > -			ctrl_mod: control@44e10000 {
>> > +			ctrl_mod: control@44e10620 {
>> > 				compatible = "ti,am335x-usb-ctrl-module";
>> > 				reg = <0x44e10620 0x10
>> > 					0x44e10648 0x4>;
>> > @@ -449,7 +449,7 @@
>> > 					"tx14", "tx15";
>> > 			};
>> > 
>> > -			cppi41dma: dma-controller@07402000 {
>> > +			cppi41dma: dma-controller@47402000 {
> Why isn't the unit address 47400000 ?
>
The above address is a shared address between CPPI dma and USB sub
system. It has to be shared because CPPI DMA has to access Glue layer of
the USB sub system for accessing IRQ registers.

So 47400000 is already used in USB SS so if it cannot be used for CPPI
DT node.

Regards
Mugunthan V N
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] arm: dts: am33xx: correcting dt node unit address for usb
  2013-08-30 17:52 [PATCH 1/1] arm: dts: am33xx: correcting dt node unit address for usb Mugunthan V N
  2013-08-30 19:10 ` Kumar Gala
@ 2013-08-31 17:42 ` Sergei Shtylyov
  2013-08-31 18:29   ` Mugunthan V N
  1 sibling, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2013-08-31 17:42 UTC (permalink / raw)
  To: Mugunthan V N; +Cc: balbi, bigeasy, bcousson, linux-omap, devicetree, linux-usb

Hello.

On 08/30/2013 09:52 PM, Mugunthan V N wrote:

> DT node's unit address should be its own register offset address to make it a
> unique across the system. This patch corrects the incorrect USB entries with
> correct register offset for unit address.

> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Cc: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> ---
>   arch/arm/boot/dts/am33xx.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index f9c5da9..e9b6775 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
[...]
> @@ -449,7 +449,7 @@
>   					"tx14", "tx15";
>   			};
>
> -			cppi41dma: dma-controller@07402000 {
> +			cppi41dma: dma-controller@47402000 {

    Not @47400000? Look at the first entry in the "reg" prop.

>   				compatible = "ti,am3359-cppi41";
>   				reg =  <0x47400000 0x1000
>   					0x47402000 0x1000

WBR, Sergei


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] arm: dts: am33xx: correcting dt node unit address for usb
  2013-08-31 17:42 ` Sergei Shtylyov
@ 2013-08-31 18:29   ` Mugunthan V N
  0 siblings, 0 replies; 5+ messages in thread
From: Mugunthan V N @ 2013-08-31 18:29 UTC (permalink / raw)
  To: Sergei Shtylyov
  Cc: balbi, bigeasy, bcousson, linux-omap, devicetree, linux-usb

On Saturday 31 August 2013 11:12 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 08/30/2013 09:52 PM, Mugunthan V N wrote:
>
>> DT node's unit address should be its own register offset address to
>> make it a
>> unique across the system. This patch corrects the incorrect USB
>> entries with
>> correct register offset for unit address.
>
>> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>> Cc: Felipe Balbi <balbi@ti.com>
>> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
>> ---
>>   arch/arm/boot/dts/am33xx.dtsi | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>
>> diff --git a/arch/arm/boot/dts/am33xx.dtsi
>> b/arch/arm/boot/dts/am33xx.dtsi
>> index f9c5da9..e9b6775 100644
>> --- a/arch/arm/boot/dts/am33xx.dtsi
>> +++ b/arch/arm/boot/dts/am33xx.dtsi
> [...]
>> @@ -449,7 +449,7 @@
>>                       "tx14", "tx15";
>>               };
>>
>> -            cppi41dma: dma-controller@07402000 {
>> +            cppi41dma: dma-controller@47402000 {
>
>    Not @47400000? Look at the first entry in the "reg" prop. 
47400000 is already used in USB SS. See below from am33xx.dtsi file

340                 usb: usb@47400000
{                                             
341                         compatible =
"ti,am33xx-usb";                           
342                         reg = <0x47400000
0x1000>;                              
343                         ranges;

Regards
Mugunthan V N

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-08-31 18:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-30 17:52 [PATCH 1/1] arm: dts: am33xx: correcting dt node unit address for usb Mugunthan V N
2013-08-30 19:10 ` Kumar Gala
     [not found]   ` <50F5779C-87B6-43C2-81A8-C72A0614464F-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2013-08-31  7:39     ` Mugunthan V N
2013-08-31 17:42 ` Sergei Shtylyov
2013-08-31 18:29   ` Mugunthan V N

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).