Re: [PATCH] ARM: dts: BCM5301X: Add DT for Buffalo WZR-1166DHP2

[SHIMAMOTO Takayoshi <takayoshi.shimamoto.360@gmail.com>]

Thank you for the replies.

On 2022/04/13 2:49, Rafał Miłecki wrote:
>>   - 4x 10/100M ethernet switch
> 
> Isn't that 10/100/1000?

You are right.
It supports 10/100/1000Mbps.

>> +    model = "Buffalo WZR-1166DHP2 (BCM4708)";
> 
> We stopped adding SoC name to the "model" value, please drop it.

Understood.

I will fix it as follows
model = "Buffalo WZR-1166DHP2";

>> +
>> +        wireless1 {
>> +            label = "bcm53xx:amber:wireless";
>> +            gpios = <&hc595 7 GPIO_ACTIVE_HIGH>;
>> +        };
>> +    };
> 
> I'm wondering if all new DTS files should use "function" and "color"
> instead of "label". That's preferred solution and I guess it's good idea
> to use it for new code.

Understood.

I will rewrite it with "function" and "color."

I will post the patch again after testing.

Best regards