From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 1/4] ARM: shmobile: r8a7778: add Ether DT support Date: Mon, 02 Sep 2013 18:05:10 +0400 Message-ID: <52249B16.8010409@cogentembedded.com> References: <201309010311.05466.sergei.shtylyov@cogentembedded.com> <201309010315.49763.sergei.shtylyov@cogentembedded.com> <1643070.uIkONXsrBj@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1643070.uIkONXsrBj@avalon> Sender: linux-sh-owner@vger.kernel.org To: Laurent Pinchart Cc: horms@verge.net.au, linux-sh@vger.kernel.org, rob.herring@calxeda.com, pawel.moll@arm.com, mark.rutland@arm.com, swarren@wwwdotorg.org, ian.campbell@citrix.com, devicetree@vger.kernel.org, magnus.damm@gmail.com, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 09/02/2013 05:14 PM, Laurent Pinchart wrote: >> Define the generic R8A777x part of the Ether device node. >> Signed-off-by: Sergei Shtylyov >> --- >> arch/arm/boot/dts/r8a7778.dtsi | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> Index: renesas/arch/arm/boot/dts/r8a7778.dtsi >> =================================================================== >> --- renesas.orig/arch/arm/boot/dts/r8a7778.dtsi >> +++ renesas/arch/arm/boot/dts/r8a7778.dtsi >> @@ -98,4 +98,15 @@ >> reg = <0xfffc000 0x118>; >> #gpio-range-cells = <3>; >> }; >> + >> + ether: ethernet@fde00000 { >> + device_type = "network"; > Documentation/devicetree/bindings/net/sh_eth.txt from "[PATCH 2/2] sh_eth: add > device tree support" doesn't document this property, should you update it ? It's a standard property but completely optional for non-OF systems. I've not seen anybody document it but I should grep for it... WBR, Sergei