From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v3] gpio: interrupt consistency check for OF GPIO IRQs Date: Tue, 03 Sep 2013 11:29:00 -0600 Message-ID: <52261C5C.9000102@wwwdotorg.org> References: <1377526030-32024-1-git-send-email-larsi@wh2.tu-dresden.de> <5220F849.8030909@wwwdotorg.org> <4094364.ACYUvMRRNa@lem-wkst-02> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4094364.ACYUvMRRNa@lem-wkst-02> Sender: linux-gpio-owner@vger.kernel.org To: Lars Poeschel Cc: Linus Walleij , Lars Poeschel , Grant Likely , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Mark Rutland , Ian Campbell , Kumar Gala , Pawel Moll , Tomasz Figa , Javier Martinez Canillas , Enric Balletbo i Serra , Jean-Christophe PLAGNIOL-VILLARD , Santosh Shilimkar , Kevin Hilman , Balaji T K , Tony Lindgren , Jon Hunter List-Id: devicetree@vger.kernel.org On 09/02/2013 03:38 AM, Lars Poeschel wrote: > Am Freitag, 30. August 2013, 13:53:45 schrieb Stephen Warren: ... >> Yet the current patch only addresses a limited set of cases, since it >> doesn't hook the APIs but rather parses the DT. It doesn't cover the >> non-DT case. It should if the feature is useful. > > As pointed out before, only DT has this problem, that, That's completely false. Both DT and non-DT can represent the exact same HW, and use the exact same drivers. It's equally possible to write a bug in a board file or a DT file (i.e. a typo or incorrect reading of the schematic) that causes the wrong GPIO or IRQ ID to be used, and hence for there to be conflicts. Any solution to this issue needs to address both cases.