From: George Cherian <george.cherian@ti.com>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux@arm.linux.org.uk, pawel.moll@arm.com,
swarren@wwwdotorg.org, tony@atomide.com,
ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org,
rob.herring@calxeda.com, bcousson@baylibre.com, olof@lixom.net,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP2+: am335x-bone*: add DT for BeagleBone Black
Date: Fri, 6 Sep 2013 13:19:26 +0530 [thread overview]
Message-ID: <52298906.6040800@ti.com> (raw)
In-Reply-To: <50E637BB-5A62-477C-B943-9687BC3488BC@dominion.thruhere.net>
On 9/6/2013 12:40 PM, Koen Kooi wrote:
> Op 6 sep. 2013, om 08:57 heeft George Cherian <george.cherian@ti.com> het volgende geschreven:
>
>> On 9/6/2013 12:03 PM, Koen Kooi wrote:
>>> The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added,
>>> so create a common dtsi both can use. MMC support for AM335x still isn't in, so
>>> only the LDO change has been added.
>>>
>>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
>>> ---
>>> .../{am335x-bone.dts => am335x-bone-common.dtsi} | 3 -
>>> arch/arm/boot/dts/am335x-bone.dts | 256 +--------------------
>>> arch/arm/boot/dts/am335x-boneblack.dts | 18 ++
>>> 3 files changed, 19 insertions(+), 258 deletions(-)
>>> copy arch/arm/boot/dts/{am335x-bone.dts => am335x-bone-common.dtsi} (99%)
>>> create mode 100644 arch/arm/boot/dts/am335x-boneblack.dts
>> How did you test am335x-boneblack.dtb? where are the Makefile changes for boneblack?
> Ah, I missed the makefile in my commit. I have a bunch of other patches on top to make more stuff work.
>
> [..]
>
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/am335x-boneblack.dts
>>> @@ -0,0 +1,18 @@
>>> +/*
>>> + * Copyright (C) 2012 Texas Instruments Incorporated - http://www.ti.com/
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License version 2 as
>>> + * published by the Free Software Foundation.
>>> + */
>>> +/dts-v1/;
>>> +
>>> +#include "am33xx.dtsi"
>> Why cant we add am33xx.dtsi in am335x-bone-common.dtsi ?
> That didn't work when I tried it. It did work before the preprocessor changes when using /include/
It will work......
>
>>> +#include "am335x-bone-common.dtsi"
>>> +
>>> +&ldo3_reg {
>>> + regulator-min-microvolt = <1800000>;
>>> + regulator-max-microvolt = <1800000>;
>>> + regulator-always-on;
>>> +};
>>> +
>> With this ldo values mmc was not working for me on Boneblack.
>> got it working with
>>
>> &ldo3_reg {
>> regulator-min-microvolt = <1800000>;
>> regulator-max-microvolt = <3300000>;
>> regulator-always-on;
>> };
> That LDO is shared, the other consumer will get fried if you use 3.3V. I forget if it's DDR3 or HDMI.
--
-George
next prev parent reply other threads:[~2013-09-06 7:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 6:33 [PATCH] ARM: OMAP2+: am335x-bone*: add DT for BeagleBone Black Koen Kooi
2013-09-06 6:57 ` George Cherian
2013-09-06 7:10 ` Koen Kooi
2013-09-06 7:49 ` George Cherian [this message]
2013-09-06 8:51 ` Koen Kooi
2013-09-06 12:51 ` Koen Kooi
2013-09-09 14:50 ` Kevin Hilman
2013-09-09 14:54 ` Kevin Hilman
-- strict thread matches above, loose matches on Subject: below --
2013-09-09 14:29 Koen Kooi
2013-09-09 15:23 ` Kevin Hilman
2013-09-09 15:51 ` Koen Kooi
2013-09-09 18:27 ` Joel Fernandes
2013-09-09 18:43 ` Koen Kooi
2013-09-09 18:51 ` Joel Fernandes
2013-09-09 19:50 ` Joel Fernandes
2013-09-09 20:00 ` Koen Kooi
2013-09-09 20:12 ` Joel Fernandes
2013-09-09 23:42 ` Joel Fernandes
2013-09-10 5:45 ` Koen Kooi
2013-09-10 5:53 ` Fernandes, Joel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52298906.6040800@ti.com \
--to=george.cherian@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=koen@dominion.thruhere.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).