From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH V3] pci: exynos: split into two parts such as Synopsys part and Exynos part Date: Thu, 12 Sep 2013 12:04:36 +0530 Message-ID: <5231607C.10702@ti.com> References: <002801ce8376$a807dbf0$f81793d0$@samsung.com> <51ED49D6.9050209@ti.com> <000701ce8741$fe47deb0$fad79c10$@samsung.com> <51EE22DF.6090902@ti.com> <001301ce8772$522dfc50$f689f4f0$@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <001301ce8772$522dfc50$f689f4f0$@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Jingoo Han Cc: 'Pratyush Anand' , 'Bjorn Helgaas' , linux-pci@vger.kernel.org, linux-samsung-soc@vger.kernel.org, 'Kukjin Kim' , 'Mohit KUMAR' , 'Arnd Bergmann' , 'Sean Cross' , 'Thierry Reding' , 'SRIKANTH TUMKUR SHIVANAND' , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Jingoo, On Tuesday 23 July 2013 12:30 PM, Jingoo Han wrote: > On Tuesday, July 23, 2013 3:30 PM, Kishon Vijay Abraham I wrote: >> On Tuesday 23 July 2013 06:44 AM, Jingoo Han wrote: >>> On Tuesday, July 23, 2013 12:04 AM, Kishon Vijay Abraham I wrote: >>>> On Thursday 18 July 2013 10:51 AM, Jingoo Han wrote: >>>>> Exynos PCIe IP consists of Synopsys specific part and Exynos >>>>> specific part. Only core block is a Synopsys designware part; >>>>> other parts are Exynos specific. >>>>> Also, the Synopsys designware part can be shared with other >>>>> platforms; thus, it can be split two parts such as Synopsys >>>>> designware part and Exynos specific part. >>>> >>>> some more queries and comments.. >>> >> . >> . >> >> . >> . >>>>> + of_pci_range_to_resource(&range, np, &pp->cfg); >>>>> + pp->config.cfg0_size = resource_size(&pp->cfg)/2; >>>>> + pp->config.cfg1_size = resource_size(&pp->cfg)/2; >>>>> + } >>>>> + } >>>>> + >>>>> + pp->dbi_base = devm_ioremap(pp->dev, pp->cfg.start, >>>>> + resource_size(&pp->cfg)); >>>> >>>> Why is configuraion space divided into two? >>> >>> Sorry, I don't know the exact reason. :( >>> Pratyush Anand may know about this. >>> Pratyush Anand, could you answer the question? >>> >>> Also, if you find some problems, please let me know. One more query.. Where is inbound translation configuration done in your driver? how should it be done? Thanks Kishon