From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH v7 01/13] [media] exynos5-is: Adding media device driver for exynos5 Date: Tue, 17 Sep 2013 22:50:24 +0200 Message-ID: <5238C090.6090201@gmail.com> References: <1377066881-5423-1-git-send-email-arun.kk@samsung.com> <1377066881-5423-2-git-send-email-arun.kk@samsung.com> <52377DE5.3070808@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Arun Kumar K Cc: Sylwester Nawrocki , LMML , linux-samsung-soc , devicetree@vger.kernel.org, Sylwester Nawrocki , Hans Verkuil , Stephen Warren , Mark Rutland , Pawel Moll , Kumar Gala , Andrzej Hajda , Sachin Kamat , Shaik Ameer Basha , kilyeon.im@samsung.com List-Id: devicetree@vger.kernel.org Hi Arun, On 09/17/2013 01:29 PM, Arun Kumar K wrote: > Wont this make fimc-is to be enabled to use fimc-lite? Hmm, it would be runtime PM active, yes. But it doesn't mean the Cortex-A5's firmware would need to be running. > As such there is no dependency like that in hardware and we can > use fimc-lite alone in DMA out mode without fimc-is. If you are sure about it, then fimc-lite nodes could stay at root level. Still, it would be more appropriate IMO to have the FIMC-IS sub-/peripheral devices, like I2C or SPI bus controllers, instantiated by the FIMC-IS driver. And what about "glue logic" linking FIMC-LITEs with the rest of the imaging subsystem ? Are you sure the is no some weird inter-dependencies ? Note that there is no board files any more, where we could hack some details. > If its modified as per your suggestion, how will the scenario of > sensor -> mipi-csis -> fimc-lite -> memory look like without fimc-is? The exynos5-fimc-is module would need to be loaded for that. If you're sure the hardware can work independently, we could leave out the fimc-lite nodes at root level. Regards, Sylwester