From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [dtc RFC PATCH] Enforce node name unit-address presence/absence Date: Wed, 18 Sep 2013 17:02:20 -0600 Message-ID: <523A30FC.3060309@wwwdotorg.org> References: <1379535836-12726-1-git-send-email-swarren@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Olof Johansson Cc: Jon Loeliger , David Gibson , Frank Rowand , Tomasz Figa , Benjamin Herrenschmidt , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Marek Szyprowski , Rob Herring , Grant Likely , Stephen Warren List-Id: devicetree@vger.kernel.org On 09/18/2013 02:41 PM, Olof Johansson wrote: > On Wed, Sep 18, 2013 at 1:23 PM, Stephen Warren wrote: >> From: Stephen Warren >> >> ePAPR 1.1 section 2.2.1.1 "Node Name Requirements" specifies that any >> node that has a reg property must include a unit address in its name >> with value matching the first entry in its reg property. Conversely, if >> a node does not have a reg property, the node name must not include a >> unit address. >> >> Implement a check for this. The code doesn't validate the format of the >> unit address; ePAPR implies this may vary from binding to binding, so >> I'm not sure that it's possible to validate the value itself. ... > Anyway, I think it'd be better to produce warnings than errors for > this. That way we could also merge it now while the trees are fixed > up. Yes, that makes sense. > Also, maybe warn for @0x, which is another unpreferred syntax, it > should just be @ (with foo being in hex). ePAPR doesn't seem to disallow that; it explicitly says that the unit-address consists of the characters from table 2-1, which is the same table of characters used for the node name itself. However, it does state that the binding for a particular bus may impose additional restrictions; should I implement such a check but limit it to the root node or specific known bus types? That would require explicitly whitelisting the check for a lot of bus types, given that each I2C/... controller binding is a bus type... -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html