From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: lee.jones@linaro.org, sameo@linux.intel.com, broonie@kernel.org,
linus.walleij@linaro.org, akpm@linux-foundation.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
rtc-linux@googlegroups.com, rob.herring@calxeda.com,
mark.rutland@arm.com, pawel.moll@arm.com, rob@landley.net,
ijc+devicetree@hellion.org.uk, grant.likely@linaro.org,
florian.lobmaier@ams.com
Subject: Re: [PATCH 1/4] mfd: add support for AMS AS3722 PMIC
Date: Mon, 23 Sep 2013 10:45:43 -0600 [thread overview]
Message-ID: <52407037.80004@wwwdotorg.org> (raw)
In-Reply-To: <1379400338-20704-2-git-send-email-ldewangan@nvidia.com>
On 09/17/2013 12:45 AM, Laxman Dewangan wrote:
> The AMS AS3722 is a compact system PMU suitable for mobile phones,
> tablets etc. It has 4 DC/DC step-down regulators, 3 DC/DC step-down
> controller, 11 LDOs, RTC, automatic battery, temperature and
> over-current monitoring, 8 GPIOs, ADC and wathdog.
>
> Add mfd core driver for the AS3722 to support core functionality.
Nice patch description.
(although a couple typos: s/wathdog/watchdog/, s/mfd/MFD/)
> +Note: This gpio properties will be in the as3722 node.
Why? If there's a GPIO sub-node, why wouldn't all the GPIO properties
appear there?
> +Sub-node compatible:
> +-------------------
> +The of_node of its all child node will have compatible so that it can
> +get the child node handle and pass as the dev->of_node when registering
> +mfd devices.
That's very much Linux-specific details. Re-phrasing it as follows would
make more sense:
==========
Each HW module within the PMIC is represented as a separate child node
within the PMIC's main node. These nodes are described below:
GPIO controller
-------------------
Required properties:
compatible: Must be "ams,as3722-gpio"
...
Regulator
-------------------
...
==========
That also has the benefit of fully describing the content of all the
child nodes in the binding, rather than only mentioning what the
compatible values should be, and saying nothing else about the nodes.
But, as Mark asked, why are any child nodes needed at all? If e.g. an
identical/re-usable GPIO HW block appears in many AMS PMICs, it possibly
makes sense, but otherwise it doesn't.
next prev parent reply other threads:[~2013-09-23 16:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 6:45 [PATCH 0/4] Add AMS AS3722 mfd, GPIO, regulator and RTC driver Laxman Dewangan
2013-09-17 6:45 ` [PATCH 1/4] mfd: add support for AMS AS3722 PMIC Laxman Dewangan
[not found] ` <1379400338-20704-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-17 8:02 ` Lee Jones
2013-09-17 11:24 ` Mark Brown
2013-09-17 12:03 ` Laxman Dewangan
[not found] ` <5238450F.6090303-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-17 12:22 ` Laxman Dewangan
2013-09-23 16:45 ` Stephen Warren [this message]
2013-09-17 6:45 ` [PATCH 2/4] gpio: add support for AMS AS3722 gpio driver Laxman Dewangan
2013-09-23 16:53 ` Stephen Warren
2013-09-17 6:45 ` [PATCH 3/4] regulator: as3722: add regulator driver for AMS AS3722 Laxman Dewangan
2013-09-17 11:41 ` Mark Brown
2013-09-17 12:15 ` Laxman Dewangan
2013-09-23 16:58 ` Stephen Warren
2013-09-17 6:45 ` [PATCH 4/4] drivers/rtc/rtc-as3722: add RTC driver Laxman Dewangan
[not found] ` <1379400338-20704-5-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-17 11:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52407037.80004@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.lobmaier@ams.com \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).