* [PATCH 1/2] dt-bindings: media: Remove K3 Family Prefix from Compatible
2023-12-04 18:14 [PATCH 0/2] Update Wave521c Compatible for TI Devices Brandon Brnich
@ 2023-12-04 18:14 ` Brandon Brnich
2023-12-05 6:55 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Brandon Brnich @ 2023-12-04 18:14 UTC (permalink / raw)
To: Geert Uytterhoeven, linux-media, devicetree, Krzysztof Kozlowski,
Sebastian Fricke, Nas Chung
Cc: Nishanth Menon, Darren Etheridge, Brandon Brnich
K3 family prefix is not included in other TI compatible
strings. Remove this prefix to keep naming convention
consistent.
Fixes: de4b9f7e371a ("dt-bindings: media: wave5: add yaml devicetree bindings")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Closes: https://lore.kernel.org/all/CAMuHMdUYOq=q1j=d+Eac28hthOUAaNUkuvxmRu-mUN1pLKq69g@mail.gmail.com/
Signed-off-by: Brandon Brnich <b-brnich@ti.com>
---
Documentation/devicetree/bindings/media/cnm,wave521c.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/media/cnm,wave521c.yaml b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
index 6d5569e77b7a..471840e858c9 100644
--- a/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
+++ b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
@@ -17,7 +17,7 @@ properties:
compatible:
items:
- enum:
- - ti,k3-j721s2-wave521c
+ - ti,j721s2-wave521c
- const: cnm,wave521c
reg:
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: media: Remove K3 Family Prefix from Compatible
2023-12-04 18:14 ` [PATCH 1/2] dt-bindings: media: Remove K3 Family Prefix from Compatible Brandon Brnich
@ 2023-12-05 6:55 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-05 6:55 UTC (permalink / raw)
To: Brandon Brnich, Geert Uytterhoeven, linux-media, devicetree,
Sebastian Fricke, Nas Chung
Cc: Nishanth Menon, Darren Etheridge
On 04/12/2023 19:14, Brandon Brnich wrote:
> K3 family prefix is not included in other TI compatible
> strings. Remove this prefix to keep naming convention
> consistent.
>
> Fixes: de4b9f7e371a ("dt-bindings: media: wave5: add yaml devicetree bindings")
This change breaks the ABI, so does it mean it was not yet released?
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: media: Remove K3 Family Prefix from Compatible
@ 2023-12-05 18:19 Brnich, Brandon
2023-12-06 11:16 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Brnich, Brandon @ 2023-12-05 18:19 UTC (permalink / raw)
To: Krzysztof Kozlowski, Geert Uytterhoeven,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
Sebastian Fricke, Nas Chung
Cc: Menon, Nishanth, Etheridge, Darren
Hello Krzysztof,
> On 04/12/2023 19:14, Brandon Brnich wrote:
> > K3 family prefix is not included in other TI compatible strings.
> > Remove this prefix to keep naming convention consistent.
> >
> > Fixes: de4b9f7e371a ("dt-bindings: media: wave5: add yaml devicetree
> > bindings")
>
> This change breaks the ABI, so does it mean it was not yet released?
This driver has not yet made it into releases. It currently resides in linux-next.
>
> Please use scripts/get_maintainers.pl to get a list of necessary people and
> lists to CC (and consider --no-git-fallback argument). It might happen, that
> command when run on an older kernel, gives you outdated entries.
> Therefore please be sure you base your patches on recent Linux kernel.
I will update this in next version.
>
> Best regards,
> Krzysztof
Thanks,
Brandon
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: media: Remove K3 Family Prefix from Compatible
2023-12-05 18:19 [PATCH 1/2] dt-bindings: media: Remove K3 Family Prefix from Compatible Brnich, Brandon
@ 2023-12-06 11:16 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-06 11:16 UTC (permalink / raw)
To: Brnich, Brandon, Geert Uytterhoeven, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, Sebastian Fricke, Nas Chung
Cc: Menon, Nishanth, Etheridge, Darren
On 05/12/2023 19:19, Brnich, Brandon wrote:
> Hello Krzysztof,
>
>> On 04/12/2023 19:14, Brandon Brnich wrote:
>>> K3 family prefix is not included in other TI compatible strings.
>>> Remove this prefix to keep naming convention consistent.
>>>
>>> Fixes: de4b9f7e371a ("dt-bindings: media: wave5: add yaml devicetree
>>> bindings")
>>
>> This change breaks the ABI, so does it mean it was not yet released?
>
> This driver has not yet made it into releases. It currently resides in linux-next.
Why nothing in commit changelog or cover letter explains it? Then you
get obvious questions...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-06 11:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-05 18:19 [PATCH 1/2] dt-bindings: media: Remove K3 Family Prefix from Compatible Brnich, Brandon
2023-12-06 11:16 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2023-12-04 18:14 [PATCH 0/2] Update Wave521c Compatible for TI Devices Brandon Brnich
2023-12-04 18:14 ` [PATCH 1/2] dt-bindings: media: Remove K3 Family Prefix from Compatible Brandon Brnich
2023-12-05 6:55 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).