devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
To: Sourav Poddar <sourav.poddar-l0cyMroinI0@public.gmane.org>
Cc: bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
	tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	balbi-l0cyMroinI0@public.gmane.org
Subject: Re: [PATCH] arm: dts: omap5-uevm: Add status parameter for i2c/spi/uart.
Date: Tue, 24 Sep 2013 11:14:44 +0530	[thread overview]
Message-ID: <524126CC.3020300@ti.com> (raw)
In-Reply-To: <1380001165-19078-1-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>

On Tuesday 24 September 2013 11:09 AM, Sourav Poddar wrote:
> omap5 has all devices enable by default.
> Disable thosw not required in omap5 uevm board.

s/thosw/those

> 
> Fix the following:
> Added status parameter
> Simulataneously, fix some tab formatting.

s/Simulataneously/Simultaneously

> 
> Signed-off-by: Sourav Poddar <sourav.poddar-l0cyMroinI0@public.gmane.org>
> ---
>  arch/arm/boot/dts/omap5-uevm.dts |   38 +++++++++++++++++++++++++++++++-------
>  1 files changed, 31 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
> index 65d7b60..78cf0f2 100644
> --- a/arch/arm/boot/dts/omap5-uevm.dts
> +++ b/arch/arm/boot/dts/omap5-uevm.dts
> @@ -450,6 +450,18 @@
>  	};
>  };
>  
> +&i2c2 {
> +	status = "disabled";
> +};
> +
> +&i2c3 {
> +	status = "disabled";
> +};
> +
> +&i2c4 {
> +	status = "disabled";
> +};

The right thing to do would be to mark these as disabled in omap5.dtsi
so boards can enable only what they need instead of disable what they
don't need (which is potentially a very long list)

Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2013-09-24  5:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-24  5:39 [PATCH] arm: dts: omap5-uevm: Add status parameter for i2c/spi/uart Sourav Poddar
     [not found] ` <1380001165-19078-1-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2013-09-24  5:44   ` Sekhar Nori [this message]
     [not found]     ` <524126CC.3020300-l0cyMroinI0@public.gmane.org>
2013-09-24  5:48       ` Sourav Poddar
2013-09-24  6:27         ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524126CC.3020300@ti.com \
    --to=nsekhar-l0cymroini0@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sourav.poddar-l0cyMroinI0@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).