Re: [PATCH 2/2] ARM: dts: dra7-evm: Add mmc2 node for eMMC support

[Balaji T K <balajitk-l0cyMroinI0@public.gmane.org>]

On Tuesday 24 September 2013 03:11 PM, Benoit Cousson wrote:
> + Sekhar
>
> Hi Balaji,
>
> On 26/08/2013 15:53, Balaji T K wrote:
>> Add mmc2 dt node to dra7-evm board
>> and model eMMC vcc as fixed regulator.
>>
>> Signed-off-by: Balaji T K <balajitk-l0cyMroinI0@public.gmane.org>
>> ---
>>   arch/arm/boot/dts/dra7-evm.dts |   14 ++++++++++++++
>>   1 files changed, 14 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
>> index a59bbd0..2062724 100644
>> --- a/arch/arm/boot/dts/dra7-evm.dts
>> +++ b/arch/arm/boot/dts/dra7-evm.dts
>> @@ -17,6 +17,13 @@
>>           device_type = "memory";
>>           reg = <0x80000000 0x60000000>; /* 1536 MB */
>>       };
>> +
>> +    mmc2_3v3: fixedregulator-mmc2 {
>> +        compatible = "regulator-fixed";
>> +        regulator-name = "mmc2_3v3";
>> +        regulator-min-microvolt = <3300000>;
>> +        regulator-max-microvolt = <3300000>;
>> +    };
>>   };
>>
>>   &dra7_pmx_core {
>> @@ -257,3 +264,10 @@
>>       vmmc-supply = <&ldo1_reg>;
>>       bus-width = <4>;
>>   };
>> +
>> +&mmc2 {
>> +    status = "okay";
>> +    vmmc-supply = <&mmc2_3v3>;
>> +    bus-width = <8>;
>> +    ti,non-removable;
>
> Sekhar just posted a series to replace that with a non-TI attribute: non-removable.
>
> I'm not sure if this got merged, but it might be good to use the standard attribute instead.

Hi Benoit,

Those patches are not merged yet, standard attribute is good, but few cleanups are needed
before ti,non-removable can be replaced by standard non-removable,
no_regulator_off_init flag set under ti,non-removable is needed to detect eMMC
during boot on OMAP4 devices to keep regulator ON during init. Given that eMMC on dra7-evm
is powered by always ON regulator, ti,non-removable and standard attribute will behave same
way. Let me know if you want to remove ti,non-removable attribute from this patch.

>
> Regards,
> Benoit

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html