From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Hesselbarth Subject: Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT Date: Thu, 26 Sep 2013 14:42:23 +0200 Message-ID: <52442BAF.6090006@gmail.com> References: <20130828113521.35c53365@armhf> <521DCD80.9010105@gmail.com> <20130831125128.0e3a23c7@armhf> <140d8d8a23f.2784.107cef0f820c2f5d7b7f41463071c310@gmail.com> <20130926101147.217015e1@armhf> <5243F0CE.9000301@gmail.com> <20130926132859.04ad4407@armhf> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130926132859.04ad4407@armhf> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jean-Francois Moine Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jason Cooper , Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Russell King , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 09/26/2013 01:28 PM, Jean-Francois Moine wrote: > On Thu, 26 Sep 2013 10:31:10 +0200 > Sebastian Hesselbarth wrote: > >> On 09/26/2013 10:11 AM, Jean-Francois Moine wrote: >>> In the Cubox, I changed the audio DT to: >>> >>> &i2s1 { >>> status = "okay"; >>> clocks = <&gate_clk 13>, <&si5351 1>; >>> clock-names = "internal", "extclk"; >>> pinctrl-0 = <&pmx_audio1_i2s1_spdifo &pmx_gpio_13_audio1>; >> >> Have you checked that pinmux was configured correctly? >> >> You are missing a >> >> pinctrl-names = "default"; >> >> to actually execute the above pinmux setting. > > Thanks, the pinmux was not set correctly, and I added the "default". > > [snip] >> What about trying to get 48kHz working first? Does it work with >> internal DCO and 48kHz? External audio clock should be 256*fs as stated >> in dove datasheet. > > I have no input with 48kHz. Or 44k1, just something that works with internal dco. kirkwood-i2s should request 256*fs, or 11289600 Hz for 44k1 audio rate from external clock. >>> For more information, I use i2s input in the tda998x with audio rate >>> 96kHz on HDMI output. The sound is fine with the internal dco (tested >>> with 44.1kHz only). >> >> Sorry, I don't understand the above "information". How can you have a >> different input audio rate tested with 44k1 output rate? > > The internal dco permits only 44.1, 44 and 96 kHz, so, vlc translates > the input rates smaller than 44.1 kHz to 44.1 kHz. So you are actually testing 44k1 in any case. Let's stick with 44k1 for now. >> Have you ever tested your audio equipment with something different than >> 48k and 44k1 SPDIF PCM? Are you actually sure it works at all, i.e. do >> you have different audio source with SPDIF >48kHz? Can you try optical >> SPDIF instead of HDMI? >> >> Just try to narrow it down, currently I cannot see why this behavior >> should be limited to either si5351 or dove audio alone. > > I have no optical S/PDIF. Ok, but 44k1 works with HDMI, we try to reproduce 44k1 with external clock now. > Well, I did more tests: > > - i2s or s/pdif input by the tda998x work fine with the internal dco Ok. > - the pinmux seems correct: > > device f10b4000.audio-controller > state default > type MUX_GROUP (2) > controlling device f10d0200.pin-ctrl > group mpp_audio1 > function i2s1/spdifo > > device f10b4000.audio-controller > state default > type MUX_GROUP (2) > controlling device f10d0200.pin-ctrl > group mpp13 > function audio1 > > - I tried both <&si5351 1> and <&si5351 2>, and I get no sound with the > external clock. > > - when running vlc with the external clock, the flux towards the > kirkwood driver is blocked and there is no sound interrupt. > > 47: 0 main-interrupt-ctrl 21 kirkwood-i2s Can you add "usleep_range(10000, 12000);" after clk_set_rate(extclk) in kirkwood-i2s. That should be enough to get around any issues with external clock not being stable. I will look up real requirements for si5351 later (and actually this should move to clk-si5351.c later too). Please make sure, you stick with 44k1 (or something that works with DCO). Sebastian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html