From: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
To: Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
rnayak-l0cyMroinI0@public.gmane.org,
bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCHv7 30/36] ARM: dts: omap3 clock data
Date: Thu, 26 Sep 2013 11:23:35 -0500 [thread overview]
Message-ID: <52445F87.30006@ti.com> (raw)
In-Reply-To: <20130926160657.GA6280@kahuna>
On 09/26/2013 11:06 AM, Nishanth Menon wrote:
> On 11:48-20130925, Tero Kristo wrote:
>> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
>> index 16420ae..bc11b83 100644
>> --- a/arch/arm/boot/dts/omap3.dtsi
>> +++ b/arch/arm/boot/dts/omap3.dtsi
>> @@ -533,4 +533,11 @@
>> ram-bits = <12>;
>> };
>> };
>> +
>> + clocks {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges;
>> + /include/ "omap3xxx-clocks.dtsi"
>> + };
>> };
> Clocks are introduced towards the tail of the dts -> this has a problem
> associated with it -> device nodes should be able to reference phandle
> like:
>
> devicex {
> clocks = <&sys_ck>;
> }
>
> Since all the devices on ocp and cpu0 node appears above the definition
> they fail to catch the phandle. instead, moving the clocks node as high
> in the tree as possible resolves this: something like:
> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
> index bc11b83..0b2161d 100644
> --- a/arch/arm/boot/dts/omap3.dtsi
> +++ b/arch/arm/boot/dts/omap3.dtsi
> @@ -24,6 +24,13 @@
> serial2 = &uart3;
> };
>
> + clocks {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> + /include/ "omap3xxx-clocks.dtsi"
> + };
> +
> cpus {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -534,10 +541,4 @@
> };
> };
>
> - clocks {
> - #address-cells = <1>;
> - #size-cells = <1>;
> - ranges;
> - /include/ "omap3xxx-clocks.dtsi"
> - };
> };
>
> What do you think of the change? applies for all clock nodes in other
> dtsi as well - I will mark them as I find them.
Digging further, the above is not needed. Apologies on the noise.
below changes will be nice though..
>
> Further,
>> diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi
>> index 5355d61..2ed7c69 100644
>> --- a/arch/arm/boot/dts/omap34xx.dtsi
>> +++ b/arch/arm/boot/dts/omap34xx.dtsi
>> @@ -25,4 +25,123 @@
>> clock-latency = <300000>; /* From legacy driver */
>> };
>> };
>> -};
>> +
>> + clocks {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges;
> dont need to state the above two -> already done in omap3.dtsi.
>> + /include/ "omap34xx-omap36xx-clocks.dtsi"
>> + /include/ "omap36xx-omap3430es2plus-clocks.dtsi"
>> + /include/ "omap36xx-am35xx-omap3430es2plus-clocks.dtsi"
>> + };
>> +};
> [...]
>> \ No newline at end of file
> ^^
> [...]
>> diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi
>> index f8b3765..71fb6fb 100644
>> --- a/arch/arm/boot/dts/omap36xx.dtsi
>> +++ b/arch/arm/boot/dts/omap36xx.dtsi
>> @@ -35,4 +35,124 @@
>> clock-frequency = <48000000>;
>> };
>> };
>> -};
>> +
>> + clocks {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges;
> ^^ here as well.
>> + /include/ "omap36xx-clocks.dtsi"
>> + /include/ "omap34xx-omap36xx-clocks.dtsi"
>> + /include/ "omap36xx-omap3430es2plus-clocks.dtsi"
>> + /include/ "omap36xx-am35xx-omap3430es2plus-clocks.dtsi"
>> + };
> [...]
>> +};
>> \ No newline at end of file
> ^^ this need fix as well.
>
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-09-26 16:23 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 8:48 [PATCHv7 00/36] ARM: OMAP: clock data conversion to DT Tero Kristo
2013-09-25 8:48 ` [PATCHv7 01/36] CLK: TI: Add DPLL clock support Tero Kristo
2013-09-25 8:48 ` [PATCHv7 04/36] CLK: ti: add support for ti divider-clock Tero Kristo
2013-09-25 8:48 ` [PATCHv7 07/36] CLK: TI: add support for clockdomain binding Tero Kristo
2013-09-25 8:48 ` [PATCHv7 08/36] ARM: dts: omap4 clock data Tero Kristo
2013-09-25 8:48 ` [PATCHv7 10/36] clk: ti: add support for basic mux clock Tero Kristo
2013-09-25 8:48 ` [PATCHv7 11/36] CLK: TI: add omap4 clock init file Tero Kristo
2013-09-25 8:48 ` [PATCHv7 12/36] ARM: OMAP4: remove old clock data and link in new clock init code Tero Kristo
2013-09-25 8:48 ` [PATCHv7 13/36] ARM: dts: omap5 clock data Tero Kristo
2013-09-25 8:48 ` [PATCHv7 15/36] CLK: TI: omap5: Initialize USB_DPLL at boot Tero Kristo
[not found] ` <1380098922-30340-1-git-send-email-t-kristo-l0cyMroinI0@public.gmane.org>
2013-09-25 8:48 ` [PATCHv7 02/36] CLK: TI: add DT alias clock registration mechanism Tero Kristo
2013-09-25 8:48 ` [PATCHv7 03/36] CLK: TI: add autoidle support Tero Kristo
2013-09-25 8:48 ` [PATCHv7 05/36] clk: ti: add support for TI fixed factor clock Tero Kristo
2013-09-25 8:48 ` [PATCHv7 06/36] CLK: TI: add support for OMAP gate clock Tero Kristo
2013-09-25 8:48 ` [PATCHv7 09/36] clk: ti: add mux-gate clock support Tero Kristo
2013-09-25 8:48 ` [PATCHv7 14/36] CLK: TI: add omap5 clock init file Tero Kristo
2013-09-25 8:48 ` [PATCHv7 16/36] ARM: dts: dra7 clock data Tero Kristo
2013-09-25 8:48 ` [PATCHv7 17/36] ARM: dts: clk: Add apll related clocks Tero Kristo
2013-09-25 8:48 ` [PATCHv7 20/36] CLK: TI: DRA7: Add APLL support Tero Kristo
2013-10-08 5:16 ` Mike Turquette
2013-09-25 8:48 ` [PATCHv7 21/36] CLK: TI: add dra7 clock init file Tero Kristo
2013-09-25 8:48 ` [PATCHv7 22/36] ARM: OMAP: DRA7: Enable clock init Tero Kristo
2013-09-25 8:48 ` [PATCHv7 25/36] CLK: TI: add am33xx clock init file Tero Kristo
2013-09-25 8:48 ` [PATCHv7 26/36] ARM: AM33xx: remove old clock data and link in new clock init code Tero Kristo
2013-09-25 8:48 ` [PATCHv7 27/36] CLK: TI: add interface clock support for OMAP3 Tero Kristo
2013-09-25 8:48 ` [PATCHv7 28/36] ARM: OMAP: hwmod: fix an incorrect clk type cast with _get_clkdm Tero Kristo
2013-09-25 8:48 ` [PATCHv7 29/36] ARM: OMAP3: hwmod: initialize clkdm from clkdm_name Tero Kristo
2013-09-25 8:48 ` [PATCHv7 30/36] ARM: dts: omap3 clock data Tero Kristo
2013-09-26 16:06 ` Nishanth Menon
2013-09-26 16:23 ` Nishanth Menon [this message]
2013-09-25 8:48 ` [PATCHv7 31/36] CLK: TI: add omap3 clock init file Tero Kristo
2013-09-25 8:48 ` [PATCHv7 34/36] ARM: dts: am43xx clock data Tero Kristo
2013-09-25 8:48 ` [PATCHv7 36/36] CLK: TI: add am43xx clock init file Tero Kristo
2013-09-26 15:21 ` [PATCHv7 00/36] ARM: OMAP: clock data conversion to DT Nishanth Menon
2013-09-26 15:29 ` Nishanth Menon
2013-10-04 15:34 ` Tero Kristo
2013-10-07 2:15 ` Tony Lindgren
2013-10-07 6:35 ` Tero Kristo
2013-10-07 15:41 ` Tony Lindgren
2013-10-07 16:13 ` Nishanth Menon
2013-10-07 19:03 ` Tony Lindgren
[not found] ` <20131007190322.GY8949-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2013-10-09 18:55 ` Paul Walmsley
2013-10-09 18:59 ` Paul Walmsley
2013-10-09 19:24 ` Tony Lindgren
2013-10-10 7:18 ` Tero Kristo
2013-10-11 17:54 ` Paul Walmsley
2013-10-11 18:23 ` Tero Kristo
2013-10-11 22:26 ` Paul Walmsley
2013-10-11 18:46 ` Tero Kristo
2013-10-11 22:37 ` Paul Walmsley
2013-10-12 10:25 ` Tero Kristo
2013-10-13 23:45 ` Paul Walmsley
2013-10-14 14:57 ` Tero Kristo
2013-10-14 18:27 ` Paul Walmsley
2013-10-14 18:34 ` Tero Kristo
2013-10-09 19:22 ` Tony Lindgren
2013-10-10 8:17 ` Tero Kristo
2013-10-11 22:53 ` Tony Lindgren
2013-09-25 8:48 ` [PATCHv7 18/36] ARM: dts: DRA7: Change apll_pcie_m2_ck to fixed factor clock Tero Kristo
2013-09-25 8:48 ` [PATCHv7 19/36] ARM: dts: DRA7: Add PCIe related clock nodes Tero Kristo
2013-09-25 8:48 ` [PATCHv7 23/36] ARM: dts: DRA7: link in clock DT data Tero Kristo
2013-09-25 8:48 ` [PATCHv7 24/36] ARM: dts: am33xx clock data Tero Kristo
2013-09-25 8:48 ` [PATCHv7 32/36] ARM: dts: AM35xx: use DT " Tero Kristo
2013-09-25 8:48 ` [PATCHv7 33/36] ARM: OMAP3: use DT clock init if DT data is available Tero Kristo
2013-09-25 8:48 ` [PATCHv7 35/36] ARM: dts: AM43xx: link in clock DT data Tero Kristo
2013-10-08 5:40 ` [PATCHv7 00/36] ARM: OMAP: clock data conversion to DT Mike Turquette
2013-10-08 8:17 ` Tero Kristo
2013-10-08 16:47 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52445F87.30006@ti.com \
--to=nm-l0cymroini0@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org \
--cc=rnayak-l0cyMroinI0@public.gmane.org \
--cc=t-kristo-l0cyMroinI0@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).