[PATCH 0/2] ARM: dts: dra7-evm: add support for sd, eMMC

[PATCH 0/2] ARM: dts: dra7-evm: add support for sd, eMMC

[Balaji T K]

Add mmc1, mmc2 dt node to dra7-evm

Balaji T K (2):
  ARM: dts: dra7-evm: Add mmc1 node for micro-sd support
  ARM: dts: dra7-evm: Add mmc2 node for eMMC support

 arch/arm/boot/dts/dra7-evm.dts |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)

-- 
1.7.5.4

[PATCH 1/2] ARM: dts: dra7-evm: Add mmc1 node for micro-sd support

[Balaji T K]

Add mmc1 dt node to dra7-evm board.
Input for ldo1 regulator is controlled by gpio 5 of pcf8575 chip (0x21)
on i2c1 bus. When dt support for gpio-pcf857x is available, input supply
will be modelled as cascaded regulator.

Signed-off-by: Balaji T K <balajitk@ti.com>
---
Patch has dependency on [1] for ldo1_reg
[1] [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes
https://lkml.org/lkml/2013/8/26/21

 arch/arm/boot/dts/dra7-evm.dts |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index 32f8534..a59bbd0 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -251,3 +251,9 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart3_pins>;
 };
+
+&mmc1 {
+	status = "okay";
+	vmmc-supply = <&ldo1_reg>;
+	bus-width = <4>;
+};
-- 
1.7.5.4

[PATCH 2/2] ARM: dts: dra7-evm: Add mmc2 node for eMMC support

[Balaji T K]

Add mmc2 dt node to dra7-evm board
and model eMMC vcc as fixed regulator.

Signed-off-by: Balaji T K <balajitk@ti.com>
---
 arch/arm/boot/dts/dra7-evm.dts |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index a59bbd0..2062724 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -17,6 +17,13 @@
 		device_type = "memory";
 		reg = <0x80000000 0x60000000>; /* 1536 MB */
 	};
+
+	mmc2_3v3: fixedregulator-mmc2 {
+		compatible = "regulator-fixed";
+		regulator-name = "mmc2_3v3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+	};
 };
 
 &dra7_pmx_core {
@@ -257,3 +264,10 @@
 	vmmc-supply = <&ldo1_reg>;
 	bus-width = <4>;
 };
+
+&mmc2 {
+	status = "okay";
+	vmmc-supply = <&mmc2_3v3>;
+	bus-width = <8>;
+	ti,non-removable;
+};
-- 
1.7.5.4

Re: [PATCH 0/2] ARM: dts: dra7-evm: add support for sd, eMMC

[Nishanth Menon]

On 08/26/2013 08:53 AM, Balaji T K wrote:
> Add mmc1, mmc2 dt node to dra7-evm
> 
> Balaji T K (2):
>   ARM: dts: dra7-evm: Add mmc1 node for micro-sd support
>   ARM: dts: dra7-evm: Add mmc2 node for eMMC support
> 
>  arch/arm/boot/dts/dra7-evm.dts |   20 ++++++++++++++++++++
>  1 files changed, 20 insertions(+), 0 deletions(-)
> 
Series:

Acked-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>

Thanks. this is needed for MMC boot on DRA7 evm.
-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] ARM: dts: dra7-evm: Add mmc2 node for eMMC support

[Benoit Cousson]

+ Sekhar

Hi Balaji,

On 26/08/2013 15:53, Balaji T K wrote:
> Add mmc2 dt node to dra7-evm board
> and model eMMC vcc as fixed regulator.
>
> Signed-off-by: Balaji T K <balajitk@ti.com>
> ---
>   arch/arm/boot/dts/dra7-evm.dts |   14 ++++++++++++++
>   1 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
> index a59bbd0..2062724 100644
> --- a/arch/arm/boot/dts/dra7-evm.dts
> +++ b/arch/arm/boot/dts/dra7-evm.dts
> @@ -17,6 +17,13 @@
>   		device_type = "memory";
>   		reg = <0x80000000 0x60000000>; /* 1536 MB */
>   	};
> +
> +	mmc2_3v3: fixedregulator-mmc2 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "mmc2_3v3";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +	};
>   };
>
>   &dra7_pmx_core {
> @@ -257,3 +264,10 @@
>   	vmmc-supply = <&ldo1_reg>;
>   	bus-width = <4>;
>   };
> +
> +&mmc2 {
> +	status = "okay";
> +	vmmc-supply = <&mmc2_3v3>;
> +	bus-width = <8>;
> +	ti,non-removable;

Sekhar just posted a series to replace that with a non-TI attribute: 
non-removable.

I'm not sure if this got merged, but it might be good to use the 
standard attribute instead.

Regards,
Benoit

Re: [PATCH 2/2] ARM: dts: dra7-evm: Add mmc2 node for eMMC support

[Balaji T K]

On Tuesday 24 September 2013 03:11 PM, Benoit Cousson wrote:
> + Sekhar
>
> Hi Balaji,
>
> On 26/08/2013 15:53, Balaji T K wrote:
>> Add mmc2 dt node to dra7-evm board
>> and model eMMC vcc as fixed regulator.
>>
>> Signed-off-by: Balaji T K <balajitk-l0cyMroinI0@public.gmane.org>
>> ---
>>   arch/arm/boot/dts/dra7-evm.dts |   14 ++++++++++++++
>>   1 files changed, 14 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
>> index a59bbd0..2062724 100644
>> --- a/arch/arm/boot/dts/dra7-evm.dts
>> +++ b/arch/arm/boot/dts/dra7-evm.dts
>> @@ -17,6 +17,13 @@
>>           device_type = "memory";
>>           reg = <0x80000000 0x60000000>; /* 1536 MB */
>>       };
>> +
>> +    mmc2_3v3: fixedregulator-mmc2 {
>> +        compatible = "regulator-fixed";
>> +        regulator-name = "mmc2_3v3";
>> +        regulator-min-microvolt = <3300000>;
>> +        regulator-max-microvolt = <3300000>;
>> +    };
>>   };
>>
>>   &dra7_pmx_core {
>> @@ -257,3 +264,10 @@
>>       vmmc-supply = <&ldo1_reg>;
>>       bus-width = <4>;
>>   };
>> +
>> +&mmc2 {
>> +    status = "okay";
>> +    vmmc-supply = <&mmc2_3v3>;
>> +    bus-width = <8>;
>> +    ti,non-removable;
>
> Sekhar just posted a series to replace that with a non-TI attribute: non-removable.
>
> I'm not sure if this got merged, but it might be good to use the standard attribute instead.

Hi Benoit,

Those patches are not merged yet, standard attribute is good, but few cleanups are needed
before ti,non-removable can be replaced by standard non-removable,
no_regulator_off_init flag set under ti,non-removable is needed to detect eMMC
during boot on OMAP4 devices to keep regulator ON during init. Given that eMMC on dra7-evm
is powered by always ON regulator, ti,non-removable and standard attribute will behave same
way. Let me know if you want to remove ti,non-removable attribute from this patch.

>
> Regards,
> Benoit

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] ARM: dts: dra7-evm: Add mmc2 node for eMMC support

[Sekhar Nori]

On 9/25/2013 9:47 PM, Balaji T K wrote:
> On Tuesday 24 September 2013 03:11 PM, Benoit Cousson wrote:
>> + Sekhar
>>
>> Hi Balaji,
>>
>> On 26/08/2013 15:53, Balaji T K wrote:
>>> Add mmc2 dt node to dra7-evm board
>>> and model eMMC vcc as fixed regulator.
>>>
>>> Signed-off-by: Balaji T K <balajitk-l0cyMroinI0@public.gmane.org>
>>> ---
>>>   arch/arm/boot/dts/dra7-evm.dts |   14 ++++++++++++++
>>>   1 files changed, 14 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/dra7-evm.dts
>>> b/arch/arm/boot/dts/dra7-evm.dts
>>> index a59bbd0..2062724 100644
>>> --- a/arch/arm/boot/dts/dra7-evm.dts
>>> +++ b/arch/arm/boot/dts/dra7-evm.dts
>>> @@ -17,6 +17,13 @@
>>>           device_type = "memory";
>>>           reg = <0x80000000 0x60000000>; /* 1536 MB */
>>>       };
>>> +
>>> +    mmc2_3v3: fixedregulator-mmc2 {
>>> +        compatible = "regulator-fixed";
>>> +        regulator-name = "mmc2_3v3";
>>> +        regulator-min-microvolt = <3300000>;
>>> +        regulator-max-microvolt = <3300000>;
>>> +    };
>>>   };
>>>
>>>   &dra7_pmx_core {
>>> @@ -257,3 +264,10 @@
>>>       vmmc-supply = <&ldo1_reg>;
>>>       bus-width = <4>;
>>>   };
>>> +
>>> +&mmc2 {
>>> +    status = "okay";
>>> +    vmmc-supply = <&mmc2_3v3>;
>>> +    bus-width = <8>;
>>> +    ti,non-removable;
>>
>> Sekhar just posted a series to replace that with a non-TI attribute:
>> non-removable.
>>
>> I'm not sure if this got merged, but it might be good to use the
>> standard attribute instead.
> 
> Hi Benoit,
> 
> Those patches are not merged yet, standard attribute is good, but few
> cleanups are needed
> before ti,non-removable can be replaced by standard non-removable,
> no_regulator_off_init flag set under ti,non-removable is needed to
> detect eMMC
> during boot on OMAP4 devices to keep regulator ON during init. Given
> that eMMC on dra7-evm
> is powered by always ON regulator, ti,non-removable and standard
> attribute will behave same
> way. Let me know if you want to remove ti,non-removable attribute from
> this patch.

I dont think its an issue if ti,non-removable and non-removable behave
exactly the same. In fact, it will be confusing if they behave differently.

I understand there is a need to clean-up the code around
no_regulator_off_init, but I am hoping that can be kept separate from
moving to a generic binding. The two clean-ups can be done independent
of each other.

Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] ARM: dts: dra7-evm: Add mmc2 node for eMMC support

[Balaji T K]

Add mmc2 dt node to dra7-evm board
and model eMMC vcc as fixed regulator.

Signed-off-by: Balaji T K <balajitk@ti.com>
---
Rebase to for_3.13/dts
and removed ti,non-removable

 arch/arm/boot/dts/dra7-evm.dts |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index 65cd15a..3abf5f4 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -17,6 +17,13 @@
 		device_type = "memory";
 		reg = <0x80000000 0x60000000>; /* 1536 MB */
 	};
+
+	mmc2_3v3: fixedregulator-mmc2 {
+		compatible = "regulator-fixed";
+		regulator-name = "mmc2_3v3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+	};
 };
 
 &dra7_pmx_core {
@@ -256,3 +263,9 @@
 	vmmc-supply = <&ldo1_reg>;
 	bus-width = <4>;
 };
+
+&mmc2 {
+	status = "okay";
+	vmmc-supply = <&mmc2_3v3>;
+	bus-width = <8>;
+};
-- 
1.7.5.4

Re: [PATCH 2/2] ARM: dts: dra7-evm: Add mmc2 node for eMMC support

[Nishanth Menon]

On 10/07/2013 11:25 AM, Balaji T K wrote:
> Add mmc2 dt node to dra7-evm board
> and model eMMC vcc as fixed regulator.
> 
> Signed-off-by: Balaji T K <balajitk@ti.com>
> ---
> Rebase to for_3.13/dts
> and removed ti,non-removable
> 
>  arch/arm/boot/dts/dra7-evm.dts |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
> index 65cd15a..3abf5f4 100644
> --- a/arch/arm/boot/dts/dra7-evm.dts
> +++ b/arch/arm/boot/dts/dra7-evm.dts
> @@ -17,6 +17,13 @@
>  		device_type = "memory";
>  		reg = <0x80000000 0x60000000>; /* 1536 MB */
>  	};
> +
> +	mmc2_3v3: fixedregulator-mmc2 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "mmc2_3v3";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +	};
>  };
>  
>  &dra7_pmx_core {
> @@ -256,3 +263,9 @@
>  	vmmc-supply = <&ldo1_reg>;
>  	bus-width = <4>;
>  };
> +
> +&mmc2 {
> +	status = "okay";
> +	vmmc-supply = <&mmc2_3v3>;
> +	bus-width = <8>;
> +};
> 
boot tested on DRA7-EVM
voltage rail is correct based on schematics(rev d1) too.
Reviewed-by: Nishanth Menon <nm@ti.com>
Tested-by: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon

Re: [PATCH 2/2] ARM: dts: dra7-evm: Add mmc2 node for eMMC support

[Sekhar Nori]

On Monday 07 October 2013 09:55 PM, Balaji T K wrote:
> Add mmc2 dt node to dra7-evm board
> and model eMMC vcc as fixed regulator.
> 
> Signed-off-by: Balaji T K <balajitk@ti.com>

Acked-by: Sekhar Nori <nsekhar@ti.com>

Thanks,
Sekhar