* [PATCH] pinctrl: palmas: remove pin config BIAS_PULL_PIN_DEFAULT support
@ 2013-10-02 11:37 Laxman Dewangan
2013-10-02 16:11 ` Stephen Warren
2013-10-08 11:28 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Laxman Dewangan @ 2013-10-02 11:37 UTC (permalink / raw)
To: linus.walleij
Cc: swarren, linux-kernel, linux-doc, devicetree, heiko,
Laxman Dewangan
Palmas devices do not support the default bias configuration
and hence removing this option from valid pin config parameters.
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
Based on discussion on the patch
pinctrl: palmas: do not abort pin configuration for BIAS_DEFAULT
creating this patch to remove this option.
.../devicetree/bindings/pinctrl/pinctrl-palmas.txt | 2 +-
drivers/pinctrl/pinctrl-palmas.c | 3 ---
2 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-palmas.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-palmas.txt
index 734d9b0..caf297b 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-palmas.txt
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-palmas.txt
@@ -41,7 +41,7 @@ pinctrl-bindings.txt:
Required: pins
Options: function, bias-disable, bias-pull-up, bias-pull-down,
- bias-pin-default, drive-open-drain.
+ drive-open-drain.
Note that many of these properties are only valid for certain specific pins.
See the Palmas device datasheet for complete details regarding which pins
diff --git a/drivers/pinctrl/pinctrl-palmas.c b/drivers/pinctrl/pinctrl-palmas.c
index 6164381..f13d0e7 100644
--- a/drivers/pinctrl/pinctrl-palmas.c
+++ b/drivers/pinctrl/pinctrl-palmas.c
@@ -891,9 +891,6 @@ static int palmas_pinconf_set(struct pinctrl_dev *pctldev,
param = pinconf_to_config_param(configs[i]);
param_val = pinconf_to_config_argument(configs[i]);
- if (param == PIN_CONFIG_BIAS_PULL_PIN_DEFAULT)
- continue;
-
switch (param) {
case PIN_CONFIG_BIAS_DISABLE:
case PIN_CONFIG_BIAS_PULL_UP:
--
1.7.1.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: palmas: remove pin config BIAS_PULL_PIN_DEFAULT support
2013-10-02 11:37 [PATCH] pinctrl: palmas: remove pin config BIAS_PULL_PIN_DEFAULT support Laxman Dewangan
@ 2013-10-02 16:11 ` Stephen Warren
2013-10-08 11:28 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Warren @ 2013-10-02 16:11 UTC (permalink / raw)
To: Laxman Dewangan
Cc: linus.walleij, swarren, linux-kernel, linux-doc, devicetree,
heiko
On 10/02/2013 05:37 AM, Laxman Dewangan wrote:
> Palmas devices do not support the default bias configuration
> and hence removing this option from valid pin config parameters.
Acked-by: Stephen Warren <swarren@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: palmas: remove pin config BIAS_PULL_PIN_DEFAULT support
2013-10-02 11:37 [PATCH] pinctrl: palmas: remove pin config BIAS_PULL_PIN_DEFAULT support Laxman Dewangan
2013-10-02 16:11 ` Stephen Warren
@ 2013-10-08 11:28 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-10-08 11:28 UTC (permalink / raw)
To: Laxman Dewangan
Cc: Stephen Warren, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, devicetree@vger.kernel.org,
Heiko Stübner
On Wed, Oct 2, 2013 at 1:37 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
> Palmas devices do not support the default bias configuration
> and hence removing this option from valid pin config parameters.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Patch applied with Stephen's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-08 11:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-02 11:37 [PATCH] pinctrl: palmas: remove pin config BIAS_PULL_PIN_DEFAULT support Laxman Dewangan
2013-10-02 16:11 ` Stephen Warren
2013-10-08 11:28 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).