* [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes
@ 2013-08-26 5:36 Keerthy
2013-09-03 6:33 ` Keerthy
2013-09-09 19:21 ` Nishanth Menon
0 siblings, 2 replies; 8+ messages in thread
From: Keerthy @ 2013-08-26 5:36 UTC (permalink / raw)
To: bcousson
Cc: nm, devicetree, balajitk, pawel.moll, j-keerthy, linux-kernel,
rob.herring, linux-omap, linux-arm-kernel
The Patch adds nodes for TPS659038 PMIC for DRA7 boards.
It is based on top of:
http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.
Documentation: Documentation/devicetree/bindings/mfd/palmas.txt
Documentation/devicetree/bindings/regulator/palmas-pmic.txt
Boot Tested on DRA7 d1 Board.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
arch/arm/boot/dts/dra7-evm.dts | 118 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 118 insertions(+)
Index: linux/arch/arm/boot/dts/dra7-evm.dts
===================================================================
--- linux.orig/arch/arm/boot/dts/dra7-evm.dts 2013-08-26 09:57:52.496173554 +0530
+++ linux/arch/arm/boot/dts/dra7-evm.dts 2013-08-26 10:38:44.995414695 +0530
@@ -93,6 +93,119 @@
pinctrl-names = "default";
pinctrl-0 = <&i2c1_pins>;
clock-frequency = <400000>;
+
+ tps659038: tps659038@58 {
+ compatible = "ti,tps659038";
+ reg = <0x58>;
+
+ tps659038_pmic {
+ compatible = "ti,tps659038-pmic";
+
+ regulators {
+ smps123_reg: smps123 {
+ /* VDD_MPU */
+ regulator-name = "smps123";
+ regulator-min-microvolt = < 850000>;
+ regulator-max-microvolt = <1250000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ smps45_reg: smps45 {
+ /* VDD_DSPEVE */
+ regulator-name = "smps45";
+ regulator-min-microvolt = < 850000>;
+ regulator-max-microvolt = <1150000>;
+ regulator-boot-on;
+ };
+
+ smps6_reg: smps6 {
+ /* VDD_GPU - over VDD_SMPS6 */
+ regulator-name = "smps6";
+ regulator-min-microvolt = <850000>;
+ regulator-max-microvolt = <12500000>;
+ regulator-boot-on;
+ };
+
+ smps7_reg: smps7 {
+ /* CORE_VDD */
+ regulator-name = "smps7";
+ regulator-min-microvolt = <850000>;
+ regulator-max-microvolt = <1030000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ smps8_reg: smps8 {
+ /* VDD_IVAHD */
+ regulator-name = "smps8";
+ regulator-min-microvolt = < 850000>;
+ regulator-max-microvolt = <1250000>;
+ regulator-boot-on;
+ };
+
+ smps9_reg: smps9 {
+ /* VDDS1V8 */
+ regulator-name = "smps9";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo1_reg: ldo1 {
+ /* LDO1_OUT --> SDIO */
+ regulator-name = "ldo1";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ };
+
+ ldo2_reg: ldo2 {
+ /* VDD_RTCIO */
+ /* LDO2 -> VDDSHV5, LDO2 also goes to CAN_PHY_3V3 */
+ regulator-name = "ldo2";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ };
+
+ ldo3_reg: ldo3 {
+ /* VDDA_1V8_PHY */
+ regulator-name = "ldo3";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-boot-on;
+ };
+
+ ldo9_reg: ldo9 {
+ /* VDD_RTC */
+ regulator-name = "ldo9";
+ regulator-min-microvolt = <1050000>;
+ regulator-max-microvolt = <1050000>;
+ regulator-boot-on;
+ };
+
+ ldoln_reg: ldoln {
+ /* VDDA_1V8_PLL */
+ regulator-name = "ldoln";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldousb_reg: ldousb {
+ /* VDDA_3V_USB: VDDA_USBHS33 */
+ regulator-name = "ldousb";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ };
+
+ };
+ };
+ };
};
&i2c2 {
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes
2013-08-26 5:36 [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes Keerthy
@ 2013-09-03 6:33 ` Keerthy
2013-09-09 19:21 ` Nishanth Menon
1 sibling, 0 replies; 8+ messages in thread
From: Keerthy @ 2013-09-03 6:33 UTC (permalink / raw)
To: bcousson
Cc: linux-omap, linux-kernel, pawel.moll, devicetree, rob.herring,
linux-arm-kernel, nm, balajitk
Benoit,
On Monday 26 August 2013 11:06 AM, Keerthy wrote:
> The Patch adds nodes for TPS659038 PMIC for DRA7 boards.
>
> It is based on top of:
> http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.
>
> Documentation: Documentation/devicetree/bindings/mfd/palmas.txt
> Documentation/devicetree/bindings/regulator/palmas-pmic.txt
>
> Boot Tested on DRA7 d1 Board.
Any comments on this patch?
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> arch/arm/boot/dts/dra7-evm.dts | 118 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 118 insertions(+)
>
> Index: linux/arch/arm/boot/dts/dra7-evm.dts
> ===================================================================
> --- linux.orig/arch/arm/boot/dts/dra7-evm.dts 2013-08-26 09:57:52.496173554 +0530
> +++ linux/arch/arm/boot/dts/dra7-evm.dts 2013-08-26 10:38:44.995414695 +0530
> @@ -93,6 +93,119 @@
> pinctrl-names = "default";
> pinctrl-0 = <&i2c1_pins>;
> clock-frequency = <400000>;
> +
> + tps659038: tps659038@58 {
> + compatible = "ti,tps659038";
> + reg = <0x58>;
> +
> + tps659038_pmic {
> + compatible = "ti,tps659038-pmic";
> +
> + regulators {
> + smps123_reg: smps123 {
> + /* VDD_MPU */
> + regulator-name = "smps123";
> + regulator-min-microvolt = < 850000>;
> + regulator-max-microvolt = <1250000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps45_reg: smps45 {
> + /* VDD_DSPEVE */
> + regulator-name = "smps45";
> + regulator-min-microvolt = < 850000>;
> + regulator-max-microvolt = <1150000>;
> + regulator-boot-on;
> + };
> +
> + smps6_reg: smps6 {
> + /* VDD_GPU - over VDD_SMPS6 */
> + regulator-name = "smps6";
> + regulator-min-microvolt = <850000>;
> + regulator-max-microvolt = <12500000>;
> + regulator-boot-on;
> + };
> +
> + smps7_reg: smps7 {
> + /* CORE_VDD */
> + regulator-name = "smps7";
> + regulator-min-microvolt = <850000>;
> + regulator-max-microvolt = <1030000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps8_reg: smps8 {
> + /* VDD_IVAHD */
> + regulator-name = "smps8";
> + regulator-min-microvolt = < 850000>;
> + regulator-max-microvolt = <1250000>;
> + regulator-boot-on;
> + };
> +
> + smps9_reg: smps9 {
> + /* VDDS1V8 */
> + regulator-name = "smps9";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldo1_reg: ldo1 {
> + /* LDO1_OUT --> SDIO */
> + regulator-name = "ldo1";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
> + };
> +
> + ldo2_reg: ldo2 {
> + /* VDD_RTCIO */
> + /* LDO2 -> VDDSHV5, LDO2 also goes to CAN_PHY_3V3 */
> + regulator-name = "ldo2";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
> + };
> +
> + ldo3_reg: ldo3 {
> + /* VDDA_1V8_PHY */
> + regulator-name = "ldo3";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-boot-on;
> + };
> +
> + ldo9_reg: ldo9 {
> + /* VDD_RTC */
> + regulator-name = "ldo9";
> + regulator-min-microvolt = <1050000>;
> + regulator-max-microvolt = <1050000>;
> + regulator-boot-on;
> + };
> +
> + ldoln_reg: ldoln {
> + /* VDDA_1V8_PLL */
> + regulator-name = "ldoln";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldousb_reg: ldousb {
> + /* VDDA_3V_USB: VDDA_USBHS33 */
> + regulator-name = "ldousb";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
> + };
> +
> + };
> + };
> + };
> };
>
> &i2c2 {
Regards,
Keerthy
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes
2013-08-26 5:36 [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes Keerthy
2013-09-03 6:33 ` Keerthy
@ 2013-09-09 19:21 ` Nishanth Menon
2013-09-11 5:30 ` Keerthy
1 sibling, 1 reply; 8+ messages in thread
From: Nishanth Menon @ 2013-09-09 19:21 UTC (permalink / raw)
To: Keerthy
Cc: devicetree, balajitk, pawel.moll, linux-kernel, rob.herring,
bcousson, linux-omap, linux-arm-kernel
On 08/26/2013 12:36 AM, Keerthy wrote:
> The Patch adds nodes for TPS659038 PMIC for DRA7 boards.
>
> It is based on top of:
> http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.
>
> Documentation: Documentation/devicetree/bindings/mfd/palmas.txt
> Documentation/devicetree/bindings/regulator/palmas-pmic.txt
>
> Boot Tested on DRA7 d1 Board.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> arch/arm/boot/dts/dra7-evm.dts | 118 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 118 insertions(+)
>
> Index: linux/arch/arm/boot/dts/dra7-evm.dts
> ===================================================================
> --- linux.orig/arch/arm/boot/dts/dra7-evm.dts 2013-08-26 09:57:52.496173554 +0530
> +++ linux/arch/arm/boot/dts/dra7-evm.dts 2013-08-26 10:38:44.995414695 +0530
> @@ -93,6 +93,119 @@
> pinctrl-names = "default";
> pinctrl-0 = <&i2c1_pins>;
> clock-frequency = <400000>;
> +
> + tps659038: tps659038@58 {
> + compatible = "ti,tps659038";
> + reg = <0x58>;
> +
> + tps659038_pmic {
> + compatible = "ti,tps659038-pmic";
> +
> + regulators {
> + smps123_reg: smps123 {
> + /* VDD_MPU */
> + regulator-name = "smps123";
> + regulator-min-microvolt = < 850000>;
> + regulator-max-microvolt = <1250000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps45_reg: smps45 {
> + /* VDD_DSPEVE */
> + regulator-name = "smps45";
> + regulator-min-microvolt = < 850000>;
> + regulator-max-microvolt = <1150000>;
> + regulator-boot-on;
> + };
> +
> + smps6_reg: smps6 {
> + /* VDD_GPU - over VDD_SMPS6 */
> + regulator-name = "smps6";
> + regulator-min-microvolt = <850000>;
> + regulator-max-microvolt = <12500000>;
> + regulator-boot-on;
> + };
> +
> + smps7_reg: smps7 {
> + /* CORE_VDD */
> + regulator-name = "smps7";
> + regulator-min-microvolt = <850000>;
> + regulator-max-microvolt = <1030000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps8_reg: smps8 {
> + /* VDD_IVAHD */
> + regulator-name = "smps8";
> + regulator-min-microvolt = < 850000>;
> + regulator-max-microvolt = <1250000>;
> + regulator-boot-on;
> + };
> +
> + smps9_reg: smps9 {
> + /* VDDS1V8 */
> + regulator-name = "smps9";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldo1_reg: ldo1 {
> + /* LDO1_OUT --> SDIO */
> + regulator-name = "ldo1";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
> + };
> +
> + ldo2_reg: ldo2 {
> + /* VDD_RTCIO */
> + /* LDO2 -> VDDSHV5, LDO2 also goes to CAN_PHY_3V3 */
> + regulator-name = "ldo2";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
> + };
> +
> + ldo3_reg: ldo3 {
> + /* VDDA_1V8_PHY */
> + regulator-name = "ldo3";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-boot-on;
> + };
> +
> + ldo9_reg: ldo9 {
> + /* VDD_RTC */
> + regulator-name = "ldo9";
> + regulator-min-microvolt = <1050000>;
> + regulator-max-microvolt = <1050000>;
> + regulator-boot-on;
> + };
> +
> + ldoln_reg: ldoln {
> + /* VDDA_1V8_PLL */
> + regulator-name = "ldoln";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldousb_reg: ldousb {
> + /* VDDA_3V_USB: VDDA_USBHS33 */
> + regulator-name = "ldousb";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
> + };
> +
> + };
> + };
> + };
> };
>
> &i2c2 {
>
Acked-by: Nishanth Menon <nm@ti.com>
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes
2013-09-09 19:21 ` Nishanth Menon
@ 2013-09-11 5:30 ` Keerthy
2013-10-03 13:39 ` Benoit Cousson
0 siblings, 1 reply; 8+ messages in thread
From: Keerthy @ 2013-09-11 5:30 UTC (permalink / raw)
To: Nishanth Menon
Cc: devicetree, balajitk, pawel.moll, Keerthy, linux-kernel,
rob.herring, bcousson, linux-omap, linux-arm-kernel
On Tuesday 10 September 2013 12:51 AM, Nishanth Menon wrote:
> On 08/26/2013 12:36 AM, Keerthy wrote:
>> The Patch adds nodes for TPS659038 PMIC for DRA7 boards.
>>
>> It is based on top of:
>> http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.
>>
>> Documentation: Documentation/devicetree/bindings/mfd/palmas.txt
>> Documentation/devicetree/bindings/regulator/palmas-pmic.txt
>>
>> Boot Tested on DRA7 d1 Board.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>> arch/arm/boot/dts/dra7-evm.dts | 118 ++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 118 insertions(+)
>>
>> Index: linux/arch/arm/boot/dts/dra7-evm.dts
>> ===================================================================
>> --- linux.orig/arch/arm/boot/dts/dra7-evm.dts 2013-08-26 09:57:52.496173554 +0530
>> +++ linux/arch/arm/boot/dts/dra7-evm.dts 2013-08-26 10:38:44.995414695 +0530
>> @@ -93,6 +93,119 @@
>> pinctrl-names = "default";
>> pinctrl-0 = <&i2c1_pins>;
>> clock-frequency = <400000>;
>> +
>> + tps659038: tps659038@58 {
>> + compatible = "ti,tps659038";
>> + reg = <0x58>;
>> +
>> + tps659038_pmic {
>> + compatible = "ti,tps659038-pmic";
>> +
>> + regulators {
>> + smps123_reg: smps123 {
>> + /* VDD_MPU */
>> + regulator-name = "smps123";
>> + regulator-min-microvolt = < 850000>;
>> + regulator-max-microvolt = <1250000>;
>> + regulator-always-on;
>> + regulator-boot-on;
>> + };
>> +
>> + smps45_reg: smps45 {
>> + /* VDD_DSPEVE */
>> + regulator-name = "smps45";
>> + regulator-min-microvolt = < 850000>;
>> + regulator-max-microvolt = <1150000>;
>> + regulator-boot-on;
>> + };
>> +
>> + smps6_reg: smps6 {
>> + /* VDD_GPU - over VDD_SMPS6 */
>> + regulator-name = "smps6";
>> + regulator-min-microvolt = <850000>;
>> + regulator-max-microvolt = <12500000>;
>> + regulator-boot-on;
>> + };
>> +
>> + smps7_reg: smps7 {
>> + /* CORE_VDD */
>> + regulator-name = "smps7";
>> + regulator-min-microvolt = <850000>;
>> + regulator-max-microvolt = <1030000>;
>> + regulator-always-on;
>> + regulator-boot-on;
>> + };
>> +
>> + smps8_reg: smps8 {
>> + /* VDD_IVAHD */
>> + regulator-name = "smps8";
>> + regulator-min-microvolt = < 850000>;
>> + regulator-max-microvolt = <1250000>;
>> + regulator-boot-on;
>> + };
>> +
>> + smps9_reg: smps9 {
>> + /* VDDS1V8 */
>> + regulator-name = "smps9";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <1800000>;
>> + regulator-always-on;
>> + regulator-boot-on;
>> + };
>> +
>> + ldo1_reg: ldo1 {
>> + /* LDO1_OUT --> SDIO */
>> + regulator-name = "ldo1";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-boot-on;
>> + };
>> +
>> + ldo2_reg: ldo2 {
>> + /* VDD_RTCIO */
>> + /* LDO2 -> VDDSHV5, LDO2 also goes to CAN_PHY_3V3 */
>> + regulator-name = "ldo2";
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-boot-on;
>> + };
>> +
>> + ldo3_reg: ldo3 {
>> + /* VDDA_1V8_PHY */
>> + regulator-name = "ldo3";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <1800000>;
>> + regulator-boot-on;
>> + };
>> +
>> + ldo9_reg: ldo9 {
>> + /* VDD_RTC */
>> + regulator-name = "ldo9";
>> + regulator-min-microvolt = <1050000>;
>> + regulator-max-microvolt = <1050000>;
>> + regulator-boot-on;
>> + };
>> +
>> + ldoln_reg: ldoln {
>> + /* VDDA_1V8_PLL */
>> + regulator-name = "ldoln";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <1800000>;
>> + regulator-always-on;
>> + regulator-boot-on;
>> + };
>> +
>> + ldousb_reg: ldousb {
>> + /* VDDA_3V_USB: VDDA_USBHS33 */
>> + regulator-name = "ldousb";
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-boot-on;
>> + };
>> +
>> + };
>> + };
>> + };
>> };
>>
>> &i2c2 {
>>
> Acked-by: Nishanth Menon <nm@ti.com>
>
Thanks Nishanth.
Benoit,
Could you pull this patch?
Regards,
Keerthy
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes
2013-09-11 5:30 ` Keerthy
@ 2013-10-03 13:39 ` Benoit Cousson
[not found] ` <524D7397.2000200-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
0 siblings, 1 reply; 8+ messages in thread
From: Benoit Cousson @ 2013-10-03 13:39 UTC (permalink / raw)
To: Keerthy
Cc: Nishanth Menon, linux-omap, linux-kernel, pawel.moll, devicetree,
rob.herring, linux-arm-kernel, balajitk
Hi Keerthy,
On 11/09/2013 07:30, Keerthy wrote:
> On Tuesday 10 September 2013 12:51 AM, Nishanth Menon wrote:
>> On 08/26/2013 12:36 AM, Keerthy wrote:
>>> The Patch adds nodes for TPS659038 PMIC for DRA7 boards.
>>>
>>> It is based on top of:
>>> http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.
>>>
>>> Documentation: Documentation/devicetree/bindings/mfd/palmas.txt
>>> Documentation/devicetree/bindings/regulator/palmas-pmic.txt
>>>
>>> Boot Tested on DRA7 d1 Board.
>>>
>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>> ---
>>> arch/arm/boot/dts/dra7-evm.dts | 118
>>> ++++++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 118 insertions(+)
>>>
>>> Index: linux/arch/arm/boot/dts/dra7-evm.dts
>>> ===================================================================
>>> --- linux.orig/arch/arm/boot/dts/dra7-evm.dts 2013-08-26
>>> 09:57:52.496173554 +0530
>>> +++ linux/arch/arm/boot/dts/dra7-evm.dts 2013-08-26
>>> 10:38:44.995414695 +0530
>>> @@ -93,6 +93,119 @@
>>> pinctrl-names = "default";
>>> pinctrl-0 = <&i2c1_pins>;
>>> clock-frequency = <400000>;
>>> +
>>> + tps659038: tps659038@58 {
>>> + compatible = "ti,tps659038";
>>> + reg = <0x58>;
>>> +
>>> + tps659038_pmic {
>>> + compatible = "ti,tps659038-pmic";
>>> +
>>> + regulators {
>>> + smps123_reg: smps123 {
>>> + /* VDD_MPU */
>>> + regulator-name = "smps123";
>>> + regulator-min-microvolt = < 850000>;
>>> + regulator-max-microvolt = <1250000>;
>>> + regulator-always-on;
>>> + regulator-boot-on;
>>> + };
>>> +
>>> + smps45_reg: smps45 {
>>> + /* VDD_DSPEVE */
>>> + regulator-name = "smps45";
>>> + regulator-min-microvolt = < 850000>;
>>> + regulator-max-microvolt = <1150000>;
>>> + regulator-boot-on;
>>> + };
>>> +
>>> + smps6_reg: smps6 {
>>> + /* VDD_GPU - over VDD_SMPS6 */
>>> + regulator-name = "smps6";
>>> + regulator-min-microvolt = <850000>;
>>> + regulator-max-microvolt = <12500000>;
>>> + regulator-boot-on;
>>> + };
>>> +
>>> + smps7_reg: smps7 {
>>> + /* CORE_VDD */
>>> + regulator-name = "smps7";
>>> + regulator-min-microvolt = <850000>;
>>> + regulator-max-microvolt = <1030000>;
>>> + regulator-always-on;
>>> + regulator-boot-on;
>>> + };
>>> +
>>> + smps8_reg: smps8 {
>>> + /* VDD_IVAHD */
>>> + regulator-name = "smps8";
>>> + regulator-min-microvolt = < 850000>;
>>> + regulator-max-microvolt = <1250000>;
>>> + regulator-boot-on;
>>> + };
>>> +
>>> + smps9_reg: smps9 {
>>> + /* VDDS1V8 */
>>> + regulator-name = "smps9";
>>> + regulator-min-microvolt = <1800000>;
>>> + regulator-max-microvolt = <1800000>;
>>> + regulator-always-on;
>>> + regulator-boot-on;
>>> + };
>>> +
>>> + ldo1_reg: ldo1 {
>>> + /* LDO1_OUT --> SDIO */
>>> + regulator-name = "ldo1";
>>> + regulator-min-microvolt = <1800000>;
>>> + regulator-max-microvolt = <3300000>;
>>> + regulator-boot-on;
>>> + };
>>> +
>>> + ldo2_reg: ldo2 {
>>> + /* VDD_RTCIO */
>>> + /* LDO2 -> VDDSHV5, LDO2 also goes to
>>> CAN_PHY_3V3 */
>>> + regulator-name = "ldo2";
>>> + regulator-min-microvolt = <3300000>;
>>> + regulator-max-microvolt = <3300000>;
>>> + regulator-boot-on;
>>> + };
>>> +
>>> + ldo3_reg: ldo3 {
>>> + /* VDDA_1V8_PHY */
>>> + regulator-name = "ldo3";
>>> + regulator-min-microvolt = <1800000>;
>>> + regulator-max-microvolt = <1800000>;
>>> + regulator-boot-on;
>>> + };
>>> +
>>> + ldo9_reg: ldo9 {
>>> + /* VDD_RTC */
>>> + regulator-name = "ldo9";
>>> + regulator-min-microvolt = <1050000>;
>>> + regulator-max-microvolt = <1050000>;
>>> + regulator-boot-on;
>>> + };
>>> +
>>> + ldoln_reg: ldoln {
>>> + /* VDDA_1V8_PLL */
>>> + regulator-name = "ldoln";
>>> + regulator-min-microvolt = <1800000>;
>>> + regulator-max-microvolt = <1800000>;
>>> + regulator-always-on;
>>> + regulator-boot-on;
>>> + };
>>> +
>>> + ldousb_reg: ldousb {
>>> + /* VDDA_3V_USB: VDDA_USBHS33 */
>>> + regulator-name = "ldousb";
>>> + regulator-min-microvolt = <3300000>;
>>> + regulator-max-microvolt = <3300000>;
>>> + regulator-boot-on;
>>> + };
>>> +
Nit: Extra blank line not needed.
>>> + };
>>> + };
>>> + };
>>> };
Nit: You have an extra level on indentation not needed.
>>> &i2c2 {
>>>
>> Acked-by: Nishanth Menon <nm@ti.com>
Beside the two minors nits, the patch looks good to me.
Since, you've been waiting for some time for it, I fixed it myself and pulled it.
I even fixed the changelog... Lucky you :-)
You can check the updated version below.
Sorry for the delay.
Thanks,
Benoit
---
>From 3b8f02a2df475c7a48e12eb1911c014f8060b167 Mon Sep 17 00:00:00 2001
From: Keerthy <j-keerthy@ti.com>
Date: Mon, 26 Aug 2013 11:06:51 +0530
Subject: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes
Add DT nodes for TPS659038 PMIC on DRA7 boards.
It is based on top of:
http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.
Documentation:
- Documentation/devicetree/bindings/mfd/palmas.txt
- Documentation/devicetree/bindings/regulator/palmas-pmic.txt
Boot Tested on DRA7 d1 Board.
Signed-off-by: Keerthy <j-keerthy@ti.com>
Acked-by: Nishanth Menon <nm@ti.com>
[bcousson@baylibre.com: Fix indentation and changelog]
Signed-off-by: Benoit Cousson <bcousson@baylibre.com>
---
arch/arm/boot/dts/dra7-evm.dts | 112 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 112 insertions(+)
diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index ca5dab2..fbbe406 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -93,6 +93,118 @@
pinctrl-names = "default";
pinctrl-0 = <&i2c1_pins>;
clock-frequency = <400000>;
+
+ tps659038: tps659038@58 {
+ compatible = "ti,tps659038";
+ reg = <0x58>;
+
+ tps659038_pmic {
+ compatible = "ti,tps659038-pmic";
+
+ regulators {
+ smps123_reg: smps123 {
+ /* VDD_MPU */
+ regulator-name = "smps123";
+ regulator-min-microvolt = < 850000>;
+ regulator-max-microvolt = <1250000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ smps45_reg: smps45 {
+ /* VDD_DSPEVE */
+ regulator-name = "smps45";
+ regulator-min-microvolt = < 850000>;
+ regulator-max-microvolt = <1150000>;
+ regulator-boot-on;
+ };
+
+ smps6_reg: smps6 {
+ /* VDD_GPU - over VDD_SMPS6 */
+ regulator-name = "smps6";
+ regulator-min-microvolt = <850000>;
+ regulator-max-microvolt = <12500000>;
+ regulator-boot-on;
+ };
+
+ smps7_reg: smps7 {
+ /* CORE_VDD */
+ regulator-name = "smps7";
+ regulator-min-microvolt = <850000>;
+ regulator-max-microvolt = <1030000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ smps8_reg: smps8 {
+ /* VDD_IVAHD */
+ regulator-name = "smps8";
+ regulator-min-microvolt = < 850000>;
+ regulator-max-microvolt = <1250000>;
+ regulator-boot-on;
+ };
+
+ smps9_reg: smps9 {
+ /* VDDS1V8 */
+ regulator-name = "smps9";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo1_reg: ldo1 {
+ /* LDO1_OUT --> SDIO */
+ regulator-name = "ldo1";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ };
+
+ ldo2_reg: ldo2 {
+ /* VDD_RTCIO */
+ /* LDO2 -> VDDSHV5, LDO2 also goes to CAN_PHY_3V3 */
+ regulator-name = "ldo2";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ };
+
+ ldo3_reg: ldo3 {
+ /* VDDA_1V8_PHY */
+ regulator-name = "ldo3";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-boot-on;
+ };
+
+ ldo9_reg: ldo9 {
+ /* VDD_RTC */
+ regulator-name = "ldo9";
+ regulator-min-microvolt = <1050000>;
+ regulator-max-microvolt = <1050000>;
+ regulator-boot-on;
+ };
+
+ ldoln_reg: ldoln {
+ /* VDDA_1V8_PLL */
+ regulator-name = "ldoln";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldousb_reg: ldousb {
+ /* VDDA_3V_USB: VDDA_USBHS33 */
+ regulator-name = "ldousb";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ };
+ };
+ };
+ };
};
&i2c2 {
--
1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes
@ 2013-08-13 5:42 Keerthy
2013-08-14 23:35 ` Nishanth Menon
0 siblings, 1 reply; 8+ messages in thread
From: Keerthy @ 2013-08-13 5:42 UTC (permalink / raw)
To: devicetree, linux-kernel
Cc: swarren, rob.herring, pawel.moll, mark.rutland, nm, balajitk,
j-keerthy
The Patch adds nodes for TPS659038 PMIC for DRA7 boards.
It is based on:
http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.
Documentation: Documentation/devicetree/bindings/mfd/palmas.txt
Documentation/devicetree/bindings/regulator/palmas-pmic.txt
Tested on DRA7 Board, 3.11-rc5 plus the above patch-set.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
arch/arm/boot/dts/dra7-evm.dts | 118 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 118 insertions(+)
diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index b270e24..96f409f 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -93,6 +93,124 @@
pinctrl-names = "default";
pinctrl-0 = <&i2c1_pins>;
clock-frequency = <400000>;
+
+ tps659038: tps659038@58 {
+ compatible = "ti,tps659038";
+ reg = <0x58>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+
+ tps659038_pmic {
+ compatible = "ti,tps659038-pmic";
+
+ regulators {
+ smps123_reg: smps123 {
+ /* VDD_MPU */
+ regulator-name = "smps123";
+ regulator-min-microvolt = < 600000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ smps45_reg: smps45 {
+ /* VDD_DSPEVE */
+ regulator-name = "smps45";
+ regulator-min-microvolt = < 600000>;
+ regulator-max-microvolt = <1310000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ smps6_reg: smps6 {
+ /* VDD_GPU - over VDD_SMPS6 */
+ regulator-name = "smps6";
+ regulator-min-microvolt = <600000>;
+ regulator-max-microvolt = <13100000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ smps7_reg: smps7 {
+ /* VDDS_CORE */
+ regulator-name = "smps7";
+ regulator-min-microvolt = <600000>;
+ regulator-max-microvolt = <1310000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ smps8_reg: smps8 {
+ /* VDD_IVAHD */
+ regulator-name = "smps8";
+ regulator-min-microvolt = < 600000>;
+ regulator-max-microvolt = <1310000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ smps9_reg: smps9 {
+ /* VDD_1V8 */
+ regulator-name = "smps9";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo1_reg: ldo1 {
+ /* LDO1_OUT --> SDIO */
+ regulator-name = "ldo1";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo2_reg: ldo2 {
+ /* VDD_RTCIO */
+ regulator-name = "ldo2";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo3_reg: ldo3 {
+ /* VDDA_1V8 PHYs */
+ regulator-name = "ldo3";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ ldo9_reg: ldo9 {
+ /* VDD_RTC */
+ regulator-name = "ldo9";
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldoln_reg: ldoln {
+ /* VDDA_1v8: PLLs */
+ regulator-name = "ldoln";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldousb_reg: ldousb {
+ /* VDDA_3V_USB: VDDA_USBHS33 */
+ regulator-name = "ldousb";
+ regulator-min-microvolt = <3250000>;
+ regulator-max-microvolt = <3250000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ };
+ };
+ };
};
&i2c2 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes
2013-08-13 5:42 Keerthy
@ 2013-08-14 23:35 ` Nishanth Menon
0 siblings, 0 replies; 8+ messages in thread
From: Nishanth Menon @ 2013-08-14 23:35 UTC (permalink / raw)
To: Keerthy
Cc: devicetree, linux-kernel, swarren, rob.herring, pawel.moll,
mark.rutland, balajitk
linux-omap, linux-arm-list should also be CCed, Benoit needs to be
addressed for allowing him to merge,
I have not done a proper schematics Vs data manual review yet
(apologies on that), but, a couple of comments:
On 08/13/2013 12:42 AM, Keerthy wrote:
> The Patch adds nodes for TPS659038 PMIC for DRA7 boards.
>
> It is based on:
> http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.
>
> Documentation: Documentation/devicetree/bindings/mfd/palmas.txt
> Documentation/devicetree/bindings/regulator/palmas-pmic.txt
>
> Tested on DRA7 Board, 3.11-rc5 plus the above patch-set.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> arch/arm/boot/dts/dra7-evm.dts | 118 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 118 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
> index b270e24..96f409f 100644
> --- a/arch/arm/boot/dts/dra7-evm.dts
> +++ b/arch/arm/boot/dts/dra7-evm.dts
> @@ -93,6 +93,124 @@
> pinctrl-names = "default";
> pinctrl-0 = <&i2c1_pins>;
> clock-frequency = <400000>;
> +
> + tps659038: tps659038@58 {
> + compatible = "ti,tps659038";
> + reg = <0x58>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
Where is the interrupt line to MPU? if it is not hooked up, why the
interrupt controller?
> +
> + tps659038_pmic {
> + compatible = "ti,tps659038-pmic";
> +
> + regulators {
> + smps123_reg: smps123 {
> + /* VDD_MPU */
^^ tab issue?
> + regulator-name = "smps123";
> + regulator-min-microvolt = < 600000>;
> + regulator-max-microvolt = <1500000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps45_reg: smps45 {
> + /* VDD_DSPEVE */
> + regulator-name = "smps45";
> + regulator-min-microvolt = < 600000>;
> + regulator-max-microvolt = <1310000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps6_reg: smps6 {
> + /* VDD_GPU - over VDD_SMPS6 */
> + regulator-name = "smps6";
> + regulator-min-microvolt = <600000>;
> + regulator-max-microvolt = <13100000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps7_reg: smps7 {
> + /* VDDS_CORE */
> + regulator-name = "smps7";
> + regulator-min-microvolt = <600000>;
> + regulator-max-microvolt = <1310000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps8_reg: smps8 {
> + /* VDD_IVAHD */
> + regulator-name = "smps8";
> + regulator-min-microvolt = < 600000>;
> + regulator-max-microvolt = <1310000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps9_reg: smps9 {
> + /* VDD_1V8 */
> + regulator-name = "smps9";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldo1_reg: ldo1 {
> + /* LDO1_OUT --> SDIO */
> + regulator-name = "ldo1";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + };
> +
> + ldo2_reg: ldo2 {
> + /* VDD_RTCIO */
> + regulator-name = "ldo2";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldo3_reg: ldo3 {
> + /* VDDA_1V8 PHYs */
> + regulator-name = "ldo3";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> +
> + ldo9_reg: ldo9 {
> + /* VDD_RTC */
> + regulator-name = "ldo9";
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1000000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + ldoln_reg: ldoln {
> + /* VDDA_1v8: PLLs */
> + regulator-name = "ldoln";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldousb_reg: ldousb {
> + /* VDDA_3V_USB: VDDA_USBHS33 */
> + regulator-name = "ldousb";
> + regulator-min-microvolt = <3250000>;
> + regulator-max-microvolt = <3250000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + };
> + };
> + };
Who are using these LDOs? Example SDIO LDO should be linked up with
MMC instance, no? how about the PLLs and PHYs?
> };
>
> &i2c2 {
>
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-10-04 8:25 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-26 5:36 [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes Keerthy
2013-09-03 6:33 ` Keerthy
2013-09-09 19:21 ` Nishanth Menon
2013-09-11 5:30 ` Keerthy
2013-10-03 13:39 ` Benoit Cousson
[not found] ` <524D7397.2000200-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2013-10-04 8:25 ` Keerthy
-- strict thread matches above, loose matches on Subject: below --
2013-08-13 5:42 Keerthy
2013-08-14 23:35 ` Nishanth Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).