From: Stephen Boyd <sboyd@codeaurora.org>
To: Stanimir Varbanov <svarbanov@mm-sol.com>
Cc: Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-kernel@vger.kernel.org, Rob Landley <rob@landley.net>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/2] hwrng: msm: Add PRNG support for MSM SoC's
Date: Fri, 04 Oct 2013 09:37:25 -0700 [thread overview]
Message-ID: <524EEEC5.7090803@codeaurora.org> (raw)
In-Reply-To: <524EED4E.8090505@mm-sol.com>
On 10/04/13 09:31, Stanimir Varbanov wrote:
>
>>> +static int msm_rng_probe(struct platform_device *pdev)
>>> +{
>>> + struct msm_rng *rng;
>>> + struct device_node *np;
>>> + struct resource res;
>>> + int ret;
>>> +
>>> + np = of_node_get(pdev->dev.of_node);
>>> + if (!np)
>>> + return -ENODEV;
>> This is unnecessary.
> I used this call because CONFIG_OF_DYNAMIC could be enabled at some
> time. Isn't that possible? I saw that of_node_get|put is used in .probe
> on few places in drivers.
So far we aren't selecting that config on ARM.
If you look at of_device_alloc() you'll see
dev->dev.of_node = of_node_get(np);
so any platform devices created from of_platform_populate won't have
their of_node go away.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2013-10-04 16:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 14:52 [PATCH 0/2] Add support for Qualcomm's PRNG Stanimir Varbanov
2013-10-03 14:52 ` [PATCH 1/2] ARM: DT: msm: Add Qualcomm's PRNG driver binding document Stanimir Varbanov
2013-10-03 14:52 ` [PATCH 2/2] hwrng: msm: Add PRNG support for MSM SoC's Stanimir Varbanov
2013-10-03 19:25 ` Stephen Boyd
2013-10-04 16:31 ` Stanimir Varbanov
2013-10-04 16:37 ` Stephen Boyd [this message]
2013-10-09 8:23 ` Stanimir Varbanov
[not found] ` <1380811955-18085-1-git-send-email-svarbanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2013-10-03 16:51 ` [PATCH 0/2] Add support for Qualcomm's PRNG Theodore Ts'o
[not found] ` <20131003165130.GA11974-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
2013-10-04 16:23 ` Stanimir Varbanov
[not found] ` <524EEB96.6040707-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2013-10-04 18:10 ` Theodore Ts'o
2013-10-09 14:46 ` Stanimir Varbanov
2013-10-09 15:07 ` H. Peter Anvin
2013-10-09 16:03 ` Theodore Ts'o
2013-10-09 16:24 ` H. Peter Anvin
2013-10-10 10:41 ` Paul Mackerras
2013-10-10 15:08 ` H. Peter Anvin
2013-10-10 13:47 ` Stanimir Varbanov
2013-10-11 7:05 ` Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524EEEC5.7090803@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mpm@selenic.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=svarbanov@mm-sol.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).