From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris brezillon Subject: Re: [PATCH v3 04/19] clk: at91: add PMC macro file for dt definitions Date: Mon, 07 Oct 2013 18:06:33 +0200 Message-ID: <5252DC09.6010207@overkiz.com> References: <1375937608-3773-1-git-send-email-b.brezillon@overkiz.com> <1375938270-3965-1-git-send-email-b.brezillon@overkiz.com> <5252D0A5.60304@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5252D0A5.60304-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Nicolas Ferre , Grant Likely , Rob Herring , Rob Landley , Andrew Victor , Jean-Christophe Plagniol-Villard , Russell King , Mike Turquette , Felipe Balbi , Greg Kroah-Hartman , Ludovic Desroches , Josh Wu , Richard Genoud Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 07/10/2013 17:17, Nicolas Ferre wrote: > On 08/08/2013 07:04, Boris BREZILLON : >> This patch adds a new macro file for PMC macros. >> >> This macro file includes the definitions of SR (status register) bit >> offsets and will be use to reference PMC irqs. >> >> Signed-off-by: Boris BREZILLON >> --- >> include/dt-bindings/clk/at91/common/pmc.h | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> create mode 100644 include/dt-bindings/clk/at91/common/pmc.h >> >> diff --git a/include/dt-bindings/clk/at91/common/pmc.h >> b/include/dt-bindings/clk/at91/common/pmc.h >> new file mode 100644 >> index 0000000..edc51d6 >> --- /dev/null >> +++ b/include/dt-bindings/clk/at91/common/pmc.h >> @@ -0,0 +1,20 @@ >> +/* >> + * This header provides constants for AT91 pmc status. >> + * >> + * The constants defined in this header are being used in dts. > > It is better to add one line about license: for example: > > * Licensed under GPLv2 or later. > > >> + */ >> + >> +#ifndef _DT_BINDINGS_CLK_AT91_PMC_H >> +#define _DT_BINDINGS_CLK_AT91_PMC_H >> + >> +#define AT91_PMC_MOSCS 0 /* MOSCS Flag */ >> +#define AT91_PMC_LOCKA 1 /* PLLA Lock */ >> +#define AT91_PMC_LOCKB 2 /* PLLB Lock */ >> +#define AT91_PMC_MCKRDY 3 /* Master Clock */ >> +#define AT91_PMC_LOCKU 6 /* UPLL Lock */ >> +#define AT91_PMC_PCKRDY(id) (8 + id) /* Programmable Clock */ > > I prefer with parenthesis around "id" (8 + (id)) Absolutely, I'll fix it. > >> +#define AT91_PMC_MOSCSELS 16 /* Main Oscillator Selection */ >> +#define AT91_PMC_MOSCRCS 17 /* Main On-Chip RC */ >> +#define AT91_PMC_CFDEV 18 /* Clock Failure Detector >> Event */ >> + >> +#endif >> > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html