From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Terje_Bergstr=F6m?= Subject: Re: [PATCH v2 06/27] gpu: host1x: Cleanup includes Date: Tue, 8 Oct 2013 08:59:58 +0300 Message-ID: <52539F5E.1060005@nvidia.com> References: <1381134884-5816-1-git-send-email-treding@nvidia.com> <1381134884-5816-7-git-send-email-treding@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1381134884-5816-7-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" Cc: "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On 07.10.2013 11:34, Thierry Reding wrote: > Most of the included files are either not required or already included > by some other header file. What's the general policy? I personally feel that each source file should #include all the header files it needs, and should not rely on header files #including other header files. This way if header file A stops needing header file B, we don't need to go and fix all users of header file A that assume B is included. I've been hit by this multiple times in Linux kernel - sometimes some header files just assume another header file is #included and refuses to compile it it isn't. Terje