devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/3] AM33XX crypto DTS patches
@ 2013-10-05 19:04 Joel Fernandes
  2013-10-05 19:04 ` [PATCH v3 1/3] ARM: dts: AM33XX: Add SHAM data and documentation Joel Fernandes
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Joel Fernandes @ 2013-10-05 19:04 UTC (permalink / raw)
  To: Mark Rutland, Benoit Cousson
  Cc: Linux OMAP List, Linux ARM Kernel List, Linux Kernel Mailing List,
	devicetree-u79uwXL29TY76Z2rM5mHXA

These patches are some minor fixups and changes to commit messages to the
AM33XX crypto (aes, sham) patches with reference to the comments at:
http://comments.gmane.org/gmane.linux.drivers.devicetree/45961

Joel Fernandes (1):
  ARM: dts: AM33XX: Fix AES interrupt number

Mark A. Greer (2):
  ARM: dts: AM33XX: Add SHAM data and documentation
  ARM: dts: AM33XX: Add AES data and documentation

 .../devicetree/bindings/crypto/omap-aes.txt        | 31 ++++++++++++++++++++++
 .../devicetree/bindings/crypto/omap-sham.txt       | 28 +++++++++++++++++++
 arch/arm/boot/dts/am335x-bone.dts                  |  8 ++++++
 arch/arm/boot/dts/am335x-evm.dts                   |  8 ++++++
 arch/arm/boot/dts/am335x-evmsk.dts                 |  8 ++++++
 arch/arm/boot/dts/am33xx.dtsi                      | 19 +++++++++++++
 6 files changed, 102 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/crypto/omap-aes.txt
 create mode 100644 Documentation/devicetree/bindings/crypto/omap-sham.txt

-- 
1.8.1.2

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v3 1/3] ARM: dts: AM33XX: Add SHAM data and documentation
  2013-10-05 19:04 [PATCH v3 0/3] AM33XX crypto DTS patches Joel Fernandes
@ 2013-10-05 19:04 ` Joel Fernandes
  2013-10-05 19:04 ` [PATCH v3 2/3] ARM: dts: AM33XX: Add AES " Joel Fernandes
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Joel Fernandes @ 2013-10-05 19:04 UTC (permalink / raw)
  To: Mark Rutland, Benoit Cousson
  Cc: Linux OMAP List, Linux ARM Kernel List, Linux Kernel Mailing List,
	devicetree, Paul Walmsley

From: "Mark A. Greer" <mgreer@animalcreek.com>

Add the generic AM33XX SHAM module's device tree data and
enable it for the am335x-evm, am335x-evmsk, and am335x-bone
platforms.  Also add Documentation file describing the data
for the SHAM module.

[joelf@ti.com: Dropped interrupt-parrent property, documentation fixups]
CC: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
---
 .../devicetree/bindings/crypto/omap-sham.txt       | 28 ++++++++++++++++++++++
 arch/arm/boot/dts/am335x-bone.dts                  |  4 ++++
 arch/arm/boot/dts/am335x-evm.dts                   |  4 ++++
 arch/arm/boot/dts/am335x-evmsk.dts                 |  4 ++++
 arch/arm/boot/dts/am33xx.dtsi                      |  9 +++++++
 5 files changed, 49 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/crypto/omap-sham.txt

diff --git a/Documentation/devicetree/bindings/crypto/omap-sham.txt b/Documentation/devicetree/bindings/crypto/omap-sham.txt
new file mode 100644
index 0000000..f839acd
--- /dev/null
+++ b/Documentation/devicetree/bindings/crypto/omap-sham.txt
@@ -0,0 +1,28 @@
+OMAP SoC SHA crypto Module
+
+Required properties:
+
+- compatible : Should contain entries for this and backward compatible
+  SHAM versions:
+  - "ti,omap2-sham" for OMAP2 & OMAP3.
+  - "ti,omap4-sham" for OMAP4 and AM33XX.
+  Note that these two versions are incompatible.
+- ti,hwmods: Name of the hwmod associated with the SHAM module
+- reg : Offset and length of the register set for the module
+- interrupts : the interrupt-specifier for the SHAM module.
+
+Optional properties:
+- dmas: DMA specifiers for the rx dma. See the DMA client binding,
+	Documentation/devicetree/bindings/dma/dma.txt
+- dma-names: DMA request name. Should be "rx" if a dma is present.
+
+Example:
+	/* AM335x */
+	sham: sham@53100000 {
+		compatible = "ti,omap4-sham";
+		ti,hwmods = "sham";
+		reg = <0x53100000 0x200>;
+		interrupts = <109>;
+		dmas = <&edma 36>;
+		dma-names = "rx";
+	};
diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts
index 0d63348..8a9802e 100644
--- a/arch/arm/boot/dts/am335x-bone.dts
+++ b/arch/arm/boot/dts/am335x-bone.dts
@@ -19,3 +19,7 @@
 &mmc1 {
 	vmmc-supply = <&ldo3_reg>;
 };
+
+&sham {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index 23b0a3e..d59e51c 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -522,3 +522,7 @@
 	status = "okay";
 	vmmc-supply = <&vmmc_reg>;
 };
+
+&sham {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
index bc93895..d45a330 100644
--- a/arch/arm/boot/dts/am335x-evmsk.dts
+++ b/arch/arm/boot/dts/am335x-evmsk.dts
@@ -424,3 +424,7 @@
 	status = "okay";
 	vmmc-supply = <&vmmc_reg>;
 };
+
+&sham {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 553adc6..299710b 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -710,5 +710,14 @@
 			#size-cells = <1>;
 			status = "disabled";
 		};
+
+		sham: sham@53100000 {
+			compatible = "ti,omap4-sham";
+			ti,hwmods = "sham";
+			reg = <0x53100000 0x200>;
+			interrupts = <109>;
+			dmas = <&edma 36>;
+			dma-names = "rx";
+		};
 	};
 };
-- 
1.8.1.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v3 2/3] ARM: dts: AM33XX: Add AES data and documentation
  2013-10-05 19:04 [PATCH v3 0/3] AM33XX crypto DTS patches Joel Fernandes
  2013-10-05 19:04 ` [PATCH v3 1/3] ARM: dts: AM33XX: Add SHAM data and documentation Joel Fernandes
@ 2013-10-05 19:04 ` Joel Fernandes
  2013-10-05 19:04 ` [PATCH v3 3/3] ARM: dts: AM33XX: Fix AES interrupt number Joel Fernandes
       [not found] ` <1380999877-20884-1-git-send-email-joelf-l0cyMroinI0@public.gmane.org>
  3 siblings, 0 replies; 5+ messages in thread
From: Joel Fernandes @ 2013-10-05 19:04 UTC (permalink / raw)
  To: Mark Rutland, Benoit Cousson
  Cc: Linux OMAP List, Linux ARM Kernel List, Linux Kernel Mailing List,
	devicetree, Paul Walmsley

From: "Mark A. Greer" <mgreer@animalcreek.com>

Add the generic AM33XX AES module's device tree data and
enable it for the am335x-evm, am335x-evmsk, and am335x-bone
platforms.  Also add Documentation file describing the data
for the AES module.

[joelf@ti.com: Dropped interrupt-parent propert, documentation fixups]

CC: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
---
 .../devicetree/bindings/crypto/omap-aes.txt        | 31 ++++++++++++++++++++++
 arch/arm/boot/dts/am335x-bone.dts                  |  4 +++
 arch/arm/boot/dts/am335x-evm.dts                   |  4 +++
 arch/arm/boot/dts/am335x-evmsk.dts                 |  4 +++
 arch/arm/boot/dts/am33xx.dtsi                      | 10 +++++++
 5 files changed, 53 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/crypto/omap-aes.txt

diff --git a/Documentation/devicetree/bindings/crypto/omap-aes.txt b/Documentation/devicetree/bindings/crypto/omap-aes.txt
new file mode 100644
index 0000000..fd97176
--- /dev/null
+++ b/Documentation/devicetree/bindings/crypto/omap-aes.txt
@@ -0,0 +1,31 @@
+OMAP SoC AES crypto Module
+
+Required properties:
+
+- compatible : Should contain entries for this and backward compatible
+  AES versions:
+  - "ti,omap2-aes" for OMAP2.
+  - "ti,omap3-aes" for OMAP3.
+  - "ti,omap4-aes" for OMAP4 and AM33XX.
+  Note that the OMAP2 and 3 versions are compatible (OMAP3 supports
+  more algorithms) but they are incompatible with OMAP4.
+- ti,hwmods: Name of the hwmod associated with the AES module
+- reg : Offset and length of the register set for the module
+- interrupts : the interrupt-specifier for the AES module.
+
+Optional properties:
+- dmas: DMA specifiers for tx and rx dma. See the DMA client binding,
+	Documentation/devicetree/bindings/dma/dma.txt
+- dma-names: DMA request names should include "tx" and "rx" if present.
+
+Example:
+	/* AM335x */
+	aes: aes@53500000 {
+		compatible = "ti,omap4-aes";
+		ti,hwmods = "aes";
+		reg = <0x53500000 0xa0>;
+		interrupts = <102>;
+		dmas = <&edma 6>,
+		       <&edma 5>;
+		dma-names = "tx", "rx";
+	};
diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts
index 8a9802e..94ee427 100644
--- a/arch/arm/boot/dts/am335x-bone.dts
+++ b/arch/arm/boot/dts/am335x-bone.dts
@@ -23,3 +23,7 @@
 &sham {
 	status = "okay";
 };
+
+&aes {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index d59e51c..86463fa 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -526,3 +526,7 @@
 &sham {
 	status = "okay";
 };
+
+&aes {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
index d45a330..f577e65 100644
--- a/arch/arm/boot/dts/am335x-evmsk.dts
+++ b/arch/arm/boot/dts/am335x-evmsk.dts
@@ -428,3 +428,7 @@
 &sham {
 	status = "okay";
 };
+
+&aes {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 299710b..2664da9 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -719,5 +719,15 @@
 			dmas = <&edma 36>;
 			dma-names = "rx";
 		};
+
+		aes: aes@53500000 {
+			compatible = "ti,omap4-aes";
+			ti,hwmods = "aes";
+			reg = <0x53500000 0xa0>;
+			interrupts = <102>;
+			dmas = <&edma 6>,
+			       <&edma 5>;
+			dma-names = "tx", "rx";
+		};
 	};
 };
-- 
1.8.1.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v3 3/3] ARM: dts: AM33XX: Fix AES interrupt number
  2013-10-05 19:04 [PATCH v3 0/3] AM33XX crypto DTS patches Joel Fernandes
  2013-10-05 19:04 ` [PATCH v3 1/3] ARM: dts: AM33XX: Add SHAM data and documentation Joel Fernandes
  2013-10-05 19:04 ` [PATCH v3 2/3] ARM: dts: AM33XX: Add AES " Joel Fernandes
@ 2013-10-05 19:04 ` Joel Fernandes
       [not found] ` <1380999877-20884-1-git-send-email-joelf-l0cyMroinI0@public.gmane.org>
  3 siblings, 0 replies; 5+ messages in thread
From: Joel Fernandes @ 2013-10-05 19:04 UTC (permalink / raw)
  To: Mark Rutland, Benoit Cousson
  Cc: Joel Fernandes, devicetree, Linux OMAP List,
	Linux Kernel Mailing List, Linux ARM Kernel List

AES interrupts were previously not used, but after recent changes to omap-aes
driver, its being used. We correct the interrupt number to have working PIO
mode.

Signed-off-by: Joel Fernandes <joelf@ti.com>
---
 arch/arm/boot/dts/am33xx.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 2664da9..5c2d6c1 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -724,7 +724,7 @@
 			compatible = "ti,omap4-aes";
 			ti,hwmods = "aes";
 			reg = <0x53500000 0xa0>;
-			interrupts = <102>;
+			interrupts = <103>;
 			dmas = <&edma 6>,
 			       <&edma 5>;
 			dma-names = "tx", "rx";
-- 
1.8.1.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 0/3] AM33XX crypto DTS patches
       [not found] ` <1380999877-20884-1-git-send-email-joelf-l0cyMroinI0@public.gmane.org>
@ 2013-10-08 15:51   ` Benoit Cousson
  0 siblings, 0 replies; 5+ messages in thread
From: Benoit Cousson @ 2013-10-08 15:51 UTC (permalink / raw)
  To: Joel Fernandes
  Cc: Mark Rutland, Linux OMAP List, Linux ARM Kernel List,
	Linux Kernel Mailing List, devicetree-u79uwXL29TY76Z2rM5mHXA

Hi Joel,

n 05/10/2013 21:04, Joel Fernandes wrote:
> These patches are some minor fixups and changes to commit messages to the
> AM33XX crypto (aes, sham) patches with reference to the comments at:
> http://comments.gmane.org/gmane.linux.drivers.devicetree/45961
>
> Joel Fernandes (1):
>    ARM: dts: AM33XX: Fix AES interrupt number
>
> Mark A. Greer (2):
>    ARM: dts: AM33XX: Add SHAM data and documentation
>    ARM: dts: AM33XX: Add AES data and documentation
>
>   .../devicetree/bindings/crypto/omap-aes.txt        | 31 ++++++++++++++++++++++
>   .../devicetree/bindings/crypto/omap-sham.txt       | 28 +++++++++++++++++++
>   arch/arm/boot/dts/am335x-bone.dts                  |  8 ++++++
>   arch/arm/boot/dts/am335x-evm.dts                   |  8 ++++++
>   arch/arm/boot/dts/am335x-evmsk.dts                 |  8 ++++++
>   arch/arm/boot/dts/am33xx.dtsi                      | 19 +++++++++++++
>   6 files changed, 102 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/crypto/omap-aes.txt
>   create mode 100644 Documentation/devicetree/bindings/crypto/omap-sham.txt
>

I've just applied this series and the remaining ones from the previous 
version.

Thanks,
Benoit

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-10-08 15:51 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-05 19:04 [PATCH v3 0/3] AM33XX crypto DTS patches Joel Fernandes
2013-10-05 19:04 ` [PATCH v3 1/3] ARM: dts: AM33XX: Add SHAM data and documentation Joel Fernandes
2013-10-05 19:04 ` [PATCH v3 2/3] ARM: dts: AM33XX: Add AES " Joel Fernandes
2013-10-05 19:04 ` [PATCH v3 3/3] ARM: dts: AM33XX: Fix AES interrupt number Joel Fernandes
     [not found] ` <1380999877-20884-1-git-send-email-joelf-l0cyMroinI0@public.gmane.org>
2013-10-08 15:51   ` [PATCH v3 0/3] AM33XX crypto DTS patches Benoit Cousson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).