From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [rtc-linux] [PATCH V5 2/3] pincntrl: add support for ams AS3722 pin control driver Date: Thu, 10 Oct 2013 14:55:32 +0530 Message-ID: <5256728C.6060802@nvidia.com> References: <1380729030-25896-1-git-send-email-ldewangan@nvidia.com> <1380729030-25896-3-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org To: Linus Walleij Cc: "rtc-linux@googlegroups.com" , Lee Jones , Samuel Ortiz , Mark Brown , Andrew Morton , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Rob Herring , Mark Rutland , Pawel Moll , Stephen Warren , Rob Landley , "ijc+devicetree@hellion.org.uk" , Grant Likely List-Id: devicetree@vger.kernel.org On Tuesday 08 October 2013 05:46 PM, Linus Walleij wrote: > On Wed, Oct 2, 2013 at 5:50 PM, Laxman Dewangan wrote: > >> The AS3722 is a compact system PMU suitable for mobile phones, tablets etc. >> >> Add a driver to support accessing the GPIO, pinmux and pin configuration >> of 8 GPIO pins found on the ams AS3722 through pin control driver and >> gpiolib. >> >> The driver will register itself as the pincontrol driver and gpio driver. >> >> Signed-off-by: Laxman Dewangan >> --- >> Changes from V1: >> - Nit cleanups in driver and use module_platform_driver. >> >> Changes from V2: >> - Move the gpio driver from gpio folder to pinctnrl driver and register >> driver as pincontrol driver. >> - Provide pin configuration through pincntrl framework. >> >> Changes from V3: >> - Added gpio ranges and pinctrl_gpio calls. >> - Used pinctrl_gpio_* calls on gpio chips callback. >> - Remove dummy function which just return not supported. >> - Nit cleanups. >> >> Changes from V4: >> - Drop separate DT binding document as it is moved to mfd/as3722.txt. > As mentioned I am happy with this driver, > Acked-by: Linus Walleij > > When you agreed with the DT folks and want me to merge it, > tell me. > Stephen has given the ACK from DT side, so I think you can merge this patch. Thanks, Laxman