[PATCH v6] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid*

[PATCH v6] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid*

[Kishon Vijay Abraham I]

The Palmas device contains only a USB VBUS-ID detector, so added a
compatible type *ti,palmas-usb-vid*. Didn't remove the existing compatible
types for backward compatibility.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
Changes from v5:
* Fixed documentation

Changes from v4:
* added compatible property "ti,twl6035-usb-vid"

Changes from v3:
* Fixed commit log message (VID to VBUS-ID).
* Fixed the Documentation to tell "ti,twl6035-usb" and "ti,palmas-usb" is
deprecated
Changes from [1]:
* Since the old compatible values will be in 3.11 kernel, we shouldn't remove
the old compatible values. So retain the old compatible values.

[1] -> http://www.spinics.net/lists/linux-omap/msg95843.html
 Documentation/devicetree/bindings/extcon/extcon-palmas.txt |    6 +++++-
 drivers/extcon/extcon-palmas.c                             |    2 ++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/extcon/extcon-palmas.txt b/Documentation/devicetree/bindings/extcon/extcon-palmas.txt
index 7dab6a8..45414bb 100644
--- a/Documentation/devicetree/bindings/extcon/extcon-palmas.txt
+++ b/Documentation/devicetree/bindings/extcon/extcon-palmas.txt
@@ -2,7 +2,11 @@ EXTCON FOR PALMAS/TWL CHIPS
 
 PALMAS USB COMPARATOR
 Required Properties:
- - compatible : Should be "ti,palmas-usb" or "ti,twl6035-usb"
+ - compatible: should contain one of:
+   * "ti,palmas-usb-vid".
+   * "ti,twl6035-usb-vid".
+   * "ti,palmas-usb" (DEPRECATED - use "ti,palmas-usb-vid").
+   * "ti,twl6035-usb" (DEPRECATED - use "ti,twl6035-usb-vid").
 
 Optional Properties:
  - ti,wakeup : To enable the wakeup comparator in probe
diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
index 6c91976..6e83e9a 100644
--- a/drivers/extcon/extcon-palmas.c
+++ b/drivers/extcon/extcon-palmas.c
@@ -269,7 +269,9 @@ static const struct dev_pm_ops palmas_pm_ops = {
 
 static struct of_device_id of_palmas_match_tbl[] = {
 	{ .compatible = "ti,palmas-usb", },
+	{ .compatible = "ti,palmas-usb-vid", },
 	{ .compatible = "ti,twl6035-usb", },
+	{ .compatible = "ti,twl6035-usb-vid", },
 	{ /* end */ }
 };
 
-- 
1.7.10.4

Re: [PATCH v6] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid*

[Laxman Dewangan]

On Thursday 10 October 2013 06:07 PM, Kishon Vijay Abraham I wrote:
> The Palmas device contains only a USB VBUS-ID detector, so added a
> compatible type *ti,palmas-usb-vid*. Didn't remove the existing compatible
> types for backward compatibility.
>
I dont have much issue on this nomenclature but just second thought:

The Palmas USB module is capable of detection VBUS, ID-GND, ID-RA, 
ID-RB, ID-RC and ID-FLOAT as per BC1.2.
This sub-module only detect the cable, does nothing more than this.
In this case, should we say "ti,palmas-usb-extcon"?
Again extcon is linux specific terminology and this can be defer.

Re: [PATCH v6] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid*

[Kishon Vijay Abraham I]

On Thursday 10 October 2013 06:41 PM, Laxman Dewangan wrote:
> On Thursday 10 October 2013 06:07 PM, Kishon Vijay Abraham I wrote:
>> The Palmas device contains only a USB VBUS-ID detector, so added a
>> compatible type *ti,palmas-usb-vid*. Didn't remove the existing compatible
>> types for backward compatibility.
>>
> I dont have much issue on this nomenclature but just second thought:
> 
> The Palmas USB module is capable of detection VBUS, ID-GND, ID-RA, ID-RB, ID-RC
> and ID-FLOAT as per BC1.2.
> This sub-module only detect the cable, does nothing more than this.
> In this case, should we say "ti,palmas-usb-extcon"?
> Again extcon is linux specific terminology and this can be defer.

I don't mind either way. Chanwoo?

-Kishon

Re: [PATCH v6] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid*

[Chanwoo Choi]

On 10/11/2013 03:15 PM, Kishon Vijay Abraham I wrote:
> On Thursday 10 October 2013 06:41 PM, Laxman Dewangan wrote:
>> On Thursday 10 October 2013 06:07 PM, Kishon Vijay Abraham I wrote:
>>> The Palmas device contains only a USB VBUS-ID detector, so added a
>>> compatible type *ti,palmas-usb-vid*. Didn't remove the existing compatible
>>> types for backward compatibility.
>>>
>> I dont have much issue on this nomenclature but just second thought:
>>
>> The Palmas USB module is capable of detection VBUS, ID-GND, ID-RA, ID-RB, ID-RC
>> and ID-FLOAT as per BC1.2.
>> This sub-module only detect the cable, does nothing more than this.
>> In this case, should we say "ti,palmas-usb-extcon"?
>> Again extcon is linux specific terminology and this can be defer.
> 
> I don't mind either way. Chanwoo?

The EXTCON is subsystem name. I don't prefer to use 'extcon' word on device name.
I agree Kishon opinion.

Re: [PATCH v6] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid*

[Kishon Vijay Abraham I]

Hi Chanwoo,

On Friday 11 October 2013 12:36 PM, Chanwoo Choi wrote:
> On 10/11/2013 03:15 PM, Kishon Vijay Abraham I wrote:
>> On Thursday 10 October 2013 06:41 PM, Laxman Dewangan wrote:
>>> On Thursday 10 October 2013 06:07 PM, Kishon Vijay Abraham I wrote:
>>>> The Palmas device contains only a USB VBUS-ID detector, so added a
>>>> compatible type *ti,palmas-usb-vid*. Didn't remove the existing compatible
>>>> types for backward compatibility.
>>>>
>>> I dont have much issue on this nomenclature but just second thought:
>>>
>>> The Palmas USB module is capable of detection VBUS, ID-GND, ID-RA, ID-RB, ID-RC
>>> and ID-FLOAT as per BC1.2.
>>> This sub-module only detect the cable, does nothing more than this.
>>> In this case, should we say "ti,palmas-usb-extcon"?
>>> Again extcon is linux specific terminology and this can be defer.
>>
>> I don't mind either way. Chanwoo?
> 
> The EXTCON is subsystem name. I don't prefer to use 'extcon' word on device name.
> I agree Kishon opinion.

Cool.. can you this patch as-is?

Thanks
Kishon

Re: [PATCH v6] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid*

[Chanwoo Choi]

On 10/11/2013 04:52 PM, Kishon Vijay Abraham I wrote:
> Hi Chanwoo,
> 
> On Friday 11 October 2013 12:36 PM, Chanwoo Choi wrote:
>> On 10/11/2013 03:15 PM, Kishon Vijay Abraham I wrote:
>>> On Thursday 10 October 2013 06:41 PM, Laxman Dewangan wrote:
>>>> On Thursday 10 October 2013 06:07 PM, Kishon Vijay Abraham I wrote:
>>>>> The Palmas device contains only a USB VBUS-ID detector, so added a
>>>>> compatible type *ti,palmas-usb-vid*. Didn't remove the existing compatible
>>>>> types for backward compatibility.
>>>>>
>>>> I dont have much issue on this nomenclature but just second thought:
>>>>
>>>> The Palmas USB module is capable of detection VBUS, ID-GND, ID-RA, ID-RB, ID-RC
>>>> and ID-FLOAT as per BC1.2.
>>>> This sub-module only detect the cable, does nothing more than this.
>>>> In this case, should we say "ti,palmas-usb-extcon"?
>>>> Again extcon is linux specific terminology and this can be defer.
>>>
>>> I don't mind either way. Chanwoo?
>>
>> The EXTCON is subsystem name. I don't prefer to use 'extcon' word on device name.
>> I agree Kishon opinion.
> 
> Cool.. can you this patch as-is?
> 

OK, applied it.

Thanks,
Chanwoo Choi

Re: [PATCH v6] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid*

[Kishon Vijay Abraham I]

On Friday 11 October 2013 01:53 PM, Chanwoo Choi wrote:
> On 10/11/2013 04:52 PM, Kishon Vijay Abraham I wrote:
>> Hi Chanwoo,
>>
>> On Friday 11 October 2013 12:36 PM, Chanwoo Choi wrote:
>>> On 10/11/2013 03:15 PM, Kishon Vijay Abraham I wrote:
>>>> On Thursday 10 October 2013 06:41 PM, Laxman Dewangan wrote:
>>>>> On Thursday 10 October 2013 06:07 PM, Kishon Vijay Abraham I wrote:
>>>>>> The Palmas device contains only a USB VBUS-ID detector, so added a
>>>>>> compatible type *ti,palmas-usb-vid*. Didn't remove the existing compatible
>>>>>> types for backward compatibility.
>>>>>>
>>>>> I dont have much issue on this nomenclature but just second thought:
>>>>>
>>>>> The Palmas USB module is capable of detection VBUS, ID-GND, ID-RA, ID-RB, ID-RC
>>>>> and ID-FLOAT as per BC1.2.
>>>>> This sub-module only detect the cable, does nothing more than this.
>>>>> In this case, should we say "ti,palmas-usb-extcon"?
>>>>> Again extcon is linux specific terminology and this can be defer.
>>>>
>>>> I don't mind either way. Chanwoo?
>>>
>>> The EXTCON is subsystem name. I don't prefer to use 'extcon' word on device name.
>>> I agree Kishon opinion.
>>
>> Cool.. can you this patch as-is?
>>
> 
> OK, applied it.

Thanks :-)

-Kishon