From: Kishon Vijay Abraham I <kishon@ti.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"rob@landley.net" <rob@landley.net>,
"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
"gg@slimlogic.co.uk" <gg@slimlogic.co.uk>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH v6] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid*
Date: Fri, 11 Oct 2013 13:22:35 +0530 [thread overview]
Message-ID: <5257AE43.4020902@ti.com> (raw)
In-Reply-To: <5257A36D.80902@samsung.com>
Hi Chanwoo,
On Friday 11 October 2013 12:36 PM, Chanwoo Choi wrote:
> On 10/11/2013 03:15 PM, Kishon Vijay Abraham I wrote:
>> On Thursday 10 October 2013 06:41 PM, Laxman Dewangan wrote:
>>> On Thursday 10 October 2013 06:07 PM, Kishon Vijay Abraham I wrote:
>>>> The Palmas device contains only a USB VBUS-ID detector, so added a
>>>> compatible type *ti,palmas-usb-vid*. Didn't remove the existing compatible
>>>> types for backward compatibility.
>>>>
>>> I dont have much issue on this nomenclature but just second thought:
>>>
>>> The Palmas USB module is capable of detection VBUS, ID-GND, ID-RA, ID-RB, ID-RC
>>> and ID-FLOAT as per BC1.2.
>>> This sub-module only detect the cable, does nothing more than this.
>>> In this case, should we say "ti,palmas-usb-extcon"?
>>> Again extcon is linux specific terminology and this can be defer.
>>
>> I don't mind either way. Chanwoo?
>
> The EXTCON is subsystem name. I don't prefer to use 'extcon' word on device name.
> I agree Kishon opinion.
Cool.. can you this patch as-is?
Thanks
Kishon
next prev parent reply other threads:[~2013-10-11 7:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 12:37 [PATCH v6] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid* Kishon Vijay Abraham I
2013-10-10 13:11 ` Laxman Dewangan
2013-10-11 6:15 ` Kishon Vijay Abraham I
2013-10-11 7:06 ` Chanwoo Choi
2013-10-11 7:52 ` Kishon Vijay Abraham I [this message]
2013-10-11 8:23 ` Chanwoo Choi
2013-10-11 8:25 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5257AE43.4020902@ti.com \
--to=kishon@ti.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gg@slimlogic.co.uk \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ldewangan@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).