From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH v6] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid* Date: Fri, 11 Oct 2013 13:55:41 +0530 Message-ID: <5257B605.2000608@ti.com> References: <1381408647-24653-1-git-send-email-kishon@ti.com> <5256A773.6060807@nvidia.com> <5257977C.1030108@ti.com> <5257A36D.80902@samsung.com> <5257AE43.4020902@ti.com> <5257B576.3060800@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5257B576.3060800@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Chanwoo Choi Cc: Laxman Dewangan , "rob.herring@calxeda.com" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "swarren@wwwdotorg.org" , "ijc+devicetree@hellion.org.uk" , "rob@landley.net" , "myungjoo.ham@samsung.com" , "gg@slimlogic.co.uk" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Stephen Warren List-Id: devicetree@vger.kernel.org On Friday 11 October 2013 01:53 PM, Chanwoo Choi wrote: > On 10/11/2013 04:52 PM, Kishon Vijay Abraham I wrote: >> Hi Chanwoo, >> >> On Friday 11 October 2013 12:36 PM, Chanwoo Choi wrote: >>> On 10/11/2013 03:15 PM, Kishon Vijay Abraham I wrote: >>>> On Thursday 10 October 2013 06:41 PM, Laxman Dewangan wrote: >>>>> On Thursday 10 October 2013 06:07 PM, Kishon Vijay Abraham I wrote: >>>>>> The Palmas device contains only a USB VBUS-ID detector, so added a >>>>>> compatible type *ti,palmas-usb-vid*. Didn't remove the existing compatible >>>>>> types for backward compatibility. >>>>>> >>>>> I dont have much issue on this nomenclature but just second thought: >>>>> >>>>> The Palmas USB module is capable of detection VBUS, ID-GND, ID-RA, ID-RB, ID-RC >>>>> and ID-FLOAT as per BC1.2. >>>>> This sub-module only detect the cable, does nothing more than this. >>>>> In this case, should we say "ti,palmas-usb-extcon"? >>>>> Again extcon is linux specific terminology and this can be defer. >>>> >>>> I don't mind either way. Chanwoo? >>> >>> The EXTCON is subsystem name. I don't prefer to use 'extcon' word on device name. >>> I agree Kishon opinion. >> >> Cool.. can you this patch as-is? >> > > OK, applied it. Thanks :-) -Kishon