From: Rajendra Nayak <rnayak@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: Rob Landley <rob@landley.net>, Mark Brown <broonie@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: dts: Fix bindings description of regulator-boot-on
Date: Fri, 11 Oct 2013 16:03:48 +0530 [thread overview]
Message-ID: <5257D40C.3060501@ti.com> (raw)
In-Reply-To: <1381487207-18298-1-git-send-email-nm@ti.com>
On Friday 11 October 2013 03:56 PM, Nishanth Menon wrote:
> Since regulator-boot-on property maps back to constraints->boot_on,
> current description of 'regulator-boot-on' property conflicts with
> description of 'boot-on' in include/linux/regulator/machine.h and the
> corresponding implementation in drivers/regulator/core.c.
>
> Ensure the description is more inline with the original intent.
>
> Cc: Rajendra Nayak <rnayak@ti.com>
>
> Reported-by: Kishon Vijay Abraham I <kishon@ti.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>
> Ref: my confusion in http://marc.info/?t=138140228800004&r=1&w=2
> Based on v3.12-rc4 tag
>
> .../devicetree/bindings/regulator/regulator.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt
> index 2bd8f09..d999f096 100644
> --- a/Documentation/devicetree/bindings/regulator/regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/regulator.txt
> @@ -8,7 +8,9 @@ Optional properties:
> - regulator-min-microamp: smallest current consumers may set
> - regulator-max-microamp: largest current consumers may set
> - regulator-always-on: boolean, regulator should never be disabled
> -- regulator-boot-on: bootloader/firmware enabled regulator
> +- regulator-boot-on: regulator is enabled when the system is initially started.
> + If the regulator is not enabled by the hardware or bootloader then it will be
> + enabled when the constraints are applied.
Isn't this specific to how the linux regulator framework implements it?
why should it be documented in the generic bindings documentation which has
nothing Linux specific but more hardware details?
> - regulator-allow-bypass: allow the regulator to go into bypass mode
> - <name>-supply: phandle to the parent supply/regulator node
> - regulator-ramp-delay: ramp delay for regulator(in uV/uS)
>
next prev parent reply other threads:[~2013-10-11 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 10:26 [PATCH] regulator: dts: Fix bindings description of regulator-boot-on Nishanth Menon
2013-10-11 10:33 ` Rajendra Nayak [this message]
2013-10-11 10:46 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5257D40C.3060501@ti.com \
--to=rnayak@ti.com \
--cc=broonie@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).