From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rhyland Klein <rklein@nvidia.com>
Subject: Re: [Patch V5] drivers: power: Add support for bq24735 charger
Date: Mon, 14 Oct 2013 14:26:50 -0400
Message-ID: <525C376A.3000009@nvidia.com>
References: <1381526143-20800-1-git-send-email-rklein@nvidia.com> <525C361C.1020703@wwwdotorg.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <525C361C.1020703@wwwdotorg.org>
Sender: linux-kernel-owner@vger.kernel.org
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Anton Vorontsov <anton@enomsg.org>, David Woodhouse <dwmw2@infradead.org>, Thierry Reding <thierry.reding@gmail.com>, Darbha Sriharsha <dsriharsha@nvidia.com>, Manish Badarkha <badarkhe.manish@gmail.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Mark Rutland <Mark.Rutland@arm.com>, Pawel Moll <pawel.moll@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>
List-Id: devicetree@vger.kernel.org

On 10/14/2013 2:21 PM, Stephen Warren wrote:
> On 10/11/2013 03:15 PM, Rhyland Klein wrote:
>> From: Darbha Sriharsha <dsriharsha@nvidia.com>
>>
>> Adds support for the bq24735 charger chipset. The bq24735 is a
>> high-efficiency, synchronous battery charger.
>>
>> It allows control of the charging current, input current, and the charger
>> voltage DAC's through SMBus.
> 
> Please CC the DT bindings maintainers on patches that add DT bindings.

Oops, sorry, will do in the future.

> 
>> diff --git a/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt b/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt
> 
>> +Optional properties :
> 
>> + - ti,ac-detect-gpios : This GPIO is optionally used to read the AC adapter
>> +   presence.
> 
> Is that actually a property of the BQ24735 chip itself (i.e. is it an
> output signal from the chip), or part of the board/system?

The gpio itself is actually what the IRQ line is tied to from the
bq24735 -> tegra (in this case). In other words this is a Host GPIO that
is configured as an input and connected to the bq24735.

-rhyland

> 
> Aside from that, the binding looks reasonable to me (although I'm no
> longer a DT bindings maintainer).
> 


-- 
nvpublic