Re: [PATCH v3 03/19] clk: tegra: common periph_clk_enb_refcnt and clks

[Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>]

On 10/15/2013 08:52 AM, Peter De Schrijver wrote:
> This patch makes periph_clk_enb_refcnt a global array, dynamically allocated
> at boottime. It simplifies the macros somewhat and allows clocks common to
> several Tegra SoCs to be defined in a separate files. Also the clks array
> becomes global and dynamically allocated which allows the DT registration to
> be moved to a generic funcion.

> diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c

> +struct clk ** __init tegra_clk_init(int num, int banks)
>  {
> +	if (banks > ARRAY_SIZE(periph_regs)) {
> +		WARN_ON(1);

I think that can just be:

	if (WARN_ON(banks > ARRAY_SIZE(periph_regs))) {

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html