From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v3 19/19] clk: tegra30: move to common tegra clk infra Date: Tue, 15 Oct 2013 13:43:03 -0600 Message-ID: <525D9AC7.5040800@wwwdotorg.org> References: <1381848794-11761-1-git-send-email-pdeschrijver@nvidia.com> <1381848794-11761-20-git-send-email-pdeschrijver@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1381848794-11761-20-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter De Schrijver Cc: Prashant Gaikwad , Mike Turquette , Thierry Reding , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Hiroshi Doyu , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 10/15/2013 08:53 AM, Peter De Schrijver wrote: > Move tegra30 to the common tegra clks. Nit: Tegra30 not tegra30. Perhaps the same applies elsewhere? > diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c > +static struct tegra_clk tegra30_clks[tegra_clk_max] __initdata = { > + [tegra_clk_clk_32k] = { .dt_id = TEGRA30_CLK_CLK_32K, .present = true }, ... > + [tegra_clk_pll_a_out0] = { .dt_id = TEGRA30_CLK_PLL_A_OUT0, .present = true }, > > -static unsigned int tegra30_get_pll_ref_div(void) ... > -} > +}; Nit: There's an extra blank line at the end of that table, which makes the diff look a little odd.