From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v3 08/19] clk: tegra: add common infra for DT clocks Date: Wed, 16 Oct 2013 11:02:20 -0600 Message-ID: <525EC69C.5040004@wwwdotorg.org> References: <1381848794-11761-1-git-send-email-pdeschrijver@nvidia.com> <1381848794-11761-9-git-send-email-pdeschrijver@nvidia.com> <525D9117.9050009@wwwdotorg.org> <20131016143448.GK5643@tbergstrom-lnx.Nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131016143448.GK5643-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter De Schrijver Cc: Prashant Gaikwad , Mike Turquette , Thierry Reding , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Hiroshi Doyu , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On 10/16/2013 08:34 AM, Peter De Schrijver wrote: > On Tue, Oct 15, 2013 at 09:01:43PM +0200, Stephen Warren wrote: >> On 10/15/2013 08:52 AM, Peter De Schrijver wrote: >>> Introduce a common infrastructure for sharing clock initialization between >>> SoCs. >> >>> diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c >> >>> +struct clk ** __init tegra_lookup_dt_id(int clk_id, >>> + struct tegra_clk *tegra_clk) >>> +{ >>> + if (tegra_clk[clk_id].present) >>> + return &clks[tegra_clk[clk_id].dt_id]; >>> + else >>> + return NULL; >> >> Does this need range-checking? Or do we assume that since this is an >> internal function, "clk_id" will never be out-of-range? > > That was my assumption indeed. I could add a range check if you think that's > useful. It's probably OK if it's a purely internal function; I just wanted to double-check.