From: Rob Herring <rob.herring@calxeda.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Tejun Heo <tj@kernel.org>, Grant Likely <grant.likely@linaro.org>,
linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] sata, highbank: clear whole array in highbank_initialize_phys()
Date: Fri, 18 Oct 2013 09:21:27 -0500 [thread overview]
Message-ID: <526143E7.4070809@calxeda.com> (raw)
In-Reply-To: <20131018084409.GA14256@longonot.mountain>
On 10/18/2013 03:44 AM, Dan Carpenter wrote:
> The original code used the wrong parameter to clear tx_atten[]. It
> passed the number of elements instead of sizeof() the array to memset.
>
> The other potential issue was that cphy_base[] wasn't cleared. I'm not
> sure if that was a real problem or not, but I have cleared it in my
> patch.
>
> Instead of using memset(), this patch uses empty initializers as a
> cleanup.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Rob Herring <rob.herring@calxeda.com>
> ---
> v2: used {} initialization instead of memset. I also just went ahead
> and cleared cphy_base[].
>
> diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c
> index 7f5e5d9..ea3b3dc 100644
> --- a/drivers/ata/sata_highbank.c
> +++ b/drivers/ata/sata_highbank.c
> @@ -343,13 +343,11 @@ static int highbank_initialize_phys(struct device *dev, void __iomem *addr)
> {
> struct device_node *sata_node = dev->of_node;
> int phy_count = 0, phy, port = 0, i;
> - void __iomem *cphy_base[CPHY_PHY_COUNT];
> - struct device_node *phy_nodes[CPHY_PHY_COUNT];
> - u32 tx_atten[CPHY_PORT_COUNT];
> + void __iomem *cphy_base[CPHY_PHY_COUNT] = {};
> + struct device_node *phy_nodes[CPHY_PHY_COUNT] = {};
> + u32 tx_atten[CPHY_PORT_COUNT] = {};
>
> memset(port_data, 0, sizeof(struct phy_lane_info) * CPHY_PORT_COUNT);
> - memset(phy_nodes, 0, sizeof(struct device_node*) * CPHY_PHY_COUNT);
> - memset(tx_atten, 0xff, CPHY_PORT_COUNT);
>
> do {
> u32 tmp;
>
next prev parent reply other threads:[~2013-10-18 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 8:44 [patch v2] sata, highbank: clear whole array in highbank_initialize_phys() Dan Carpenter
2013-10-18 14:21 ` Rob Herring [this message]
2013-10-27 12:16 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526143E7.4070809@calxeda.com \
--to=rob.herring@calxeda.com \
--cc=dan.carpenter@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).