From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30B961BBBE3; Tue, 6 Aug 2024 06:28:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722925700; cv=none; b=gdoDT8Im68UDHEgI8qPSc70M5cWqbSswp+N4AOEAaSM1kkGhOKxpWA+xfoH4RIv9G02SrBtGxAQ5blTq0EwTGmPHhQlMyeKij1S7oeY+jErYdgNjZFAgxWxuPW4vC6WVZ/Hg7yC7JpguzJQykrqvaHN+UZfPCv2aYNCbjsyug3Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722925700; c=relaxed/simple; bh=gNVQut/eovNimtqZ58cW8+a0beL8r/Hyq0rfePPCV8Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hP9yrByI6lu/jU7KyJiNLPKufdbCP/aSLsZ85kApu8TUFHpI6srkW84TsFbJKjcF7ji47B5g3ui3WBSDx+bi1VpTM+W525xB/uo+a4t+CC3YiyP+2MnOgk/geB+TnEbo4fdOIN86S8bIBBzUHU/oghp47S4lpuTG2Kofjm0Bm/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KzSJdy9F; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KzSJdy9F" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DED59C32786; Tue, 6 Aug 2024 06:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722925699; bh=gNVQut/eovNimtqZ58cW8+a0beL8r/Hyq0rfePPCV8Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KzSJdy9F8Rc9JIKX3jlnyPQxNoJCDznfxoXO/p6NfnsYLb1pFLoTZwL8hGdOOosU5 9ghH7NHDJLVulUkD053uE3R/xaYLTltKRhbfepzpXtw5E+9s+m0udaaI4gFo8bt59/ gT7e3xgjlWHL6b4QLuJYDxiNC5TYTduzRJmjjLRdcw3ZKEEquIKPEO8aKKNNoEYGqn tgphMT6BXUIludZk5oRVvFnTZVvorUub+NzmJFdrTGu91vpzvI8g0RZemCJGMZD3mN WqIH5txL2vlD12hE6tP3ktc5o4Fy/i4sFjRJkofJdcaZeP9E3wsmfjWcj/Xj8LyEkw afnMds3uwOzHQ== Message-ID: <52625d50-b928-40ce-879c-8e58da48d567@kernel.org> Date: Tue, 6 Aug 2024 08:28:12 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6] arm64: dts: ti: k3-pinctrl: Add WKUP_EN flag To: Markus Schneider-Pargmann , Nishanth Menon Cc: Tero Kristo , Santosh Shilimkar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vignesh Raghavendra , Vibhore Vardhan , Kevin Hilman , Dhruva Gole , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240729080101.3859701-1-msp@baylibre.com> <20240729080101.3859701-4-msp@baylibre.com> <20240730120958.inq73rx6dfmwh6vz@hemstitch> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 30/07/2024 14:32, Markus Schneider-Pargmann wrote: > Hi Nishanth, > > On Tue, Jul 30, 2024 at 07:09:58AM GMT, Nishanth Menon wrote: >> On 10:00-20240729, Markus Schneider-Pargmann wrote: >>> WKUP_EN is a flag to enable pin wakeup. Any activity will wakeup the SoC >>> in that case. >>> >>> Signed-off-by: Markus Schneider-Pargmann >>> --- >>> arch/arm64/boot/dts/ti/k3-pinctrl.h | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-pinctrl.h b/arch/arm64/boot/dts/ti/k3-pinctrl.h >>> index 22b8d73cfd32..dd4d53e8420a 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-pinctrl.h >>> +++ b/arch/arm64/boot/dts/ti/k3-pinctrl.h >>> @@ -12,6 +12,7 @@ >>> #define PULLTYPESEL_SHIFT (17) >>> #define RXACTIVE_SHIFT (18) >>> #define DEBOUNCE_SHIFT (11) >>> +#define WKUP_EN_SHIFT (29) >>> >>> #define PULL_DISABLE (1 << PULLUDEN_SHIFT) >>> #define PULL_ENABLE (0 << PULLUDEN_SHIFT) >>> @@ -38,6 +39,8 @@ >>> #define PIN_DEBOUNCE_CONF5 (5 << DEBOUNCE_SHIFT) >>> #define PIN_DEBOUNCE_CONF6 (6 << DEBOUNCE_SHIFT) >>> >>> +#define WKUP_EN (1 << WKUP_EN_SHIFT) >>> + >> >> Are we using this? > > Yes, this needs to be used in pinctrl for the relevant pins. The users > are not part of this series, as it will probably be in devicetree > overlays or maybe future board files. You cannot add some code without users claiming that "someone, someday might need it". It's just dead code. Best regards, Krzysztof