From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"rob@landley.net" <rob@landley.net>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
Florian Lobmaier <florian.lobmaier@ams.com>
Subject: Re: [PATCH V5 3/3] drivers/rtc/rtc-as3722: add RTC driver
Date: Mon, 21 Oct 2013 16:44:58 +0530 [thread overview]
Message-ID: <52650CB2.9030409@nvidia.com> (raw)
In-Reply-To: <20131010224748.GW21581@sirena.org.uk>
On Friday 11 October 2013 04:17 AM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Thu, Oct 10, 2013 at 03:24:46PM -0700, Andrew Morton wrote:
>
>>> +#ifdef CONFIG_PM
>> Most (but not all!) rtc drivers use CONFIG_PM_SLEEP. People have madly
>> mucked with CONFIG_PM* and I don't know the difference and I don't know
>> what's going on and I don't know of a convenient place to go to find
>> out. If you work it out, please be sure to tell me! But as soon as I
>> figure it out I'm sure they'll go and madly muck with it again.
> The two effective options for this stuff are PM_SLEEP (for system
> suspend) and PM_RUNTIME (for runtime suspend which RTCs are unlikely to
> use I guess). PM mostly just enables selection of the other two.
I think, correct defs is CONFIG_PM_SLEEP here. I will re-spin this patch.
prev parent reply other threads:[~2013-10-21 11:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 12:29 [PATCH V5 0/3] Add AMS AS3722 mfd, pincontrol and RTC driver Laxman Dewangan
2013-10-09 12:29 ` [PATCH V5 1/3] mfd: add support for ams AS3722 PMIC Laxman Dewangan
2013-10-09 16:13 ` Stephen Warren
2013-10-21 11:18 ` Laxman Dewangan
2013-10-22 6:58 ` Lee Jones
2013-10-09 12:29 ` [PATCH V5 2/3] pincntrl: add support for ams AS3722 pin control driver Laxman Dewangan
2013-10-09 12:29 ` [PATCH V5 3/3] drivers/rtc/rtc-as3722: add RTC driver Laxman Dewangan
2013-10-10 22:24 ` Andrew Morton
2013-10-10 22:47 ` Mark Brown
2013-10-11 8:08 ` [rtc-linux] " Linus Walleij
2013-10-21 11:14 ` Laxman Dewangan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52650CB2.9030409@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.lobmaier@ams.com \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).