From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [RESEND PATCHv2] watchdog: dw: Enable OF support for DW watchdog timer. Date: Mon, 21 Oct 2013 17:41:20 -0700 Message-ID: <5265C9B0.2060003@roeck-us.net> References: <1380739472-26172-1-git-send-email-dinguyen@altera.com> <20131021110532.GA8144@kartoffel> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131021110532.GA8144@kartoffel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Rutland , "dinguyen-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org" Cc: "dinh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , Jamie Iles , Viresh Kumar , Wim Van Sebroeck , Pavel Machek , "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" , Pawel Moll , Stephen Warren , Ian Campbell , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On 10/21/2013 04:05 AM, Mark Rutland wrote: > On Wed, Oct 02, 2013 at 07:44:32PM +0100, dinguyen-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org wrote: >> From: Dinh Nguyen >> >> Add device tree support to the DW watchdog timer. >> >> Signed-off-by: Dinh Nguyen >> Acked-by: Jamie Iles >> Reviewed-by: Pavel Machek >> Cc: Guenter Roeck >> Cc: Jamie Iles >> Cc: Viresh Kumar >> Cc: Wim Van Sebroeck >> Cc: Pavel Machek >> Cc: Rob Herring >> Cc: Pawel Moll >> Cc: Mark Rutland >> Cc: Stephen Warren >> Cc: Ian Campbell >> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> Cc: linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> --- >> v2: >> - Use of_match_ptr() for of_match_table >> --- >> .../devicetree/bindings/watchdog/dw_wdt.txt | 16 ++++++++++++++++ >> drivers/watchdog/dw_wdt.c | 8 ++++++++ >> 2 files changed, 24 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/watchdog/dw_wdt.txt >> >> diff --git a/Documentation/devicetree/bindings/watchdog/dw_wdt.txt b/Documentation/devicetree/bindings/watchdog/dw_wdt.txt >> new file mode 100644 >> index 0000000..29e150b >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/watchdog/dw_wdt.txt >> @@ -0,0 +1,16 @@ >> +Synopsys Designware Watchdog Timer >> + >> +Required Properties: >> + >> +- Compatiblity : "snps,dw-wdt" > > This should presumably be: > > - compatbile: should contain "snps,dw-wdt" > Hi Mark, s/compatbile/compatible/ :-) "must be" or "should contain" ? I see both in various bindings. Is there a preference ? >> +- reg : Base address of the watchdog timer register. > > And the size... > >> + >> +Example: >> + >> + watchdog0: wd@ffd02000 { >> + compatible = "snps,dw-wdt"; >> + reg = <0xffd02000 0x1000>; >> + interrupts = <0 171 4>; > > This wasn't mentioned. > > Is it necessary? > From looking into the code ... The driver doesn't use interrupts, so I guess the answer is no. Cut-and-paste error, maybe ? > Is it the only interrupt? > >> + clocks = <&per_base_clk>; > > Similarly, is this the only clock? > The driver uses one clock, and it is mandatory. Guenter > Is it necessary? > >> + status = "okay"; > > This is unnecessary. > > Thanks, > Mark. > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html