From: Timur Tabi <timur@tabi.org>
To: Nicolin Chen <b42378@freescale.com>,
shawn.guo@linaro.org, broonie@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
dmaengine@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
alsa-devel@alsa-project.org, rob.herring@calxeda.com,
mark.rutland@arm.com, swarren@wwwdotorg.org, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, s.hauer@pengutronix.de,
b32955@freescale.com
Subject: Re: [PATCH 2/3] ASoC: fsl_ssi: Add dual fifo mode support
Date: Tue, 29 Oct 2013 07:42:41 -0500 [thread overview]
Message-ID: <526FAD41.2000805@tabi.org> (raw)
In-Reply-To: <02f8867363ed3038a0a70703856e4b642fef4339.1383047327.git.b42378@freescale.com>
Nicolin Chen wrote:
> By enabling dual fifo mode, it would allow SSI enter a better performance
> to transimit/receive data without occasional hardware underrun/overrun.
Have you measured any real performance gain with this patch? I
considered adding dual-FIFO support when I originally wrote this driver,
but it didn't appear to have any real benefit, but it used twice as many
DMA channels.
I'm concerned that this is another patch that just enables a useless
feature.
next prev parent reply other threads:[~2013-10-29 12:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 12:33 [PATCH 0/3] Add dual-fifo mode support of i.MX ssi Nicolin Chen
2013-10-29 12:33 ` [PATCH 1/3] dma: imx-sdma: Add ssi dual fifo script support Nicolin Chen
2013-10-29 13:51 ` Sascha Hauer
2013-10-30 4:48 ` Nicolin Chen
2013-10-29 17:21 ` Kumar Gala
2013-10-29 12:33 ` [PATCH 2/3] ASoC: fsl_ssi: Add dual fifo mode support Nicolin Chen
2013-10-29 12:42 ` Timur Tabi [this message]
2013-10-29 12:53 ` Chen Guangyu-B42378
2013-10-29 13:00 ` Timur Tabi
2013-10-29 13:03 ` Chen Guangyu-B42378
[not found] ` <cover.1383047327.git.b42378-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-10-29 12:33 ` [PATCH 3/3] ARM: dts: imx: use dual-fifo sdma script for ssi Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526FAD41.2000805@tabi.org \
--to=timur@tabi.org \
--cc=alsa-devel@alsa-project.org \
--cc=b32955@freescale.com \
--cc=b42378@freescale.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).