From: "Philippe Rétornaz" <philippe.retornaz@gmail.com>
To: Nicolin Chen <b42378@freescale.com>
Cc: s.hauer@pengutronix.de, timur@tabi.org, shawn.guo@linaro.org,
broonie@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
pawel.moll@arm.com, linux-doc@vger.kernel.org,
swarren@wwwdotorg.org, linux-kernel@vger.kernel.org,
rob.herring@calxeda.com, galak@codeaurora.org,
dmaengine@vger.kernel.org, ijc+devicetree@hellion.org.uk,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/4] ASoC: fsl_ssi: Add dual fifo mode support
Date: Thu, 31 Oct 2013 08:54:12 +0100 [thread overview]
Message-ID: <52720CA4.3090003@gmail.com> (raw)
In-Reply-To: <0e947536358af7bd6e179559006a3526801a1abe.1383197521.git.b42378@freescale.com>
Hi
>
> + /* When using dual fifo mode, we need to keep watermark
> + * as even numbers due to dma script limitation.
> + */
> + ssi_private->dma_params_tx.maxburst /= 2;
> + ssi_private->dma_params_tx.maxburst *= 2;
> + ssi_private->dma_params_rx.maxburst /= 2;
> + ssi_private->dma_params_rx.maxburst *= 2;
>
Why not using a mask here ?
ssi_private->dma_params_tx.maxburst &= ~0x1;
ssi_private->dma_params_rx.maxburst &= ~0x1;
Regards,
Philippe
next prev parent reply other threads:[~2013-10-31 7:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 6:32 [PATCH v2 0/4] Add dual-fifo mode support of i.MX ssi Nicolin Chen
2013-10-31 6:32 ` [PATCH v2 2/4] dma: imx-sdma: Add new dma type for ssi dual fifo script Nicolin Chen
2013-10-31 6:32 ` [PATCH v2 3/4] ASoC: fsl_ssi: Add dual fifo mode support Nicolin Chen
2013-10-31 7:54 ` Philippe Rétornaz [this message]
2013-10-31 7:44 ` Nicolin Chen
[not found] ` <cover.1383197521.git.b42378-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-10-31 6:32 ` [PATCH v2 1/4] dma: imx-sdma: Add sdma firmware version 2 support Nicolin Chen
2013-10-31 7:29 ` Sascha Hauer
2013-10-31 6:32 ` [PATCH v2 4/4] ARM: dts: imx: use dual-fifo sdma script for ssi Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52720CA4.3090003@gmail.com \
--to=philippe.retornaz@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=b42378@freescale.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).