From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Ni Subject: Re: [PATCHv4 02/18] thermal: core: allow binding via .bind when tzp is present Date: Wed, 6 Nov 2013 10:56:48 +0800 Message-ID: <5279AFF0.1080105@nvidia.com> References: <1380251605-3804-1-git-send-email-eduardo.valentin@ti.com> <1380251605-3804-3-git-send-email-eduardo.valentin@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1380251605-3804-3-git-send-email-eduardo.valentin@ti.com> Sender: linux-pm-owner@vger.kernel.org To: Eduardo Valentin , "swarren@wwwdotorg.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ian.campbell@citrix.com" , "rob.herring@calxeda.com" , "linux@roeck-us.net" , "rui.zhang@intel.com" Cc: "grant.likely@linaro.org" , "durgadoss.r@intel.com" , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , "lm-sensors@lm-sensors.org" , "linux-kernel@vger.kernel.org" List-Id: devicetree@vger.kernel.org On 09/27/2013 11:13 AM, Eduardo Valentin wrote: > This patch allows drivers register thermal zone devices > with thermal zone params and .bind callbacks. In this case, > it will use the .bind callback. > > Cc: Zhang Rui > Cc: linux-pm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin > --- > drivers/thermal/thermal_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c > index 8a94300..f7a9f4f 100644 > --- a/drivers/thermal/thermal_core.c > +++ b/drivers/thermal/thermal_core.c > @@ -247,7 +247,7 @@ static void bind_cdev(struct thermal_cooling_device *cdev) > if (!pos->tzp && !pos->ops->bind) > continue; > > - if (!pos->tzp && pos->ops->bind) { > + if (pos->ops->bind) { Hi, Eduardo In bind_tz() routine, it also has same problem. I had sent out similar patch "[PATCHv4 02/18] thermal: core: allow binding via .bind when tzp is present" to fix it, but no response yet. I think you can add my changes in your series :) Thanks. Wei. > ret = pos->ops->bind(pos, cdev); > if (ret) > print_bind_err_msg(pos, cdev, ret); >