devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Valentine <valentine.barshak@cogentembedded.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-sh@vger.kernel.org, linux-ide@vger.kernel.org,
	devicetree@vger.kernel.org, Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	Kumar Gala <galak@codeaurora.org>,
	Vladimir Barinov <vladimir.barinov@cogentembedded.com>,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH V2 1/2] sata_rcar: Add R-Car Gen2 SATA PHY support
Date: Fri, 08 Nov 2013 00:13:20 +0400	[thread overview]
Message-ID: <527BF460.1030503@cogentembedded.com> (raw)
In-Reply-To: <1383854642-21660-2-git-send-email-valentine.barshak@cogentembedded.com>

On 11/08/2013 12:04 AM, Valentine Barshak wrote:
> R-Car Gen2 SoCs have a different PHY which is not compatible
> with the older R-Car H1 (R8A7779) version.
> This adds OF/platform device id tables and PHY initialization
> callbacks for the following Gen2 SoCs:
>    * R-Car H2: R8A7790;
>    * R-Car M2: R8A7791.
>
> PHY initialization method is chosen based on the device id.
> Default PHY settings are applied for Gen2 SoCs, which should
> suit the Gen2 boards available.
>
> While at it, this also adds "sata-r8a7779" compatibility string
> for R8A7779 SATA, while keeping the old one for compatibility.
>
> Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>

Tejun,
are you OK with applying this?

All the comments have been addressed in the previous version.
I've just decided to give it a minor white-space clean-up here
to make both array terminators look identical: "{ },".

I wonder if it's not to late for the 3.13.

Thanks,
Val.


  reply	other threads:[~2013-11-07 20:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07 20:04 [PATCH V2 0/2] sata_rcar: Add Gen2 PHY support and document existing DT bindings Valentine Barshak
2013-11-07 20:04 ` [PATCH V2 1/2] sata_rcar: Add R-Car Gen2 SATA PHY support Valentine Barshak
2013-11-07 20:13   ` Valentine [this message]
2013-11-07 20:04 ` [PATCH V2 2/2] dt: Document sata_rcar bindings Valentine Barshak
2013-11-08  1:02   ` Laurent Pinchart
2013-11-08  6:27     ` Kuninori Morimoto
2013-11-08  9:01       ` Simon Horman
2013-11-08 11:26     ` Valentine
2013-11-08 11:52       ` Valentine
2013-11-08 15:31         ` Laurent Pinchart
2013-11-12  3:42           ` Simon Horman
2013-11-12 13:46             ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=527BF460.1030503@cogentembedded.com \
    --to=valentine.barshak@cogentembedded.com \
    --cc=devicetree@vger.kernel.org \
    --cc=g.liakhovetski@gmx.de \
    --cc=galak@codeaurora.org \
    --cc=horms@verge.net.au \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=tj@kernel.org \
    --cc=vladimir.barinov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).