From: Valentine <valentine.barshak@cogentembedded.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-sh@vger.kernel.org, linux-ide@vger.kernel.org,
devicetree@vger.kernel.org, Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Kumar Gala <galak@codeaurora.org>, Tejun Heo <tj@kernel.org>,
Vladimir Barinov <vladimir.barinov@cogentembedded.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH V2 2/2] dt: Document sata_rcar bindings
Date: Fri, 08 Nov 2013 15:52:45 +0400 [thread overview]
Message-ID: <527CD08D.80004@cogentembedded.com> (raw)
In-Reply-To: <527CCA76.5060706@cogentembedded.com>
On 11/08/2013 03:26 PM, Valentine wrote:
> On 11/08/2013 05:02 AM, Laurent Pinchart wrote:
>> Hi Valentine,
>>
>
> Hi Laurent,
>
>> Thank you for the patch. Two small comments below.
>>
>> On Friday 08 November 2013 00:04:02 Valentine Barshak wrote:
>>> These bindings can be used to register SATA devices found on R-Car SoC.
>>>
>>> Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
>>> Acked-by: Kumar Gala <galak@codeaurora.org>
>>> ---
>>> Documentation/devicetree/bindings/ata/sata_rcar.txt | 18 ++++++++++++++++++
>>> 1 file changed, 18 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/ata/sata_rcar.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/ata/sata_rcar.txt
>>> b/Documentation/devicetree/bindings/ata/sata_rcar.txt new file mode 100644
>>> index 0000000..d6b20a6
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/ata/sata_rcar.txt
>>> @@ -0,0 +1,18 @@
>>> +* Renesas R-Car SATA
>>> +
>>> +Required properties:
>>> +- compatible : should contain one of the following:
>>> + - "renesas,sata-r8a7779" for R-Car H1
>>> + - "renesas,sata-r8a7790" for R-Car H2
>>> + - "renesas,sata-r8a7791" for R-Car M2
>>> +- reg : offset and length of the SATA registers;
>>
>> Maybe address instead of offset ?
>
> OK.
>
>>
>>> +- interrupts : must consist of one interrupt specifier.
>>> +
>>> +Example:
>>> +
>>> +sata: sata@fc600000 {
>>> + compatible = "renesas,sata-r8a7779";
>>> + reg = <0xfc600000 0x2000>;
>>> + interrupt-parent = <&gic>;
>>> + interrupts = <0 100 0x4>;
>>
>> Please use IRQ_TYPE_LEVEL_HIGH instead of 0x4.
>
> OK, I'll do that.
>
> Please, note that all the Renesas dts[i] files do not include <dt-bindings/interrupt-controller/irq.h>
> Thus, blindly following this bindings documentation when adding new SATA nodes to the existing
> r8a7790.dtsi, for example, will cause DT compilation error.
>
BTW, we'll also have to switch to #include instead of /include/ to make it work.
Thanks,
Val.
next prev parent reply other threads:[~2013-11-08 11:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 20:04 [PATCH V2 0/2] sata_rcar: Add Gen2 PHY support and document existing DT bindings Valentine Barshak
2013-11-07 20:04 ` [PATCH V2 1/2] sata_rcar: Add R-Car Gen2 SATA PHY support Valentine Barshak
2013-11-07 20:13 ` Valentine
2013-11-07 20:04 ` [PATCH V2 2/2] dt: Document sata_rcar bindings Valentine Barshak
2013-11-08 1:02 ` Laurent Pinchart
2013-11-08 6:27 ` Kuninori Morimoto
2013-11-08 9:01 ` Simon Horman
2013-11-08 11:26 ` Valentine
2013-11-08 11:52 ` Valentine [this message]
2013-11-08 15:31 ` Laurent Pinchart
2013-11-12 3:42 ` Simon Horman
2013-11-12 13:46 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527CD08D.80004@cogentembedded.com \
--to=valentine.barshak@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=g.liakhovetski@gmx.de \
--cc=galak@codeaurora.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tj@kernel.org \
--cc=vladimir.barinov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).