From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grygorii Strashko Subject: Re: [PATCH v5 1/7] gpio: davinci: remove unnecessary printk Date: Fri, 8 Nov 2013 17:39:38 +0200 Message-ID: <527D05BA.3000008@ti.com> References: <1383905510-31760-1-git-send-email-prabhakar.csengg@gmail.com> <1383905510-31760-2-git-send-email-prabhakar.csengg@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1383905510-31760-2-git-send-email-prabhakar.csengg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces+gld-davinci-linux-open-source=gmane.org-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org To: Prabhakar Lad , Sekhar Nori , Linus Walleij Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, DLOS , Pawel Moll , linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Stephen Warren , LKML , Rob Herring , linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Landley , Grant Likely , Ian Campbell , LAK List-Id: devicetree@vger.kernel.org On 11/08/2013 12:11 PM, Prabhakar Lad wrote: > From: "Lad, Prabhakar" > > the devm_*() helper prints error messages in case of > errors no need to do the same in the driver. Pls, drop it - devm_clk_get() doesn't always print error messages > > Signed-off-by: Lad, Prabhakar > --- > drivers/gpio/gpio-davinci.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c > index 84be701..7230c43 100644 > --- a/drivers/gpio/gpio-davinci.c > +++ b/drivers/gpio/gpio-davinci.c > @@ -389,11 +389,9 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev) > } > > clk = devm_clk_get(dev, "gpio"); > - if (IS_ERR(clk)) { > - printk(KERN_ERR "Error %ld getting gpio clock?\n", > - PTR_ERR(clk)); > + if (IS_ERR(clk)) > return PTR_ERR(clk); > - } > + > clk_prepare_enable(clk); > > /* >